verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#7566 fixed summary cards and table #444

Merged
jon merged 8 commits from 7566-FixCustomerSummary into dev 2024-06-19 07:55:59 +00:00
Conversation 0 Commits 8 Files Changed 3 +66 -66
jon commented 2024-06-13 05:44:35 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-06-13 05:44:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fa55e33b54 fix: refs #7566 fixed summary cards and table
jon added 1 commit 2024-06-13 05:45:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2b66148ff5 Merge branch 'dev' into 7566-FixCustomerSummary
jon requested review from jsegarra 2024-06-13 05:46:37 +00:00
jon added 1 commit 2024-06-14 07:11:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
64648c77f6 Merge branch 'dev' into 7566-FixCustomerSummary
jsegarra requested changes 2024-06-17 20:39:34 +00:00
Dismissed
src/pages/Customer/components/CustomerSummaryTable.vue Outdated
@ -215,2 +192,2 @@
class="q-pa-sm"
v-if="setTotalPriceColor(props.row)"
<template
v-if="
jsegarra commented 2024-06-17 20:38:35 +00:00
Member
Copy Link

route y nickname se repiten.

Te diria de hcer la condicion inversa o negada. U otra propuesta, es definir una funcion/regla que evalue si un valor está dentro de unos criterios aceptados

route y nickname se repiten. Te diria de hcer la condicion inversa o negada. U otra propuesta, es definir una funcion/regla que evalue si un valor está dentro de unos criterios aceptados
jon marked this conversation as resolved
src/pages/Customer/components/CustomerSummaryTable.vue
@ -232,3 +201,1 @@
</QTd>
</template>
</QTable>
<span
jsegarra commented 2024-06-17 20:36:23 +00:00
Member
Copy Link

La difernecia entre este v-if y v-else es añadir la class="link".
Si es sí creo que podemos mirar de hacer :class="{link: boolean}"

La difernecia entre este v-if y v-else es añadir la class="link". Si es sí creo que podemos mirar de hacer :class="{link: boolean}"
jon marked this conversation as resolved
src/pages/Customer/components/CustomerSummaryTable.vue
@ -235,0 +211,4 @@
{{ props.value }}
</span>
</template>
<template v-if="props.col.name === 'date'">
jsegarra commented 2024-06-17 20:39:21 +00:00
Member
Copy Link

Si la diferncia entre date y state es el color, podemos de hacer un switch o una cosa mejor

Si la diferncia entre date y state es el color, podemos de hacer un switch o una cosa mejor
jon marked this conversation as resolved
jon added 2 commits 2024-06-18 11:29:24 +00:00
jon added 1 commit 2024-06-18 11:31:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fa425a4329 Merge branch 'dev' into 7566-FixCustomerSummary
jon added 1 commit 2024-06-19 07:07:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a80caa7c93 Merge branch 'dev' into 7566-FixCustomerSummary
jon requested review from jsegarra 2024-06-19 07:07:50 +00:00
jsegarra started working 2024-06-19 07:46:00 +00:00
jsegarra stopped working 2024-06-19 07:54:02 +00:00
8 minutes 2 seconds
jsegarra added 1 commit 2024-06-19 07:54:28 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d5bd8c4432 fix: #7566 remove v-if
jsegarra approved these changes 2024-06-19 07:54:31 +00:00
jon merged commit 97c4130b05 into dev 2024-06-19 07:55:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Total Time Spent: 8 minutes 2 seconds
jsegarra
8 minutes 2 seconds
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#444
No description provided.
Delete Branch "7566-FixCustomerSummary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?