verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

#7566 fixed summary cards and table #444

Merged
jon merged 8 commits from 7566-FixCustomerSummary into dev 2024-06-19 07:55:59 +00:00
Conversation 0 Commits 8 Files Changed 3 +7 -17
1 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 546b43ffcf - Show all commits

24
src/pages/Customer/components/CustomerSummaryTable.vue
View File

@ -162,6 +162,7 @@ const navigateToticketSummary = (id) => {
params: { id },
});
};
const commonColumns = (col) => ['date', 'state', 'total'].includes(col);
</script>
<template>
@ -189,27 +190,16 @@ const navigateToticketSummary = (id) => {
class="rounded-borders"
v-bind="tableColumnComponents[props.col.name].props(props)"
>
<template
v-if="
props.col.name === 'id' ||
props.col.name === 'nickname' ||
props.col.name === 'agency' ||
props.col.name === 'route' ||
props.col.name === 'packages'
"
>
<template v-if="!commonColumns(props.col.name)">
jon marked this conversation as resolved Outdated
jsegarra commented 2024-06-17 20:38:35 +00:00
Outdated
Review
Copy Link

route y nickname se repiten.

Te diria de hcer la condicion inversa o negada. U otra propuesta, es definir una funcion/regla que evalue si un valor está dentro de unos criterios aceptados

route y nickname se repiten. Te diria de hcer la condicion inversa o negada. U otra propuesta, es definir una funcion/regla que evalue si un valor está dentro de unos criterios aceptados
<span
v-if="
props.col.name === 'nickname' ||
props.col.name === 'route'
"
class="link"
:class="{
link:
props.col.name === 'route' ||
props.col.name === 'nickname',
}"
>
{{ props.value }}
jon marked this conversation as resolved
jsegarra commented 2024-06-17 20:36:23 +00:00
Review
Copy Link

La difernecia entre este v-if y v-else es añadir la class="link".
Si es sí creo que podemos mirar de hacer :class="{link: boolean}"

La difernecia entre este v-if y v-else es añadir la class="link". Si es sí creo que podemos mirar de hacer :class="{link: boolean}"
</span>
<span v-else>
{{ props.value }}
</span>
</template>
<template v-if="props.col.name === 'date'">
<QBadge class="q-pa-sm" color="warning">