verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

Weekly tickets #459

Merged
jsegarra merged 8 commits from :feature/WeeklyTickets into dev 2024-06-25 21:02:08 +00:00
Conversation 1 Commits 8 Files Changed 12 +397 -41
hyervoni commented 2024-06-18 14:51:12 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 2 commits 2024-06-18 14:51:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d488a2d523 small change
hyervoni requested review from alexm 2024-06-18 14:51:36 +00:00
hyervoni requested review from jsegarra 2024-06-18 14:51:36 +00:00
jsegarra commented 2024-06-18 21:03:15 +00:00
Member
Copy Link

Se me hace raro que la columna de ID Ticket no se pueda escribir un valor para filtrar. En Salix no está, pero tiene sentido o no está porque para eso tiene la barra de búsqueda?

Se me hace raro que la columna de ID Ticket no se pueda escribir un valor para filtrar. En Salix no está, pero tiene sentido o no está porque para eso tiene la barra de búsqueda?
jsegarra requested changes 2024-06-18 21:07:09 +00:00
Dismissed
src/pages/Ticket/TicketWeekly.vue
@ -0,0 +35,4 @@
const arrayData = useArrayData('WeeklyTickets');
const { store } = arrayData;
const weekdays = [
jsegarra commented 2024-06-18 21:06:27 +00:00
Member
Copy Link

porque no usamos useWeekDayStore? Tendria sentido usarla?

porque no usamos useWeekDayStore? Tendria sentido usarla?
wbuezas commented 2024-06-18 22:29:01 +00:00
Contributor
Copy Link

Si tiene sentido, lo intente, pero los index que se setean en useWeekDayStore no coinciden con los que se requiere en esta tabla

Si tiene sentido, lo intente, pero los index que se setean en useWeekDayStore no coinciden con los que se requiere en esta tabla
src/pages/Ticket/TicketWeekly.vue
@ -0,0 +60,4 @@
try {
const paramKey = col.columnFilter?.filterParamKey || col.field;
params[paramKey] = col.columnFilter.filterValue;
console.log('paramKey', paramKey, 'params', params);
jsegarra commented 2024-06-18 21:06:42 +00:00
Member
Copy Link

👀💣🚩

👀💣🚩
wbuezas commented 2024-06-18 22:29:14 +00:00
Contributor
Copy Link

Removido.

Commit: de0ef06d92

Removido. Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/de0ef06d926b01293350fe5a4ce76ad16307464e
jsegarra marked this conversation as resolved
wbuezas added 1 commit 2024-06-18 22:28:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
de0ef06d92 remove console.log
jsegarra approved these changes 2024-06-19 10:16:26 +00:00
Dismissed
alexm reviewed 2024-06-21 13:00:16 +00:00
src/pages/Ticket/TicketWeekly.vue
@ -0,0 +206,4 @@
:limit="20"
:expr-builder="exprBuilder"
:user-params="params"
:offset="50"
alexm commented 2024-06-21 13:00:16 +00:00
Member
Copy Link

offset?

offset?
jsegarra commented 2024-06-25 10:47:47 +00:00
Member
Copy Link

He probado a tener 20 registros y el limit del componente a 5.
Puede ser casualidad, pero creo que queda mejor poniendo esta propiedad para que la animación del loading del botón no se vea tanto

He probado a tener 20 registros y el limit del componente a 5. Puede ser casualidad, pero creo que queda mejor poniendo esta propiedad para que la animación del loading del botón no se vea tanto
alexm approved these changes 2024-06-25 12:11:18 +00:00
Dismissed
jsegarra added 2 commits 2024-06-25 12:48:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d29bf09535 remove warnings
jsegarra dismissed jsegarra’s review 2024-06-25 12:48:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra dismissed alexm’s review 2024-06-25 12:48:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-06-25 12:49:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0715e86530 Merge branch 'dev' into feature/WeeklyTickets
jsegarra requested review from jsegarra 2024-06-25 12:49:24 +00:00
jsegarra approved these changes 2024-06-25 12:49:30 +00:00
Dismissed
wbuezas added 1 commit 2024-06-25 18:28:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6e6c6301d2 fix log view not refreshing when changing id param
wbuezas dismissed jsegarra’s review 2024-06-25 18:28:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-06-25 20:59:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ff02e5d160 Merge branch 'dev' into feature/WeeklyTickets
jsegarra approved these changes 2024-06-25 21:02:03 +00:00
jsegarra merged commit 2313f8ca0d into dev 2024-06-25 21:02:08 +00:00
jsegarra deleted branch feature/WeeklyTickets 2024-06-25 21:02:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#459
No description provided.
Delete Branch ":feature/WeeklyTickets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?