#7197 fixInvoiceIn #466

Merged
jorgep merged 36 commits from 7197-fixInvoiceIn into dev 2024-07-29 07:44:05 +00:00
Member
No description provided.
jorgep added 2 commits 2024-06-20 13:57:52 +00:00
jorgep added 1 commit 2024-06-20 14:15:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
9e078bc074
fix: refs #7197 vat, intrastat, filter and list sections
jorgep added 1 commit 2024-06-20 14:32:02 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0a6717171c
fix: refs #7197 reactivity invoiceCorrection
jorgep added 1 commit 2024-06-21 14:45:29 +00:00
jorgep added 1 commit 2024-06-24 15:01:03 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
11aadddd55
refactor: refs #7197 use invoiceInSearchbar & queryParams
jorgep added 1 commit 2024-06-25 07:23:09 +00:00
jorgep added 1 commit 2024-06-25 07:50:47 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
9dc9162e8e
fix: refs #7197 amount reactivity
jorgep added 1 commit 2024-06-26 07:46:48 +00:00
jorgep added 1 commit 2024-06-26 09:47:18 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
2cb6d21ade
feat: refs #7197 add correcting filter
jorgep added 1 commit 2024-07-01 09:55:26 +00:00
jorgep added 1 commit 2024-07-01 11:50:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
f2b8217883
fix: refs #7197 rollback
jorgep added 1 commit 2024-07-01 12:21:05 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
f1323ad2c4
fix: refs #7197 add url InvoiceInSearchbar
jorgep added 1 commit 2024-07-02 07:58:14 +00:00
jorgep added 1 commit 2024-07-03 10:27:17 +00:00
jorgep added 1 commit 2024-07-03 10:31:04 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
b0c5f19f1d
merge dev
jorgep added 1 commit 2024-07-03 12:11:41 +00:00
jorgep added 1 commit 2024-07-03 15:14:31 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8f11c82185
feat: refs #7197 summary responsive
jorgep added 1 commit 2024-07-04 10:15:49 +00:00
jorgep added 1 commit 2024-07-04 10:20:51 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
239b34eac0
chore: refs #7197 fix test
jorgep added 1 commit 2024-07-04 11:11:07 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
35fe28fff1
feat: refs #7197 add supplier activities filter option
jorgep added 1 commit 2024-07-04 11:12:10 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4d6e2e2774
chore: refs #7197 drop useless attr
jorgep added 1 commit 2024-07-04 11:56:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8957141222
fix: refs #7197 responsive summary layout
jorgep added 1 commit 2024-07-04 15:31:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cc203022d2
chore: refs #7197 fix unit tests
jorgep added 1 commit 2024-07-04 15:32:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6fd49691d6
chore: refs #7197 remove unused import
jorgep added 1 commit 2024-07-05 07:19:06 +00:00
jorgep added 1 commit 2024-07-05 11:07:50 +00:00
jorgep added 1 commit 2024-07-05 13:41:57 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
9e44896305
chore: refs #7197 fix tests
jorgep added 1 commit 2024-07-05 13:57:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3dd2745dde
fix: refs #7197 rollback crudModel
jorgep added 1 commit 2024-07-05 13:58:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
904fbae251
fix: refs #7197 rollback crudModel
jorgep added 1 commit 2024-07-05 14:00:40 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6de7696fd1
fix: refs #7197 rollback crudModel
jorgep reviewed 2024-07-05 14:01:06 +00:00
src/css/app.scss Outdated
@ -151,6 +151,12 @@ select:-webkit-autofill {
background-color: var(--vn-section-color);
}
.q-table td[shrink] {
Author
Member

Igual que en Salix.

Igual que en Salix.
jorgep added 1 commit 2024-07-05 14:25:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a0ccb239b1
chore: refs #7197 improve form filling in Cypress tests
jorgep added the
CR / Tests passed
label 2024-07-05 14:26:11 +00:00
jorgep requested review from jgallego 2024-07-05 14:26:28 +00:00
jorgep reviewed 2024-07-05 14:26:56 +00:00
@ -98,6 +97,19 @@ defineExpose({
vnPaginateRef,
});
onBeforeRouteLeave((to, from, next) => {
Author
Member

Cuando hayan cambios sin guardar lanzará un aviso

Cuando hayan cambios sin guardar lanzará un aviso
jorgep reviewed 2024-07-05 14:28:00 +00:00
@ -186,3 +186,2 @@
@filter="filterHandler"
hide-selected
fill-input
:hide-selected="$attrs['hide-selected'] ?? true"
Author
Member

Hablado con @alex, si se quiere mostrar un value personalizado necesito cambiar estos atributos

Hablado con @alex, si se quiere mostrar un value personalizado necesito cambiar estos atributos
jorgep reviewed 2024-07-05 14:28:59 +00:00
@ -8,3 +8,3 @@
<template>
<div :class="$q.screen.gt.md ? 'q-pb-lg' : 'q-pb-md'">
<div class="header-link">
<div class="header-link" :style="{ cursor: url ? 'pointer' : 'default' }">
Author
Member

Hay títulos que no redirigen a ningún sitio. es confuso que aparezca el icono de clicable

Hay títulos que no redirigen a ningún sitio. es confuso que aparezca el icono de clicable
jorgep reviewed 2024-07-05 14:29:32 +00:00
@ -130,3 +130,3 @@
});
onBeforeRouteLeave(async (to, from) => {
onBeforeRouteUpdate(async (to, from) => {
Author
Member

Ahora es reactivo

Ahora es reactivo
jorgep reviewed 2024-07-05 14:30:02 +00:00
@ -156,3 +143,1 @@
},
}),
]);
const { data: correctingData } = await axios.get('InvoiceInCorrections', {
Author
Member

No acaba de ser reactivo de la forma anterior.

No acaba de ser reactivo de la forma anterior.
jorgep reviewed 2024-07-05 14:30:18 +00:00
@ -375,3 +365,3 @@
</VnLv>
</template>
<template #action="{ entity }">
<template #actions="{ entity }">
Author
Member

Faltaba la s.

Faltaba la s.
jorgep reviewed 2024-07-05 14:31:02 +00:00
@ -72,7 +72,13 @@ const columns = computed(() => [
]);
const getTotal = (data, key) =>
Author
Member

si no pongo el valor por defecto y el valor es nulo pone NaN

si no pongo el valor por defecto y el valor es nulo pone NaN
jorgep reviewed 2024-07-05 14:31:22 +00:00
@ -126,1 +132,4 @@
:filter-options="['id', 'description']"
:hide-selected="false"
:fill-input="false"
:display-value="formatOpt(row, col, 'description')"
Author
Member

Valor personalizado solicitado por @carlosap

Valor personalizado solicitado por @carlosap
jorgep added 1 commit 2024-07-05 14:32:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4b709caf42
chore: refs #7197 idrop useless class
jorgep reviewed 2024-07-05 14:34:01 +00:00
@ -14,3 +15,4 @@
</script>
<template>
<FetchData
Author
Member

Como solo son 5 opciones , los cargo directamente.

Como solo son 5 opciones , los cargo directamente.
jorgep reviewed 2024-07-05 14:34:33 +00:00
@ -114,6 +121,14 @@ const suppliers = ref([]);
toggle-indeterminate
/>
</QItemSection>
<QItemSection>
Author
Member

filtro solicitado por @carlosap , permite cambiar entre rectifivativas, no rectificativas y ambas.

filtro solicitado por @carlosap , permite cambiar entre rectifivativas, no rectificativas y ambas.
jorgep reviewed 2024-07-05 14:36:00 +00:00
@ -57,2 +42,2 @@
v-for="row of rows"
:key="row.id"
v-for="(row, index) of rows"
:key="index"
Author
Member

De la forma anterior duplicaba registros al aplicar y quitar filtros.

De la forma anterior duplicaba registros al aplicar y quitar filtros.
jorgep reviewed 2024-07-05 14:36:31 +00:00
@ -9,3 +1,1 @@
// });
// cy.waitForElement('.q-page', 6000);
// });
describe('WagonTypeCreate', () => {
Author
Member

Así ya funciona el test, hablado con @jsegarra

Así ya funciona el test, hablado con @jsegarra
jorgep reviewed 2024-07-05 14:37:46 +00:00
@ -14,3 +15,4 @@
cy.get(createRectificative).click();
cy.get(saveDialog).click();
cy.wait('@corrective').then((interception) => {
Author
Member

Espera a que se haga llamada y cambie de id de factura y hacer click en la sección corrective

Espera a que se haga llamada y cambie de id de factura y hacer click en la sección corrective
jorgep reviewed 2024-07-05 14:38:44 +00:00
@ -25,3 +23,2 @@
cy.addRow();
cy.fillRow(thirdRow, rowData);
cy.fillRow(thirdRow, [
Author
Member

solo se usa 1 vez

solo se usa 1 vez
jorgep reviewed 2024-07-05 14:39:30 +00:00
@ -31,3 +35,3 @@
it('should remove the first line', () => {
cy.removeRow(2);
cy.removeRow(1);
Author
Member

Ahora la fn removeRow le resta 1 al index para que sea más intuitivo ya que busca en un array y la primera posición es 0.

Ahora la fn removeRow le resta 1 al index para que sea más intuitivo ya que busca en un array y la primera posición es 0.
jorgep reviewed 2024-07-05 14:40:00 +00:00
@ -196,3 +198,3 @@
.its('length')
.then((length) => {
cy.get('.q-checkbox').eq(rowIndex).click();
cy.get(`${trEls} .q-checkbox`)
Author
Member

Ahora tiene el comportamiento deseado

Ahora tiene el comportamiento deseado
jorgep reviewed 2024-07-05 14:41:38 +00:00
@ -38,6 +38,7 @@ vi.mock('vue-router', () => ({
meta: { moduleName: 'mockName' },
path: 'mockSection/list',
}),
onBeforeRouteLeave: () => {},
Author
Member

mockeado.

mockeado.
jorgep added 1 commit 2024-07-05 14:44:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
028ae0b9ac
chore: refs #7197 drop space
jgallego requested changes 2024-07-08 05:57:20 +00:00
Dismissed
@ -489,2 +479,4 @@
max-width: 45em;
}
.q-field:nth-child(1) {
padding-bottom: 20px;
Owner

no se puede poner para todos los descriptor si esto realmente es necesario?

no se puede poner para todos los descriptor si esto realmente es necesario?
Author
Member

Es de un dialogo de este descriptor. Pasa porque si se declara un qselect como campo obligatorio, este muestra un texto en rojo justo debajo. Dejando más espacio que el que no es obligatorio. He probado añadir el dialogo dentro de carddescriptor y el css en el style de este pero no funciona porque loss dialogos no se añaden dentro del componente se añaden como un div externo al layout principal. He probado añadirlo en el archivo app.scss y así se aplica en todos lados, pero no queda bien en todos los sitios. Este estilo solo lo veo aplicable en este dialogo en concreto.

Es de un dialogo de este descriptor. Pasa porque si se declara un qselect como campo obligatorio, este muestra un texto en rojo justo debajo. Dejando más espacio que el que no es obligatorio. He probado añadir el dialogo dentro de carddescriptor y el css en el style de este pero no funciona porque loss dialogos no se añaden dentro del componente se añaden como un div externo al layout principal. He probado añadirlo en el archivo app.scss y así se aplica en todos lados, pero no queda bien en todos los sitios. Este estilo solo lo veo aplicable en este dialogo en concreto.
jorgep added 1 commit 2024-07-29 06:04:50 +00:00
jorgep added 1 commit 2024-07-29 06:46:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
979b3b2a6c
fix: refs #7197 drop character
jorgep requested review from jgallego 2024-07-29 06:47:06 +00:00
jgallego approved these changes 2024-07-29 07:14:43 +00:00
jorgep merged commit 328c54deee into dev 2024-07-29 07:44:05 +00:00
jorgep deleted branch 7197-fixInvoiceIn 2024-07-29 07:44:05 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#466
No description provided.