verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

#7014 refactor <module>Main.vue #476

Merged
jon merged 14 commits from 7014-RefactorQDrawer into dev 2024-07-24 05:17:14 +00:00
Conversation 0 Commits 14 Files Changed 41 +81 -292
jon commented 2024-06-24 11:46:47 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-06-24 11:46:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
9207b37419 refactor: refs #7014 refactor <module>Main.vue
jon added 1 commit 2024-06-25 07:51:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1332ef8d0b Merge branch 'dev' into 7014-RefactorQDrawer
jon added 2 commits 2024-06-25 08:28:57 +00:00
jon added 2 commits 2024-06-26 05:26:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f596a9b5f7 fix: refs #7014 fix wagon module
jon added 1 commit 2024-07-23 06:18:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
92b053013f Merge branch 'dev' into 7014-RefactorQDrawer
jon requested review from jsegarra 2024-07-23 06:21:46 +00:00
jon changed title from WIP: #7014 refactor <module>Main.vue to #7014 refactor <module>Main.vue 2024-07-23 06:22:20 +00:00
jsegarra reviewed 2024-07-23 06:37:01 +00:00
jsegarra left a comment
Member
Copy Link

Un cambio tan significativo, ¿ debería tener test:e2e de sólo al menos que cargue cada sección o con el módulo bastaría?

Un cambio tan significativo, ¿ debería tener test:e2e de sólo al menos que cargue cada sección o con el módulo bastaría?
src/pages/Route/RouteMain.vue Outdated
@ -1,6 +1,6 @@
<script setup>
import VnSectionMain from 'components/common/VnSectionMain.vue';
jsegarra commented 2024-07-23 06:35:41 +00:00
Member
Copy Link

Porque este archivo no está eliminado? Que condición tiene?

Porque este archivo no está eliminado? Que condición tiene?
jon marked this conversation as resolved
src/pages/Zone/ZoneMain.vue Outdated
@ -1,11 +1,9 @@
<script setup>
import VnSectionMain from 'components/common/VnSectionMain.vue';
jsegarra commented 2024-07-23 06:35:38 +00:00
Member
Copy Link

Porque este archivo no está eliminado? Que condición tiene?

Porque este archivo no está eliminado? Que condición tiene?
jon marked this conversation as resolved
jon added 4 commits 2024-07-23 07:15:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e76d8bf269 fix: fix conflicts
jon added 1 commit 2024-07-23 08:38:52 +00:00
jon added 1 commit 2024-07-23 08:55:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7ce05406cc fix: refs #7014 fix tests
jsegarra approved these changes 2024-07-23 21:08:53 +00:00
jsegarra added 1 commit 2024-07-23 21:08:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6c7509856e Merge branch 'dev' into 7014-RefactorQDrawer
jon merged commit 19fa5a294d into dev 2024-07-24 05:17:13 +00:00
jon deleted branch 7014-RefactorQDrawer 2024-07-24 05:17:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#476
No description provided.
Delete Branch "7014-RefactorQDrawer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?