verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#6943 removes duplicate toggle menu & fix loading animation #491

Merged
jorgep merged 7 commits from 6943-fixCustomerGreuges into dev 2024-07-04 07:25:44 +00:00
Conversation 0 Commits 7 Files Changed 1 +4 -21
jorgep commented 2024-06-27 08:46:23 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-06-27 08:46:24 +00:00
jorgep added 1 commit 2024-06-27 08:48:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d3f119fa04 chore: refs #6943 check if exists
jorgep changed title from #6943 removes duplicate toggle menu & fix loading animation to WIP: #6943 removes duplicate toggle menu & fix loading animation 2024-06-27 08:51:15 +00:00
jorgep changed title from WIP: #6943 removes duplicate toggle menu & fix loading animation to #6943 removes duplicate toggle menu & fix loading animation 2024-06-27 10:03:49 +00:00
jorgep requested review from jgallego 2024-06-27 10:03:55 +00:00
jorgep reviewed 2024-06-27 10:11:45 +00:00
src/pages/Customer/Card/CustomerGreuges.vue Outdated
@ -128,3 +111,3 @@
<QDrawer v-model="stateStore.rightDrawer" side="right" :width="300" show-if-above>
<QCard class="full-width q-pa-sm">
<h6 class="flex justify-end q-my-lg q-pr-lg" v-if="totalAmount">
<h6 class="flex justify-end q-my-lg q-pr-lg" v-if="totalAmount >= 0">
jorgep commented 2024-06-27 10:11:45 +00:00
Author
Member
Copy Link

Si es undefined, quiere decir que no aún se está haciendo la llamada para obetener los datos. Un vez se ha hecho totalAmount ya es como mínimo igual a 0. Así nos evitamos crear una variable tipo "isLoading".

Otra alternativa sería: v-if="totalAmount !== undefined"

Si es undefined, quiere decir que no aún se está haciendo la llamada para obetener los datos. Un vez se ha hecho totalAmount ya es como mínimo igual a 0. Así nos evitamos crear una variable tipo "isLoading". Otra alternativa sería: **v-if="totalAmount !== undefined"**
jgallego commented 2024-06-28 06:13:20 +00:00
Owner
Copy Link

el total amount podria ser < 0

el total amount podria ser < 0
jorgep commented 2024-06-28 07:54:55 +00:00
Author
Member
Copy Link

Pues lo cambio a la alternativa

Pues lo cambio a la alternativa
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-06-28 07:55:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ca504ffead Merge branch 'dev' into 6943-fixCustomerGreuges
jorgep added 1 commit 2024-06-28 08:24:28 +00:00
jorgep added 1 commit 2024-06-28 09:17:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ffdcb28522 refactor: refs #6943 initialize totalAmount as undefined
jorgep added the
CR / Tests passed
 label 2024-06-28 09:18:51 +00:00
jorgep added 1 commit 2024-07-03 12:00:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7098ec03de Merge branch 'dev' into 6943-fixCustomerGreuges
jgallego approved these changes 2024-07-03 15:16:18 +00:00
jorgep added 1 commit 2024-07-03 15:40:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d6ff9a184b Merge branch 'dev' into 6943-fixCustomerGreuges
jorgep merged commit b09cbe442c into dev 2024-07-04 07:25:44 +00:00
jorgep deleted branch 6943-fixCustomerGreuges 2024-07-04 07:25:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#491
No description provided.
Delete Branch "6943-fixCustomerGreuges"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?