verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

Ticket Dms #495

Merged
jsegarra merged 14 commits from :feature/TicketDms into dev 2024-07-15 09:30:58 +00:00
Conversation 1 Commits 14 Files Changed 7 +146 -2
hyervoni commented 2024-06-27 15:07:07 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 4 commits 2024-06-27 15:07:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0e8106af17 Resolve conflicts
hyervoni requested review from alexm 2024-06-27 15:07:15 +00:00
hyervoni requested review from jsegarra 2024-06-27 15:07:16 +00:00
jsegarra added 1 commit 2024-06-28 11:22:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2d2fff1bf3 perf: Dms buttons tooltip
jsegarra approved these changes 2024-06-28 11:23:05 +00:00
Dismissed
alexm requested changes 2024-07-01 06:26:17 +00:00
Dismissed
src/components/common/VnDmsList.vue Outdated
@ -378,0 +395,4 @@
</QTooltip>
</QBtn>
</QPageSticky>
<QPageSticky v-if="allowImport" position="bottom-right" :offset="[25, 90]">
alexm commented 2024-07-01 06:26:15 +00:00
Member
Copy Link

No pondría una cosa concreta de ticket en un componente genérico

No pondría una cosa concreta de ticket en un componente genérico
wbuezas commented 2024-07-01 12:53:55 +00:00
Contributor
Copy Link

Al no usarse la funcionalidad de import en ningún otro lado decidi quitarlo de VnDmsList y moverlo a TicketDms

Al no usarse la funcionalidad de import en ningún otro lado decidi quitarlo de `VnDmsList` y moverlo a `TicketDms`
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-07-01 07:59:04 +00:00
Dismissed
src/components/common/VnDmsImportForm.vue Outdated
@ -0,0 +33,4 @@
dmsFk: dmsId.value,
};
await axios.post('ticketDms', data);
jsegarra commented 2024-07-01 07:59:02 +00:00
Member
Copy Link

TicketDms ??
Habría que hacerlo genérico

TicketDms ?? Habría que hacerlo genérico
wbuezas commented 2024-07-01 12:54:28 +00:00
Contributor
Copy Link

Al no usarse la funcionalidad de import en ningún otro lado decidi quitarlo de VnDmsList y moverlo a TicketDms

Al no usarse la funcionalidad de import en ningún otro lado decidi quitarlo de `VnDmsList` y moverlo a `TicketDms`
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-07-01 08:06:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f23b7837b7 perf: Dms buttons tooltip
jsegarra dismissed jsegarra’s review 2024-07-01 08:06:32 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

wbuezas added 2 commits 2024-07-01 12:51:49 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
72aef18c49 Add tooltip
jsegarra requested review from alexm 2024-07-01 13:03:09 +00:00
jsegarra added 1 commit 2024-07-01 13:03:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7896e3d7f9 Merge branch 'dev' into feature/TicketDms
jsegarra commented 2024-07-01 13:05:09 +00:00
Member
Copy Link

@wbuezas Cuando importas un archivo que no existe aparecen 2 mensajes de OK y uno de KO porque se ve que cancelerSignal no se ha procesado correctamente. @alexm Esto seria critico?

@wbuezas Cuando importas un archivo ya existente aparece el mensaje en español e ingles. el ingles creo que es por el throw. @alexm puedes confirmar que Esto no es necesario mostrar?

@wbuezas Cuando importas un archivo que no existe aparecen 2 mensajes de OK y uno de KO porque se ve que cancelerSignal no se ha procesado correctamente. @alexm Esto seria critico? @wbuezas Cuando importas un archivo ya existente aparece el mensaje en español e ingles. el ingles creo que es por el throw. @alexm puedes confirmar que Esto no es necesario mostrar?
jsegarra added 3 commits 2024-07-09 07:15:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3f2b675d07 feat: change ticketDms leftMenuItem position
jsegarra approved these changes 2024-07-09 07:15:57 +00:00
Dismissed
alexm approved these changes 2024-07-15 08:20:18 +00:00
Dismissed
jsegarra added 1 commit 2024-07-15 09:29:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c56610515c Merge branch 'dev' into TicketDms
jsegarra dismissed jsegarra’s review 2024-07-15 09:29:54 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra dismissed alexm’s review 2024-07-15 09:29:54 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra approved these changes 2024-07-15 09:30:01 +00:00
jsegarra added 1 commit 2024-07-15 09:30:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8ea1fb6793 Merge branch 'dev' into feature/TicketDms
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-07-15 09:30:20 +00:00
jsegarra merged commit 9c6722a6fd into dev 2024-07-15 09:30:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#495
No description provided.
Delete Branch ":feature/TicketDms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?