verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 61 Releases Wiki Activity

fixes #4797 Seccion Worker/Notification #51

Merged
alexandre merged 23 commits from 4797-worker-notification-selector into dev 2023-05-15 09:42:17 +00:00
Conversation 0 Commits 23 Files Changed 6 +294 -1
alexandre commented 2023-04-27 12:22:17 +00:00
Contributor
Copy Link
No description provided.
alexandre added 12 commits 2023-04-27 12:22:18 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
baaf6b6c74 refs #4797 @6h
gitea/salix-front/pipeline/head This commit looks good Details
7d198a819b add icons
gitea/salix-front/pipeline/head This commit looks good Details
cbeeea8f88 refs #4797 @2,30h
gitea/salix-front/pipeline/head This commit looks good Details
72d8cb7c04 allow only the user to modify itself
gitea/salix-front/pipeline/head There was a failure building this commit Details
f98c82185f Merge branch '4834-create-worker-module' into 4797-worker-notification-selector
gitea/salix-front/pipeline/head There was a failure building this commit Details
3824ea62c9 changed the boss or user check to the backend
gitea/salix-front/pipeline/head There was a failure building this commit Details
b4d66e8496 refs #4797 @2h
gitea/salix-front/pipeline/head There was a failure building this commit Details
50376a3ec5 change request parameters to match backend
gitea/salix-front/pipeline/head There was a failure building this commit Details
52988f6299 change request to the backend
gitea/salix-front/pipeline/head There was a failure building this commit Details
9e0adce4f1 fix error not being able to unsubscribe instantly
gitea/salix-front/pipeline/head There was a failure building this commit Details
88e8530b43 add isloading
alexandre added 1 commit 2023-04-27 12:24:33 +00:00
alexandre added 1 commit 2023-05-02 05:22:23 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
ba9d8b3c21 refs #4797 section code refactored
alexandre added 1 commit 2023-05-02 06:42:40 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
5702e23c6f refs #4797 e2e test
alexandre added 1 commit 2023-05-02 09:27:31 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d4cc8830d8 refs #4797 added unit test
alexandre added 1 commit 2023-05-02 12:01:50 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
82e805eebf refs #4797 unit test refactored
alexandre changed title from WIP: #4797 Seccion Worker/Notification to fixes #4797 Seccion Worker/Notification 2023-05-02 12:05:20 +00:00
alexandre requested review from alexm 2023-05-02 12:05:23 +00:00
alexm added 1 commit 2023-05-03 05:09:29 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
216114d55b Merge branch 'dev' into 4797-worker-notification-selector
alexandre added 2 commits 2023-05-09 09:45:25 +00:00
alexandre added 1 commit 2023-05-10 12:24:58 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
f53745f1f7 refs #4797 fixing e2e
alexm reviewed 2023-05-15 07:47:21 +00:00
src/pages/Worker/Card/WorkerNotificationsManager.vue
@ -0,0 +32,4 @@
notifications.value = res.data;
}
});
} catch (e) {
alexm commented 2023-05-15 07:47:21 +00:00
Member
Copy Link

Aço es necesari? en la funcio de baix no ha fet falta?

Aço es necesari? en la funcio de baix no ha fet falta?
alexandre commented 2023-05-15 08:31:13 +00:00
Author
Contributor
Copy Link

Per algun motiu en vitest si les cridades que fa axios no estan manejades te llança un error Unhandled Rejection. En esta funció ho he posat en un try/catch perque no havia de fer res, en les altres funcions sí que està manejat gastant el .catch() de axios.

Per algun motiu en vitest si les cridades que fa axios no estan manejades te llança un error *Unhandled Rejection*. En esta funció ho he posat en un try/catch perque no havia de fer res, en les altres funcions sí que està manejat gastant el .catch() de axios.
alexandre marked this conversation as resolved
alexm reviewed 2023-05-15 07:49:42 +00:00
test/cypress/integration/workerNotificationsManager.spec.js
@ -0,0 +1,27 @@
describe('WorkerNotificationsManager', () => {
alexm commented 2023-05-15 07:49:42 +00:00
Member
Copy Link

Feslos que no depenguen un de altres, per exemple el ultim depen dels anteriors

Feslos que no depenguen un de altres, per exemple el ultim depen dels anteriors
alexandre marked this conversation as resolved
alexm requested changes 2023-05-15 07:51:34 +00:00
src/pages/Worker/Card/WorkerNotificationsManager.vue Outdated
@ -0,0 +108,4 @@
</div>
</QItem>
</div>
<div v-show="notifications.length > 0">
alexm commented 2023-05-15 07:51:28 +00:00
Member
Copy Link

v-show="notifications.length" valdria?

v-show="notifications.length" valdria?
alexandre marked this conversation as resolved
alexandre added 1 commit 2023-05-15 08:57:29 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
ecb83f24dc refs #4797 minor fixes
alexandre requested review from alexm 2023-05-15 09:36:22 +00:00
alexm added 1 commit 2023-05-15 09:37:53 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
725e8db7d8 Merge branch 'dev' into 4797-worker-notification-selector
alexm approved these changes 2023-05-15 09:39:20 +00:00
alexandre merged commit a1ca8c822f into dev 2023-05-15 09:42:17 +00:00
alexandre deleted branch 4797-worker-notification-selector 2023-05-15 09:42:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#51
No description provided.
Delete Branch "4797-worker-notification-selector"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?