#6899 end invoiceOut migration with VnTable #513

Merged
jon merged 18 commits from 6899_InvoiceOut_End into dev 2024-07-08 09:34:44 +00:00
Member
No description provided.
jon added 1 commit 2024-07-02 13:23:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
cdbbd576e3
refactor: refs #6899 end invoiceOut migration with VnTable
jon added 1 commit 2024-07-02 13:25:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
06f8121ede
Merge branch 'dev' into 6899_InvoiceOut_End
jon added 1 commit 2024-07-03 07:46:08 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
10f5323b9a
refactor: refs #6899 fix negativeBases call
jon added 1 commit 2024-07-03 07:47:01 +00:00
jon reviewed 2024-07-03 07:49:10 +00:00
@ -41,0 +13,4 @@
const userParams = {
from: Date.vnFirstDayOfMonth().toISOString(),
to: Date.vnLastDayOfMonth().toISOString(),
};
Author
Member

Se ha decidido dejar así para no hacer dos llamadas iguales(la del Vntable y la del arrayData)

Se ha decidido dejar así para no hacer dos llamadas iguales(la del Vntable y la del arrayData)
jsegarra marked this conversation as resolved
jon reviewed 2024-07-03 07:50:21 +00:00
@ -238,3 +238,3 @@
try {
const arrayData = useArrayData('InvoiceOutNegative');
const params = arrayData.store.currentFilter;
const params = arrayData.store.userParams;
Author
Member

Debido al cambio en el uso de arrayData en negativeBases la store deja de tener currentFitler, y le pasa los userParams declarados

Debido al cambio en el uso de arrayData en negativeBases la store deja de tener currentFitler, y le pasa los userParams declarados
jon changed title from WIP: #6899 end invoiceOut migration with VnTable to #6899 end invoiceOut migration with VnTable 2024-07-03 07:50:30 +00:00
jon requested review from jgallego 2024-07-03 07:50:36 +00:00
jgallego refused to review 2024-07-03 09:34:46 +00:00
jgallego requested review from jsegarra 2024-07-03 09:35:00 +00:00
jsegarra requested changes 2024-07-03 09:51:42 +00:00
Dismissed
@ -118,2 +118,3 @@
/>
<FormPopup
<QDialog ref="dialogRef">
<FormPopup
Member

Has probado a usar FormPopupDialog?

Has probado a usar FormPopupDialog?
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-07-03 09:52:46 +00:00
Dismissed
@ -127,1 +134,4 @@
};
const showTransferInvoiceForm = async () => {
$props.menuRef.hide();
Member

Ufff... me suena que esto ya pasó una vez y lo corregimos

Ufff... me suena que esto ya pasó una vez y lo corregimos
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-07-03 10:30:17 +00:00
Dismissed
@ -115,6 +121,7 @@ const refundInvoice = async (withWarehouse) => {
try {
const params = { ref: $props.invoiceOutData.ref, withWarehouse: withWarehouse };
const { data } = await axios.post('InvoiceOuts/refund', params);
location.href = `${salixUrl.value}ticket/${data[0].id}/sale`;
Member

podemos probar a usar window.origin en vez de salixURL?

podemos probar a usar window.origin en vez de salixURL?
jon marked this conversation as resolved
@ -4,3 +4,3 @@
import { useI18n } from 'vue-i18n';
import axios from 'axios';
import { toCurrency, toDate } from 'src/filters';
import { toCurrency, toDate, toPercentage } from 'src/filters';
Member

Hay una traducción que no va bien

Hay una traducción que no va bien
jon marked this conversation as resolved
jon added 1 commit 2024-07-04 06:27:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8dc1ec75b3
refactor: refs #6899 requested changes
jon added 1 commit 2024-07-04 06:28:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fcc8d59cb3
Merge branch 'dev' into 6899_InvoiceOut_End
jon requested review from jsegarra 2024-07-04 06:29:03 +00:00
jon added 2 commits 2024-07-04 12:04:08 +00:00
jon added 1 commit 2024-07-04 12:05:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
34c877bd64
Merge branch 'dev' into 6899_InvoiceOut_End
jsegarra requested changes 2024-07-04 15:51:48 +00:00
Dismissed
@ -32,0 +43,4 @@
isTitle: true,
component: 'select',
attrs: {
url: 'InvoiceOuts',
Member

5 veces aparece la misma url.

Propuesta, crear una constante que sea MODEL = 'InvoiceOuts'

5 veces aparece la misma url. Propuesta, crear una constante que sea MODEL = 'InvoiceOuts'
jon marked this conversation as resolved
@ -61,3 +151,1 @@
};
const openPdf = () => {
function downloadPdf() {
Member

hay un composable que hace justo esto.
Se llama usePrintservice
Pruébalo y sino cumple las necesidades, vemos si aplicarlo o no

En la línea 170 también

hay un composable que hace justo esto. Se llama usePrintservice Pruébalo y sino cumple las necesidades, vemos si aplicarlo o no En la línea 170 también
jon marked this conversation as resolved
jon added 2 commits 2024-07-05 08:16:59 +00:00
jon added 1 commit 2024-07-05 08:21:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e08a7710cf
Merge branch 'dev' into 6899_InvoiceOut_End
jon requested review from jsegarra 2024-07-05 08:22:14 +00:00
jsegarra requested changes 2024-07-05 08:32:16 +00:00
Dismissed
@ -32,0 +122,4 @@
},
{
align: 'right',
label: '',
Member

Si no pones label, no se rompe nada.
Yo también he pecado de lo mismo

Si no pones label, no se rompe nada. Yo también he pecado de lo mismo
jsegarra marked this conversation as resolved
@ -83,2 +172,2 @@
const url = `api/InvoiceOuts/downloadZip?${params}`;
window.open(url, '_blank');
openReport(`${MODEL}/downloadZip`, params);
// const url = `api/${MODEL}/downloadZip?${params}`;
Member

Eliminar comentarios

Eliminar comentarios
jsegarra marked this conversation as resolved
@ -211,0 +217,4 @@
default-mode="table"
redirect="invoice-out"
auto-load
:table="{
Member

Duda: era q-table o table?

Duda: era q-table o table?
jsegarra marked this conversation as resolved
@ -186,0 +168,4 @@
auto-load
:is-editable="false"
:use-model="true"
:order="''"
Member

👀

👀
jsegarra marked this conversation as resolved
jon added 2 commits 2024-07-05 12:02:32 +00:00
jon added 1 commit 2024-07-05 12:03:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6a4eb9f3b8
Merge branch 'dev' into 6899_InvoiceOut_End
jon added 2 commits 2024-07-05 12:06:04 +00:00
jon requested review from jsegarra 2024-07-05 12:06:50 +00:00
jsegarra approved these changes 2024-07-08 09:09:49 +00:00
jon added 1 commit 2024-07-08 09:32:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7d90b536b0
Merge branch 'dev' into 6899_InvoiceOut_End
jon merged commit 03d47d0145 into dev 2024-07-08 09:34:44 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#513
No description provided.