verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

Sale tracking #514

Merged
jsegarra merged 11 commits from :feature/SaleTracking into dev 2024-07-15 09:24:36 +00:00
Conversation 0 Commits 11 Files Changed 8 +638 -77
hyervoni commented 2024-07-03 00:48:20 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 2 commits 2024-07-03 00:48:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
34ee92ac24 Small change
hyervoni requested review from alexm 2024-07-03 00:48:27 +00:00
hyervoni requested review from jsegarra 2024-07-03 00:48:27 +00:00
jsegarra requested changes 2024-07-03 09:07:38 +00:00
Dismissed
src/pages/Ticket/Card/TicketSaleTracking.vue Outdated
@ -0,0 +246,4 @@
try {
const params = {
saleFk: sale.saleFk,
isChecked: isChecked,
jsegarra commented 2024-07-03 08:09:56 +00:00
Member
Copy Link

❌=> isChecked: isChecked,
✅ => isChecked,

❌=> isChecked: isChecked, ✅ => isChecked,
jsegarra marked this conversation as resolved
src/pages/Ticket/Card/TicketSaleTracking.vue Outdated
@ -0,0 +248,4 @@
saleFk: sale.saleFk,
isChecked: isChecked,
quantity: sale.quantity,
stateCode: stateCode,
jsegarra commented 2024-07-03 08:10:05 +00:00
Member
Copy Link

❌=> stateCode: stateCode,
✅ => stateCode,

❌=> stateCode: stateCode, ✅ => stateCode,
jsegarra marked this conversation as resolved
src/pages/Ticket/Card/TicketSaleTracking.vue Outdated
@ -0,0 +257,4 @@
}
};
const saleTrackingDel = async (sale, stateCode) => {
jsegarra commented 2024-07-03 08:11:55 +00:00
Member
Copy Link

Si solo tiene un uso, se puede desestructurar y en la linea 263 puedes hacer saleFk en vez de saleFk: sale.saleFk

Si solo tiene un uso, se puede desestructurar y en la linea 263 puedes hacer saleFk en vez de saleFk: sale.saleFk
jsegarra marked this conversation as resolved
src/pages/Ticket/Card/TicketSaleTracking.vue Outdated
@ -0,0 +284,4 @@
const clickPreviousSelected = (sale) => {
try {
if (!sale.isPreviousSelected) {
jsegarra commented 2024-07-03 08:13:46 +00:00
Member
Copy Link

Propuesta: trasladar los textos literales a variables contantes
Pej:
const PREVIOUS_PREPARATION = 'PREVIOUS_PREPARATION'
Y reemplazas donde toque

Si procede, aplicar al resto

Propuesta: trasladar los textos literales a variables contantes Pej: const PREVIOUS_PREPARATION = 'PREVIOUS_PREPARATION' Y reemplazas donde toque Si procede, aplicar al resto
jsegarra marked this conversation as resolved
src/pages/Ticket/Card/TicketSaleTracking.vue
@ -0,0 +365,4 @@
>
<template #body-cell-isChecked="{ row }">
<QTd @click.stop>
<QCheckbox
jsegarra commented 2024-07-03 09:07:36 +00:00
Member
Copy Link

No son redondos

Añadir

<style lang="scss">
.q-checkbox__bg.absolute {
    border-radius: 50% !important;
}
</style>
No son redondos Añadir ``` <style lang="scss"> .q-checkbox__bg.absolute { border-radius: 50% !important; } </style> ```
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-07-03 09:48:56 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
c25b04e075 improve QChebox
jsegarra added 1 commit 2024-07-04 08:40:18 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4a01f1d930 perf: cleancode
jsegarra added 2 commits 2024-07-09 07:41:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c5c96bf51b Merge branch 'dev' into feature/SaleTracking
jsegarra approved these changes 2024-07-09 07:43:01 +00:00
Dismissed
jsegarra added 1 commit 2024-07-09 07:59:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a9e19309ee fix warning
jsegarra dismissed jsegarra’s review 2024-07-09 07:59:44 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 2 commits 2024-07-09 08:18:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
38dd54b2f5 fix: i18n components
alexm approved these changes 2024-07-15 08:16:47 +00:00
Dismissed
alexm added 1 commit 2024-07-15 08:17:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cc8062785a Merge branch 'dev' into feature/SaleTracking
alexm dismissed alexm’s review 2024-07-15 08:17:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-07-15 08:17:13 +00:00
Dismissed
jsegarra added 1 commit 2024-07-15 09:23:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ae55983405 Merge branch 'dev' into feature/SaleTracking
jsegarra dismissed alexm’s review 2024-07-15 09:23:55 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra approved these changes 2024-07-15 09:24:09 +00:00
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-07-15 09:24:13 +00:00
jsegarra merged commit 3eba0a234b into dev 2024-07-15 09:24:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#514
No description provided.
Delete Branch ":feature/SaleTracking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?