#7354 end Zone migration #539

Merged
jon merged 58 commits from 7354_ZoneMigration_End into dev 2024-09-03 04:48:18 +00:00
Member
No description provided.
jon added 1 commit 2024-07-09 10:51:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8c744fac5a
refactor: refs #7354 Zone migration changes
jon added 1 commit 2024-07-09 10:54:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0b135bbd52
fix: refs #7354 fix delivery days
jon added 2 commits 2024-07-10 07:37:39 +00:00
jon changed title from WIP: #7354 end Zone migration to #7354 end Zone migration 2024-07-10 07:39:08 +00:00
jon requested review from jgallego 2024-07-10 07:39:14 +00:00
jgallego requested changes 2024-07-10 11:21:58 +00:00
Dismissed
@ -41,3 +41,3 @@
remove: async () => {
try {
await axios.post(`Zones/${zoneId}/setDeleted`);
await axios.delete(`Zones/${zoneId}`);
Owner

el antiguo zones setDeleted donde estaba?

el antiguo zones setDeleted donde estaba?
Author
Member

lo que hay es tickets/{id}/setDeleted, pero para zones no existe como tal zones/id/setDeleted

lo que hay es tickets/{id}/setDeleted, pero para zones no existe como tal zones/id/setDeleted
jgallego marked this conversation as resolved
@ -116,6 +116,7 @@ const closeForm = () => emit('closeForm');
const refetchEvents = async () => {
await arrayData.refresh({ append: false });
closeForm();
// window.location.reload();
Owner

?

?
jgallego marked this conversation as resolved
@ -123,2 +123,3 @@
v-model="formData.agencyModeFk"
url="AgencyModes/isActive"
:url="
deliveryMethodFk === 'delivery'
Owner

esto que hace?

esto que hace?
Author
Member

Cuando deliveryMethodFk es delivery muestra el select de código postal y agencia. Sin embargo si el deliveryMethodFk es pickup estaba puesto el label de almacenes, pero en el select no mostraba nada porque no se tenía en cuenta la condición del v-if

Cuando deliveryMethodFk es delivery muestra el select de código postal y agencia. Sin embargo si el deliveryMethodFk es pickup estaba puesto el label de almacenes, pero en el select no mostraba nada porque no se tenía en cuenta la condición del v-if
Member

Hola @jon , revisamos pero en /salix/modules/zone/front/delivery-days/index.html el campo deliveryMethodFk no se usa para distinguir la ruta sino la label del desplegable.
Es cierto que en local no hay registros cuando seleccionas recogida, sin embargo en entornos desplegados, si que hay registros.

Hola @jon , revisamos pero en /salix/modules/zone/front/delivery-days/index.html el campo deliveryMethodFk no se usa para distinguir la ruta sino la label del desplegable. Es cierto que en local no hay registros cuando seleccionas recogida, sin embargo en entornos desplegados, si que hay registros.
jgallego marked this conversation as resolved
@ -24,0 +24,4 @@
travelingDays: Días de viaje
warehouse: Almacén
bonus: Bonus
hour: Cierre
Owner

hour es hora..si quieres que sea hora de cierre, cambia la clave sino puede ser muy confuso o colisionar en el futuro con otras claves

hour es hora..si quieres que sea hora de cierre, cambia la clave sino puede ser muy confuso o colisionar en el futuro con otras claves
jgallego marked this conversation as resolved
jgallego requested review from jsegarra 2024-07-10 11:22:04 +00:00
jon added 1 commit 2024-07-10 13:40:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d7f8b11da7
fix: refs #7354 requested changes
jon added 1 commit 2024-07-11 05:14:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
74bc4eb7db
refactor: refs #7354 reverse deliveryPanel changes
jon requested review from jgallego 2024-07-11 06:45:41 +00:00
jgallego approved these changes 2024-07-11 12:46:19 +00:00
Dismissed
jon added 1 commit 2024-07-15 08:44:36 +00:00
jon dismissed jgallego’s review 2024-07-15 08:44:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon added 1 commit 2024-07-15 08:45:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0692b8a9fd
Merge branch 'dev' into 7354_ZoneMigration_End
jon requested review from alexm 2024-07-15 08:50:31 +00:00
jon added 1 commit 2024-07-17 05:31:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a51491cf65
Merge branch 'dev' into 7354_ZoneMigration_End
jsegarra requested changes 2024-07-17 18:57:27 +00:00
Dismissed
jsegarra left a comment
Member

Nos sentamos mirarlo porque:

  1. La searchbar pone "buscar reclamación"
  2. Si pones others, no encuentra
    Si pones 247 no busca
    Si pones Zone, tampoco
    2b. Los otros filtros
  3. Si eliminas de la chip de filter no elimina el filtro, o no actualizar la URl o no limpia los filtros de la tabla y aparece vacío
Nos sentamos mirarlo porque: 1. La searchbar pone "buscar reclamación" 2. Si pones others, no encuentra Si pones 247 no busca Si pones Zone, tampoco 2b. Los otros filtros ✅ 3. Si eliminas de la chip de filter no elimina el filtro, o no actualizar la URl o no limpia los filtros de la tabla y aparece vacío
jsegarra added 1 commit 2024-07-17 18:57:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
beb3eb96e6
Merge branch 'dev' into 7354_ZoneMigration_End
jon added 4 commits 2024-07-19 10:11:11 +00:00
alexm added 1 commit 2024-08-07 09:55:02 +00:00
alexm added 2 commits 2024-08-08 06:57:44 +00:00
alexm added 1 commit 2024-08-08 10:53:04 +00:00
alexm added 1 commit 2024-08-09 06:45:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3ee7692bbc
fix(zone): zoneLocation and the others searchbar
alexm added 1 commit 2024-08-09 06:48:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a4d0483f89
typo
jon added 3 commits 2024-08-12 08:33:48 +00:00
jon added 1 commit 2024-08-12 08:36:08 +00:00
jon added 1 commit 2024-08-12 10:58:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b955ded123
fix: refs #7354 fix list searchbar and filters
jon added 1 commit 2024-08-12 12:28:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
aefcfdba51
fix: refs #7354 fix zoneSearchbar
jon added 1 commit 2024-08-13 12:39:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0e9739f2a5
refactor: refs #7354 refactor zones section and fixed e2e tests
jon requested review from jsegarra 2024-08-14 04:44:50 +00:00
jsegarra requested changes 2024-08-14 08:20:02 +00:00
Dismissed
@ -41,3 +28,3 @@
remove: async () => {
try {
await axios.post(`Zones/${zoneId}/setDeleted`);
await axios.post(`Zones/${zoneId}/deleteZone`);
Member

Revisar la traducción para esta acción

Revisar la traducción para esta acción
jon marked this conversation as resolved
@ -72,3 +47,1 @@
/>
</QScrollArea>
</QDrawer>
<Teleport to="#right-panel" v-if="useStateStore().isHeaderMounted()">
Member

El año aparece como 2001 y en salix como 01, confirmar como debe ser

El año aparece como 2001 y en salix como 01, confirmar como debe ser
Author
Member

Lo he comentado con jgallego y se deja con el año completo

Lo he comentado con jgallego y se deja con el año completo
jon marked this conversation as resolved
@ -18,9 +18,16 @@ list:
create: Crear zona
openSummary: Detalles
searchZone: Buscar zonas
searchLocation: Buscar localizaciones
Member

El texto de la sección aparece como ubicaciones en vez de localizaciones

El texto de la sección aparece como ubicaciones en vez de localizaciones
jon marked this conversation as resolved
@ -0,0 +1,23 @@
describe('ZoneCreate', () => {
Member

No forma parte del test pero si del componente. Inflación permite texto y deberia ser numérico

No forma parte del test pero si del componente. Inflación permite texto y deberia ser numérico
jon marked this conversation as resolved
Member

ZoneDeliveryDays, en el desplegable de Código postal, a la opción le fala el país

ZoneDeliveryDays, en el desplegable de Código postal, a la opción le fala el país
jon added 1 commit 2024-08-14 08:44:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ed4bf3cfa8
refactor: refs #7354 requested changes
jon added 1 commit 2024-08-14 08:45:40 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
926fba27b8
Merge branch 'dev' into 7354_ZoneMigration_End
jon added 2 commits 2024-08-14 13:09:37 +00:00
jon added 1 commit 2024-08-14 13:10:28 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
95cda2bad7
Merge branch 'dev' into 7354_ZoneMigration_End
jon requested review from jsegarra 2024-08-14 13:11:13 +00:00
jsegarra added 2 commits 2024-08-14 13:26:51 +00:00
jon added 1 commit 2024-08-16 09:20:12 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
3c4fc9473d
refactor: refs #7354 changed descriptor menu options
alexm added 1 commit 2024-08-16 09:32:57 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0e8455888b
Merge branch 'dev' into 7354_ZoneMigration_End
alexm added 1 commit 2024-08-16 09:47:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
93a56b036a
Merge branch 'dev' into 7354_ZoneMigration_End
alexm approved these changes 2024-08-16 09:53:43 +00:00
Dismissed
Member

ZoneCreate deja de ser necesario

ZoneCreate deja de ser necesario
jon added 11 commits 2024-08-19 08:45:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0d718448e2
perf: approach
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f0b329c226
examples(restore)
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8798598f41
Merge branch 'dev' into 7017_formModel_validations
gitea/salix-front/pipeline/pr-dev This commit looks good Details
734f8807ff
perf: examples
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fabf9a2024
perf: remove print variables
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
305a06aaee
Merge branch 'dev' into 7017_formModel_validations
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6fd0083870
fix: refs #7354 fix validation in price field
jon dismissed alexm’s review 2024-08-19 08:45:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon added 1 commit 2024-08-19 09:22:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a0aa902fe3
Merge branch 'dev' into 7354_ZoneMigration_End
jon added 1 commit 2024-08-19 09:23:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f31f876189
Merge branch 'dev' into 7354_ZoneMigration_End
jon added 2 commits 2024-08-21 06:13:30 +00:00
jon added 1 commit 2024-09-02 10:49:21 +00:00
jon added 1 commit 2024-09-02 10:50:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1af4a559fc
Merge branch 'dev' into 7354_ZoneMigration_End
Member

@jon Tenemos los e2e ?

@jon Tenemos los e2e ✅?
jon added 2 commits 2024-09-02 11:44:42 +00:00
jon added 1 commit 2024-09-02 12:22:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8ffbe400d5
refactor: refs #7354 modified VnInputTime
Author
Member

image

Ha pasado los e2e creados para la sección

![image](/attachments/db7e53df-ca6f-4361-b79e-2d05a5897a50) Ha pasado los e2e creados para la sección
jsegarra approved these changes 2024-09-02 12:40:21 +00:00
jon added 1 commit 2024-09-03 04:36:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a2eb298733
Merge branch 'dev' into 7354_ZoneMigration_End
jon merged commit e2674e0cd8 into dev 2024-09-03 04:48:18 +00:00
jon deleted branch 7354_ZoneMigration_End 2024-09-03 04:48:21 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#539
No description provided.