verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

feat(VnTable): improve css columns #548

Merged
alexm merged 4 commits from 6825-improve-css into dev 2024-07-12 09:06:43 +00:00
Conversation 0 Commits 4 Files Changed 4 +40 -11
alexm commented 2024-07-12 06:25:44 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-07-12 06:25:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ada666a26c feat(VnTable): improve css columns
alexm added 1 commit 2024-07-12 06:33:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b4853af69d fix(VnTable): max-width vn-select
alexm added 1 commit 2024-07-12 06:33:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e1049f660e fix(VnTable): max-width vn-select
alexm reviewed 2024-07-12 06:34:44 +00:00
src/css/app.scss
@ -230,2 +230,4 @@
background: transparent;
}
.q-table {
alexm commented 2024-07-12 06:34:44 +00:00
Author
Member
Copy Link

Se parece un poco a como estaba en salix
front/core/components/smart-table/table.scss

Se parece un poco a como estaba en salix front/core/components/smart-table/table.scss
alexm reviewed 2024-07-12 06:35:16 +00:00
src/components/VnTable/VnOrder.vue
@ -72,2 +72,3 @@
class="no-box-shadow q-mr-lg"
class="no-box-shadow"
:clickable="true"
style="min-width: 40px"
alexm commented 2024-07-12 06:35:16 +00:00
Author
Member
Copy Link

Así evitamos que haga saltos el chip

Así evitamos que haga saltos el chip
jsegarra commented 2024-07-12 06:48:01 +00:00
Member
Copy Link

Okey, pero si a futuro añadimos otro estilo habrá que moverlo a

Okey, pero si a futuro añadimos otro estilo habrá que moverlo a <style>.q-chip{}</style>
alexm requested review from jsegarra 2024-07-12 06:35:30 +00:00
alexm changed title from WIP: feat(VnTable): improve css columns to feat(VnTable): improve css columns 2024-07-12 06:35:32 +00:00
jsegarra approved these changes 2024-07-12 06:48:10 +00:00
Dismissed
jsegarra reviewed 2024-07-12 06:49:14 +00:00
src/components/VnTable/VnOrder.vue
@ -54,3 +54,3 @@
class="row items-center no-wrap cursor-pointer"
>
<span>{{ label }}</span>
<span :title="label">{{ label }}</span>
jsegarra commented 2024-07-12 06:49:14 +00:00
Member
Copy Link

está puesto por defecto undefined y no es requerida.

Si efectivamente es undefined no dará problemas, no?

está puesto por defecto undefined y no es requerida. Si efectivamente es undefined no dará problemas, no?
alexm commented 2024-07-12 09:02:28 +00:00
Author
Member
Copy Link

No creo, no saldrá nada entiendo

No creo, no saldrá nada entiendo
alexm added 1 commit 2024-07-12 09:02:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
79928910ca Merge branch 'dev' into 6825-improve-css
alexm dismissed jsegarra’s review 2024-07-12 09:02:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra approved these changes 2024-07-12 09:04:34 +00:00
alexm merged commit 873d8ad2c3 into dev 2024-07-12 09:06:43 +00:00
alexm deleted branch 6825-improve-css 2024-07-12 09:06:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#548
No description provided.
Delete Branch "6825-improve-css"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?