feat: create VnSelectCache and add in VnColumn #550

Merged
alexm merged 5 commits from 6825-vnSelectCache into dev 2024-07-15 05:21:54 +00:00
Member
No description provided.
alexm added 1 commit 2024-07-12 09:19:57 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
a77bf93e0d
feat: create VnSelectCache and add in VnColumn
alexm added 1 commit 2024-07-12 09:20:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
de814f9881
Merge branch 'dev' into 6825-vnSelectCache
alexm reviewed 2024-07-12 09:22:52 +00:00
@ -85,14 +86,31 @@ const value = computed({
},
});
watch(options, (newValue) => {
Author
Member

Los watch solo los he movido dado que era dificil de leer

Los watch solo los he movido dado que era dificil de leer
alexm reviewed 2024-07-12 09:23:18 +00:00
@ -88,0 +99,4 @@
setOptions(options.value);
if ($props.url && $props.modelValue && !findKeyInOptions())
fetchFilter($props.modelValue);
if ($props.focusOnMount) setTimeout(() => vnSelectRef.value.showPopup(), 300);
Author
Member

Esto tambien lo he movido dado que era dificil de leer pq estaba en un onMounted por abajo tirado

Esto tambien lo he movido dado que era dificil de leer pq estaba en un onMounted por abajo tirado
alexm requested review from jsegarra 2024-07-12 09:23:46 +00:00
Author
Member

⚠️ No estoy seguro de si este es el enfoque correcto o ponerlo dentro de VnSelect

⚠️ No estoy seguro de si este es el enfoque correcto o ponerlo dentro de VnSelect
jsegarra requested changes 2024-07-12 10:38:00 +00:00
Dismissed
@ -0,0 +26,4 @@
</script>
<template>
<VnSelect v-bind="$attrs" :options="$attrs.options ?? options" :url="url" />
Member

es la misma url de la prop que la que le pasas por v-bind?
Porque si fuese asi, te puedes quitar la prop y usar useAttrs dentro de la linea 22

es la misma url de la prop que la que le pasas por v-bind? Porque si fuese asi, te puedes quitar la prop y usar useAttrs dentro de la linea 22
alexm added 2 commits 2024-07-12 12:13:41 +00:00
alexm requested review from jsegarra 2024-07-12 12:13:50 +00:00
jsegarra approved these changes 2024-07-12 20:59:36 +00:00
alexm added 1 commit 2024-07-15 05:19:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a4afba6000
Merge branch 'dev' into 6825-vnSelectCache
alexm merged commit 9d8ed59c1c into dev 2024-07-15 05:21:54 +00:00
alexm deleted branch 6825-vnSelectCache 2024-07-15 05:21:54 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#550
No description provided.