#6917 - inputDate_inputTime_improviments #552

Merged
alexm merged 8 commits from 6917-inputDate_inputTime_improviments into test 2024-07-16 11:12:55 +00:00
Member
No description provided.
alexm added 2 commits 2024-07-15 10:34:54 +00:00
alexm requested review from jsegarra 2024-07-15 11:00:51 +00:00
alexm added 1 commit 2024-07-15 11:11:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
gitea/salix-front/pipeline/pr-test This commit looks good Details
39bf7e55c0
fix: e2e
jsegarra changed title from 6917-inputDate_inputTime_improviments to #6917 - inputDate_inputTime_improviments 2024-07-15 12:16:08 +00:00
jsegarra requested changes 2024-07-15 12:23:21 +00:00
Dismissed
@ -53,2 +54,4 @@
);
}
}
let ymd = value.split('-').map((e) => parseInt(e));
Member

porque no es const?
ymd?? year-month-day==

Propuesta
const [year, mont, day] = value.split

porque no es const? ymd?? year-month-day== Propuesta const [year, mont, day] = value.split
Author
Member

Era código de Juan.
Pero si en este caso si se puede cambiar

Era código de Juan. Pero si en este caso si se puede cambiar
alexm marked this conversation as resolved
@ -44,2 +47,4 @@
time = time.substring(0, 2) + ':' + time.substring(3, 4);
}
if (!props.timeOnly) {
const hours = time.split(':');
Member

const [hh, mm] = time.split en vez de hacer hours[0] y hours[1]

const [hh, mm] = time.split en vez de hacer hours[0] y hours[1]
alexm marked this conversation as resolved
@ -46,3 +51,2 @@
const date = new Date(model.value);
date.setHours(hours[0], hours[1], 0);
time = date.toISOString();
date.setHours(hours[0] ?? 0, hours[1] ?? 0, 0);
Member

En que casos puede ser undefined?

En que casos puede ser undefined?
alexm marked this conversation as resolved
alexm changed target branch from dev to test 2024-07-16 07:09:00 +00:00
alexm added 1 commit 2024-07-16 08:11:34 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
493081254d
feat: improve to set time
alexm added 2 commits 2024-07-16 08:18:34 +00:00
alexm added 1 commit 2024-07-16 08:42:40 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
f01e6d74f8
test: better command if is date
alexm requested review from jsegarra 2024-07-16 08:52:42 +00:00
jsegarra requested changes 2024-07-16 09:46:28 +00:00
Dismissed
@ -44,0 +46,4 @@
if (time.length == 1 && parseInt(time) > 2) time = time.padStart(2, '0');
time = time.padEnd(5, '0');
if (!time.includes(':'))
time = time.substring(0, 2) + ':' + time.substring(3, 5);
Member

(comentario/sugerncia) Okey, con regExp podria ser asi '1200'.replace(/^(\d{2})(\d{2})/, "$1:$2")

(comentario/sugerncia) Okey, con regExp podria ser asi '1200'.replace(/^(\d{2})(\d{2})/, "$1:$2")
alexm marked this conversation as resolved
@ -64,0 +76,4 @@
if (!val || !input) return;
const [hh, mm] = val.split(':');
if (parseInt(hh) >= 10 || mm != '00') return;
Member

porque 10?

porque 10?
Author
Member

pq menos de 10 ja es 09, 08, 07, etc

pq menos de 10 ja es 09, 08, 07, etc
@ -64,0 +79,4 @@
if (parseInt(hh) >= 10 || mm != '00') return;
await nextTick();
await nextTick();
Member

Porque hay 2?

Porque hay 2?
Author
Member

Con 1 no funcionaba entiendo que vue aún no ha actualizado el valor con 1 solo

Con 1 no funcionaba entiendo que vue aún no ha actualizado el valor con 1 solo
Member

Revisamos porque en WorkerTimeControl está poniendo el foco al final del input

Revisamos porque en WorkerTimeControl está poniendo el foco al final del input
alexm requested review from jsegarra 2024-07-16 09:57:20 +00:00
alexm added 1 commit 2024-07-16 10:13:22 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
4f36a78681
feat: curso in start when is 00:00
jsegarra approved these changes 2024-07-16 10:13:55 +00:00
alexm merged commit 3decadc64f into test 2024-07-16 11:12:55 +00:00
alexm deleted branch 6917-inputDate_inputTime_improviments 2024-07-16 11:12:55 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#552
No description provided.