verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

#6917 - inputDate_inputTime_improviments #552

Merged
alexm merged 8 commits from 6917-inputDate_inputTime_improviments into test 2024-07-16 11:12:55 +00:00
Conversation 1 Commits 8 Files Changed 8 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9cc11f0a28 - Show all commits

4
src/components/common/VnInputTime.vue
View File

@ -49,9 +49,9 @@ const formattedTime = computed({
time = time.substring(0, 2) + ':' + time.substring(3, 5);
alexm marked this conversation as resolved
jsegarra commented 2024-07-16 09:45:33 +00:00
Review
Copy Link

(comentario/sugerncia) Okey, con regExp podria ser asi '1200'.replace(/^(\d{2})(\d{2})/, "$1:$2")

(comentario/sugerncia) Okey, con regExp podria ser asi '1200'.replace(/^(\d{2})(\d{2})/, "$1:$2")
}
alexm marked this conversation as resolved Outdated
jsegarra commented 2024-07-15 12:20:51 +00:00
Outdated
Review
Copy Link

const [hh, mm] = time.split en vez de hacer hours[0] y hours[1]

const [hh, mm] = time.split en vez de hacer hours[0] y hours[1]
if (!props.timeOnly) {
const hours = time.split(':');
const [hh, mm] = time.split(':');
alexm marked this conversation as resolved Outdated
jsegarra commented 2024-07-15 12:21:14 +00:00
Outdated
Review
Copy Link

En que casos puede ser undefined?

En que casos puede ser undefined?
const date = new Date(model.value ? model.value : null);
date.setHours(hours[0] ?? 0, hours[1] ?? 0, 0);
date.setHours(hh, mm, 0);
time = date?.toISOString();
}
}