verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

6825-fix_vnSelectCache_and_autoload #557

Merged
alexm merged 2 commits from 6825-fix_vnSelectCache_and_autoload into test 2024-07-19 06:01:57 +00:00
Conversation 0 Commits 2 Files Changed 6 +56 -27
alexm commented 2024-07-18 11:54:41 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2024-07-18 11:54:41 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
f8026dd3f6 feat: improve VnSelectCache add find by Object
alexm requested review from jsegarra 2024-07-18 11:56:08 +00:00
jsegarra reviewed 2024-07-18 13:22:35 +00:00
src/components/VnTable/VnTable.vue
@ -96,6 +96,7 @@ const DEFAULT_MODE = 'card';
const TABLE_MODE = 'table';
const mode = ref(DEFAULT_MODE);
const selected = ref([]);
const hasParams = ref(false);
jsegarra commented 2024-07-18 13:22:35 +00:00
Member
Copy Link

entiendo que no has puesto $attrs['auto-load'] para evitar traerte useAttrs

entiendo que no has puesto $attrs['auto-load'] para evitar traerte useAttrs
alexm marked this conversation as resolved
jsegarra reviewed 2024-07-18 13:23:06 +00:00
src/components/VnTable/VnFilter.vue
@ -51,0 +52,4 @@
component: markRaw(VnSelect),
event: updateEvent,
attrs: {
class: 'q-px-sm q-pb-xs q-pt-none fit',
jsegarra commented 2024-07-18 13:23:06 +00:00
Member
Copy Link

Molaria dejar hueco a customizacion, poniendo $props.componentClass antes

Molaria dejar hueco a customizacion, poniendo $props.componentClass antes
alexm marked this conversation as resolved
jsegarra requested changes 2024-07-18 13:25:31 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Solo queda comprobar el comentario de VnFilter

Solo queda comprobar el comentario de VnFilter
src/components/VnTable/VnFilter.vue
@ -107,3 +111,1 @@
},
forceAttrs,
},
select: selectComponent,
jsegarra commented 2024-07-18 13:25:16 +00:00
Member
Copy Link

en la rama dev, en VnColumn, tenemos select: VnSelectCache y rawSelect: VnSelect, ya me dices si es correcto

en la rama dev, en VnColumn, tenemos select: VnSelectCache y rawSelect: VnSelect, ya me dices si es correcto
alexm commented 2024-07-19 05:38:33 +00:00
Author
Member
Copy Link

En los filtros no tienes un valor cargado por defecto, entonces VnSelectCache no hace falta

En los filtros no tienes un valor cargado por defecto, entonces VnSelectCache no hace falta
👍 1
alexm requested review from jsegarra 2024-07-19 05:39:05 +00:00
jsegarra approved these changes 2024-07-19 05:41:59 +00:00
alexm merged commit bcf4f34862 into test 2024-07-19 06:01:57 +00:00
alexm deleted branch 6825-fix_vnSelectCache_and_autoload 2024-07-19 06:01:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#557
No description provided.
Delete Branch "6825-fix_vnSelectCache_and_autoload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?