#7129 - fixFilters #559

Merged
pablone merged 6 commits from 7129-fixFilters into test 2024-07-22 16:00:14 +00:00
Member
No description provided.
pablone added 2 commits 2024-07-22 07:21:04 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
6f959ff99c
fix: refs #7129 fix filters
pablone added 1 commit 2024-07-22 11:19:44 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
5f0c4fea3c
feat: refs #7129 add e2e
pablone requested review from jsegarra 2024-07-22 11:19:54 +00:00
jsegarra requested changes 2024-07-22 12:19:39 +00:00
Dismissed
@ -178,3 +178,3 @@
if (col.cardVisible) splittedColumns.value.cardVisible.push(col);
if ($props.isEditable && col.disable == null) col.disable = false;
if ($props.useModel) col.columnFilter = { ...col.columnFilter, inWhere: true };
if ($props.useModel && col.columnFilter != false)
Member

usar comparación estricta !==

usar comparación estricta !==
pablone marked this conversation as resolved
@ -274,2 +275,4 @@
/>
<VnTableOrder
v-if="
!(col?.columnFilter === false) &&
Member

porque no poner el ! dentro del parentesis?

porque no poner el ! dentro del parentesis?
pablone marked this conversation as resolved
@ -157,3 +166,4 @@
<CustomerDescriptorProxy :id="row.clientFk" />
</span>
</template>
<template #column-shipped="{ row }">
Member

porque no usas format dentro de la definición de la columna?

porque no usas format dentro de la definición de la columna?
pablone marked this conversation as resolved
@ -160,0 +169,4 @@
<template #column-shipped="{ row }">
{{ toDateHourMin(row.shipped) }}
</template>
<template #column-warehouseFk="{ row }">
Member

porque no usas format dentro de la definición de la columna?

porque no usas format dentro de la definición de la columna?
pablone marked this conversation as resolved
@ -160,0 +172,4 @@
<template #column-warehouseFk="{ row }">
{{ row.warehouseName }}
</template>
<template #column-countryFk="{ row }">
Member

porque no usas format dentro de la definición de la columna?

porque no usas format dentro de la definición de la columna?
pablone marked this conversation as resolved
jsegarra changed title from 7129-fixFilters to #7129 - fixFilters 2024-07-22 14:07:31 +00:00
pablone added 1 commit 2024-07-22 15:37:38 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
f2b56c92c6
Merge branch 'test' into 7129-fixFilters
pablone added 2 commits 2024-07-22 15:51:03 +00:00
pablone requested review from jsegarra 2024-07-22 15:51:33 +00:00
jsegarra approved these changes 2024-07-22 15:57:10 +00:00
pablone merged commit a421c96e85 into test 2024-07-22 16:00:14 +00:00
pablone deleted branch 7129-fixFilters 2024-07-22 16:00:15 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#559
No description provided.