verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

refactor: refs #7679 better way to update model #581

Merged
alexm merged 2 commits from 7679-vnLocation_improve into master 2024-08-01 08:06:20 +00:00
Conversation 0 Commits 2 Files Changed 6 +56 -47
alexm commented 2024-07-31 12:57:47 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-07-31 12:57:47 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
5233c1455a refactor: refs #7679 better way to update model
alexm reviewed 2024-07-31 12:58:10 +00:00
src/components/common/VnSelect.vue
@ -93,3 +91,1 @@
value,
value && myOptions.value.find((o) => o[optionValue.value] == value)
);
emit('update:modelValue', value);
alexm commented 2024-07-31 12:58:10 +00:00
Author
Member
Copy Link

Esto lo puse yo para el VnLocation aposta, ya no hace falta

Esto lo puse yo para el VnLocation aposta, ya no hace falta
jorgep commented 2024-08-01 06:43:04 +00:00
Member
Copy Link

Por eso en VnLocation has puesto emit-value= false?

Por eso en VnLocation has puesto emit-value= false?
alexm requested review from jorgep 2024-07-31 12:58:37 +00:00
alexm added the
CR / Tests passed
 label 2024-07-31 12:58:42 +00:00
jorgep reviewed 2024-08-01 06:40:34 +00:00
jorgep reviewed 2024-08-01 06:42:42 +00:00
src/components/common/VnSelect.vue Outdated
@ -211,3 +204,2 @@
@filter="filterHandler"
hide-selected
fill-input
:emit-value="$attrs['emit-value'] ?? true"
jorgep commented 2024-08-01 06:42:42 +00:00
Member
Copy Link

Podrías hacer una pequeña fn para no tener que escribir cada vez $attrs[x] ?? true.

Podrías hacer una pequeña fn para no tener que escribir cada vez $attrs[x] ?? true.
alexm added 1 commit 2024-08-01 07:47:43 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
d9fb0d9186 nullishToTrue fn
jorgep approved these changes 2024-08-01 08:05:24 +00:00
alexm merged commit 97d4a755e9 into master 2024-08-01 08:06:20 +00:00
alexm deleted branch 7679-vnLocation_improve 2024-08-01 08:06:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jorgep
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#581
No description provided.
Delete Branch "7679-vnLocation_improve"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?