verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 86 Releases Wiki Activity

#6900 add Serial #610

Merged
jorgep merged 9 commits from 6900-addSerial into test 2024-08-14 14:20:41 +00:00
Conversation 2 Commits 9 Files Changed 6 +143 -7
jorgep commented 2024-08-12 11:08:21 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-08-12 11:47:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c4de1beabf feat: refs #6900 add InvoiceInSerial
jorgep changed title from WIP: #6900 add Serial to #6900 add Serial 2024-08-12 12:00:55 +00:00
jorgep added 1 commit 2024-08-12 12:22:53 +00:00
jorgep added the
CR / Tests passed
 label 2024-08-12 12:30:06 +00:00
jorgep requested review from alexm 2024-08-12 12:30:10 +00:00
jorgep commented 2024-08-12 12:30:43 +00:00
Author
Member
Copy Link

@alexm se me había olvidado añadir esta sección

@alexm se me había olvidado añadir esta sección
jorgep reviewed 2024-08-12 12:31:54 +00:00
src/pages/InvoiceIn/Serial/InvoiceInSerial.vue Outdated
@ -0,0 +38,4 @@
});
arrayData.store.userParams.daysAgo = data.daysAgo;
await table.value.reload();
jorgep commented 2024-08-12 12:31:54 +00:00
Author
Member
Copy Link

He probado a pasarlo por user-params, pero como es una prop no es reactiva, habría que modificar el comportamiento de vnpaginate.

He probado a pasarlo por user-params, pero como es una prop no es reactiva, habría que modificar el comportamiento de vnpaginate.
alexm commented 2024-08-12 12:44:30 +00:00
Member
Copy Link

watch(
() => [props.url, props.filter],
([url, filter]) => mounted.value && fetch({ url, filter })
);

https://gitkraken.dev/link/dnNjb2RlOi8vZWFtb2Rpby5naXRsZW5zL2xpbmsvci83MzM3NWYxZTM3MTc5NDNiZDU4YmYyNGUyMmI0ZjczYmUwOWI3NWUyL2Yvc3JjL2NvbXBvbmVudHMvdWkvVm5QYWdpbmF0ZS52dWU%2FdXJsPWh0dHBzJTNBJTJGJTJGZ2l0ZWEudmVyZG5hdHVyYS5lcyUyRnZlcmRuYXR1cmElMkZzYWxpeC1mcm9udC5naXQmbGluZXM9MTE3?origin=gitlens

añadir ahi userParams?

watch( () => [props.url, props.filter], ([url, filter]) => mounted.value && fetch({ url, filter }) ); https://gitkraken.dev/link/dnNjb2RlOi8vZWFtb2Rpby5naXRsZW5zL2xpbmsvci83MzM3NWYxZTM3MTc5NDNiZDU4YmYyNGUyMmI0ZjczYmUwOWI3NWUyL2Yvc3JjL2NvbXBvbmVudHMvdWkvVm5QYWdpbmF0ZS52dWU%2FdXJsPWh0dHBzJTNBJTJGJTJGZ2l0ZWEudmVyZG5hdHVyYS5lcyUyRnZlcmRuYXR1cmElMkZzYWxpeC1mcm9udC5naXQmbGluZXM9MTE3?origin=gitlens añadir ahi userParams?
jorgep commented 2024-08-12 13:20:29 +00:00
Author
Member
Copy Link

lo he probado pero creo que al recargar la página no me acababa de funcionar bien. Le doy otro intento a ver.

lo he probado pero creo que al recargar la página no me acababa de funcionar bien. Le doy otro intento a ver.
jorgep commented 2024-08-12 13:29:07 +00:00
Author
Member
Copy Link

El enlace no puedo abrirlo

El enlace no puedo abrirlo
jorgep commented 2024-08-12 13:33:48 +00:00
Author
Member
Copy Link

nada.

nada.
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-08-12 13:34:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
gitea/salix-front/pipeline/pr-test This commit looks good Details
de24a3efdb feat: refs #6900 add locale
jorgep commented 2024-08-13 08:45:42 +00:00
Author
Member
Copy Link

@alexm Pasar a test

@alexm Pasar a test
alexm changed target branch from dev to test 2024-08-13 08:49:02 +00:00
jorgep added 1 commit 2024-08-14 10:13:42 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
e07d573788 Merge branch 'test' into 6900-addSerial
jorgep added 2 commits 2024-08-14 12:28:00 +00:00
jorgep added 1 commit 2024-08-14 12:31:00 +00:00
jorgep reviewed 2024-08-14 12:32:16 +00:00
src/pages/InvoiceIn/Serial/InvoiceInSerial.vue
@ -0,0 +35,4 @@
onBeforeMount(async () => {
const tableParam = useRoute().query.table;
if (tableParam) daysAgo.value = JSON.parse(tableParam).daysAgo;
jorgep commented 2024-08-14 12:32:16 +00:00
Author
Member
Copy Link

Si se le pasa un parametro, coge ese valor, en lugar de hacer la llamada.

Si se le pasa un parametro, coge ese valor, en lugar de hacer la llamada.
jorgep marked this conversation as resolved
alexm approved these changes 2024-08-14 12:41:13 +00:00
Dismissed
jorgep added 1 commit 2024-08-14 12:52:51 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
3bba5db1b5 fix: refs #6900 improve logic
jorgep dismissed alexm’s review 2024-08-14 12:52:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2024-08-14 12:53:41 +00:00
src/pages/InvoiceIn/Serial/InvoiceInSerial.vue
@ -0,0 +51,4 @@
</template>
</RightMenu>
<VnTable
v-if="!isNaN(daysAgo)"
jorgep commented 2024-08-14 12:53:41 +00:00
Author
Member
Copy Link

ahora se puede poner 0

ahora se puede poner 0
jorgep added 1 commit 2024-08-14 13:27:41 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
ecfdf0b6b9 fix: refs #6900 improve loading
jorgep requested review from alexm 2024-08-14 13:27:52 +00:00
alexm approved these changes 2024-08-14 13:28:29 +00:00
jorgep merged commit a564f94e30 into test 2024-08-14 14:20:41 +00:00
jorgep deleted branch 6900-addSerial 2024-08-14 14:20:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#610
No description provided.
Delete Branch "6900-addSerial"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?