7848-recoveryPassword #617

alexm · 2024-08-13T10:31:14Z

alexm commented

2024-08-13 10:31:14 +00:00

No description provided.

alexm added 4 commits 2024-08-13 10:31:15 +00:00

a46198e2d0 feat: add recover password and reset password

dc1accff7a test: add recover and reset password e2e

b828fd35b7 test: add two factor e2e

gitea/salix-front/pipeline/pr-dev This commit looks good Details

e88e7fa9db Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix-front into dev

alexm reviewed 2024-08-13 10:31:39 +00:00

test/cypress/integration/outLogin/twoFactor.spec.js

						
				@ -0,0 +1,57 @@

				/// <reference types="cypress" />

alexm commented

2024-08-13 10:31:39 +00:00

Ya que estaba he añadido e2e para el doble factor

alexm reviewed 2024-08-13 10:39:33 +00:00

test/cypress/integration/outLogin/recoverPassword.spec.js

						
				@ -0,0 +22,4 @@

				    });

				    it('should change password to user', () => {

				        // Get token from mail

alexm commented

2024-08-13 10:39:29 +00:00

Lo he intentado hacer asi pero no me ha dejado (sin encodeURIComponent tambien):

        const filter = encodeURIComponent(
            JSON.stringify({
                where: {
                    receiver: username,
                },
                order: ['id DESC'],
            })
        );
        cy.request(
            `http://localhost:3000/api/Mails?filter=${filter}&access_token=DEFAULT_TOKEN`
        )

Lo he intentado hacer asi pero no me ha dejado (sin encodeURIComponent tambien): ``` const filter = encodeURIComponent( JSON.stringify({ where: { receiver: username, }, order: ['id DESC'], }) ); cy.request( `http://localhost:3000/api/Mails?filter=${filter}&access_token=DEFAULT_TOKEN` ) ```

alexm reviewed 2024-08-13 10:40:16 +00:00

src/router/index.js

						
				@ -47,3 +47,3 @@

				    Router.beforeEach(async (to, from, next) => {

				        const { isLoggedIn } = session;

				        const outLayout = ['Login', 'TwoFactor', 'VerifyEmail'];

				        const outLayout = Router.options.routes[0].children.map((r) => r.name);

alexm commented

2024-08-13 10:40:16 +00:00

Por no ponerlas siempre a mano

alexm reviewed 2024-08-13 10:40:49 +00:00

src/components/ui/VnOutForm.vue

						
				@ -0,0 +1,32 @@

				<script setup>

alexm commented

2024-08-13 10:40:49 +00:00

He visto que estaba repitiendo el patron, y lo he hecho componente

jorgep commented

2024-08-13 11:07:21 +00:00

Porque out form? Si lo dices porque son datos que se van a enviar ... Igual mejor algo tipo submitForm no?

alexm commented

2024-08-13 13:06:02 +00:00

Out por OutLayout, fuera de la applicacion

jorgep marked this conversation as resolved

alexm requested review from jorgep 2024-08-13 10:41:04 +00:00

jorgep reviewed 2024-08-13 11:05:20 +00:00

src/components/ui/VnOutForm.vue Outdated

						
				@ -0,0 +13,4 @@

				                {{ title }}

				            </h5>

				        </div>

				        <slot name="default"></slot>

jorgep commented

2024-08-13 11:05:20 +00:00

body? el default slot no necesita un name.

alexm commented

2024-08-13 13:05:30 +00:00

lo he probado sin y no me iba

jon reviewed 2024-08-13 11:58:08 +00:00

test/cypress/integration/outLogin/twoFactor.spec.js

						
				@ -0,0 +47,4 @@

				            tempDiv.innerHTML = response.body[0].body;

				            const codeElement = tempDiv.querySelector('.code');

				            const code = codeElement ? codeElement.textContent.trim() : null;

				            cy.log('response: ', code);