verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

feat: refs #7346 add seriaType option #626

Merged
jgallego merged 7 commits from 7346-invoiceOutMultilple into dev 2024-08-23 09:08:53 +00:00
Conversation 1 Commits 7 Files Changed 9 +60 -31
jgallego commented 2024-08-16 11:05:53 +00:00
Owner
Copy Link

verdnatura/salix#2864

https://gitea.verdnatura.es/verdnatura/salix/pulls/2864
jgallego added 1 commit 2024-08-16 11:05:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
06c0f49128 feat: refs #7346 add seriaType option
jgallego added 2 commits 2024-08-20 08:10:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0eb699bcbe feat: refs #7346 formdata uses serialType
jgallego requested review from jsegarra 2024-08-20 10:09:22 +00:00
jsegarra requested changes 2024-08-20 10:16:51 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

image

![image](/attachments/da3721b0-b633-49f8-a85a-22c76f82f97f)
image.png
8.1 KiB
src/pages/InvoiceOut/InvoiceOutGlobalForm.vue Outdated
@ -31,4 +28,4 @@
const optionsInitialData = computed(() => {
return (
companiesOptions.value.length > 0 &&
jsegarra commented 2024-08-20 10:13:22 +00:00
Member
Copy Link

Para tener una condición con 4 condiciones que siguen el mismo criterio, propondria usar el método "every"

Para tener una condición con 4 condiciones que siguen el mismo criterio, propondria usar el método "every"
👍 1
jsegarra marked this conversation as resolved
src/pages/InvoiceOut/InvoiceOutGlobalForm.vue Outdated
@ -64,0 +61,4 @@
<FetchData
url="invoiceOutSerials"
@on-fetch="
(data) => {
jsegarra commented 2024-08-20 10:13:55 +00:00
Member
Copy Link

Al tener tanta lógica, propondria definir una función en la parte de script.setup

Al tener tanta lógica, propondria definir una función en la parte de script.setup
👍 1
jsegarra requested changes 2024-08-20 10:21:43 +00:00
Dismissed
src/pages/InvoiceOut/InvoiceOutGlobalForm.vue Outdated
@ -95,6 +108,17 @@ onMounted(async () => {
outlined
rounded
/>
<VnSelect
jsegarra commented 2024-08-20 10:21:41 +00:00
Member
Copy Link

Si printas la variable serialTypesOptions, te sale algo asi: [ { "code": "A", "description": "Global nacional", "isTaxed": true, "isCEE": false, "taxAreaFk": "NATIONAL" } ]

Type no aparece por ningún lado

Si printas la variable serialTypesOptions, te sale algo asi: [ { "code": "A", "description": "Global nacional", "isTaxed": true, "isCEE": false, "taxAreaFk": "NATIONAL" } ] Type no aparece por ningún lado
jgallego commented 2024-08-21 11:45:18 +00:00
Author
Owner
Copy Link

creo que eso se debe a que no lo has probado descargando también el back de la 7346

creo que eso se debe a que no lo has probado descargando también el back de la 7346
jsegarra commented 2024-08-21 12:10:05 +00:00
Member
Copy Link

Puede ser.
Lo pruebo con esa rama

Puede ser. Lo pruebo con esa rama
jgallego added 1 commit 2024-08-21 11:46:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3d5807463b feat: refs #7346 refactor
jgallego added 1 commit 2024-08-21 12:13:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b71d24cf3d feat: refs #7346 sonarLint warnings
jgallego requested review from jsegarra 2024-08-21 12:15:18 +00:00
jsegarra reviewed 2024-08-21 18:59:26 +00:00
src/pages/InvoiceOut/InvoiceOutGlobalForm.vue Outdated
@ -29,0 +27,4 @@
const handleInvoiceOutSerialsFetch = (data) => {
const uniqueTypes = new Set();
serialTypesOptions.value = data.filter((item) => {
jsegarra commented 2024-08-21 18:59:26 +00:00
Member
Copy Link

variable === null es lo mismo que hacer !variable

Por otra parte

    serialTypesOptions.value = Array.from(
        new Set(data.map((item) => item.type).filter((type) => type))
    );
};
variable === null es lo mismo que hacer !variable Por otra parte ``` serialTypesOptions.value = Array.from( new Set(data.map((item) => item.type).filter((type) => type)) ); }; ```
jsegarra requested changes 2024-08-21 19:06:57 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Cuando seleccionas un valor, no se muestra en el filtro

Cuando seleccionas un valor, no se muestra en el filtro
jgallego commented 2024-08-22 09:31:35 +00:00
Author
Owner
Copy Link

Cuando seleccionas un valor, no se muestra en el filtro

Esto ya pasa en dev, lo comenté con Jorge porque no es un fallo de este pr

> Cuando seleccionas un valor, no se muestra en el filtro Esto ya pasa en dev, lo comenté con Jorge porque no es un fallo de este pr
jgallego requested review from jsegarra 2024-08-22 09:31:39 +00:00
jsegarra approved these changes 2024-08-22 09:47:48 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Con este código en la linea 62, formData.value = { ...formInitialData.value }; se corrige el problema

Con este código en la linea 62, formData.value = { ...formInitialData.value }; se corrige el problema
jgallego added 1 commit 2024-08-23 08:20:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
defb11a6d7 Merge branch 'dev' into 7346-invoiceOutMultilple
jgallego dismissed jsegarra’s review 2024-08-23 08:20:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jgallego added 1 commit 2024-08-23 08:32:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d0ccce2656 feat: refs #7346 elimino ===
jgallego requested review from jsegarra 2024-08-23 08:33:22 +00:00
jsegarra approved these changes 2024-08-23 09:03:12 +00:00
jgallego merged commit 6dc7d8f9a2 into dev 2024-08-23 09:08:53 +00:00
jgallego deleted branch 7346-invoiceOutMultilple 2024-08-23 09:08:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#626
No description provided.
Delete Branch "7346-invoiceOutMultilple"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?