verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 93 Releases Wiki Activity

7355-accountMigrationFixes2 #658

Merged
carlossa merged 12 commits from 7355-accountMigrationFixes2 into dev 2024-08-30 10:58:11 +00:00
Conversation 0 Commits 12 Files Changed 16 +200 -66
carlossa commented 2024-08-29 13:06:29 +00:00
Member
Copy Link
No description provided.
carlossa added 3 commits 2024-08-29 13:06:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
36a7618ef5 refs #7355 previews
carlossa requested review from jsegarra 2024-08-29 13:24:35 +00:00
jsegarra reviewed 2024-08-29 18:15:09 +00:00
src/components/VnTable/VnTable.vue Outdated
@ -388,3 +390,3 @@
class="bg-vn-section-color"
dense
:options="tableModes"
:options="tableModes.filter((mode) => !mode.visible)"
jsegarra commented 2024-08-29 18:15:09 +00:00
Member
Copy Link

Quizás hemos cometido un error.
Te propongo quitar las lineas 119 y 126, y en la 392, reemplazar visible por disable.
El motivo de mi petición es que si te fijas disable y visible son líneas iguales

Quizás hemos cometido un error. Te propongo quitar las lineas 119 y 126, y en la 392, reemplazar visible por disable. El motivo de mi petición es que si te fijas disable y visible son líneas iguales
carlossa marked this conversation as resolved
jsegarra reviewed 2024-08-29 18:15:51 +00:00
src/pages/Account/AccountList.vue
@ -65,6 +73,7 @@ const columns = computed(() => [
title: t('View Summary'),
icon: 'preview',
action: (row) => viewSummary(row.id, AccountSummary),
isPrimary: true,
jsegarra commented 2024-08-29 18:15:51 +00:00
Member
Copy Link

Guay, pero casi que a futuro, modificaremos de raiz el estilo, modificando VnTable

Guay, pero casi que a futuro, modificaremos de raiz el estilo, modificando VnTable
carlossa marked this conversation as resolved
jsegarra requested changes 2024-08-29 18:19:07 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Se que es una faena, pero te propongo, eliminar las repeticiones en todos los archivos en la sección i18n en favor de una etiqueta global y/o bien usar component.smartCard.viewSummary, esta etiqueta no está creada, los otros dos niveles si que existen

Se que es una faena, pero te propongo, eliminar las repeticiones en todos los archivos en la sección i18n en favor de una etiqueta global y/o bien usar component.smartCard.viewSummary, esta etiqueta no está creada, los otros dos niveles si que existen
carlossa added 1 commit 2024-08-30 07:52:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
278f691ed2 refs #7355 fix views summarys, entryList, travelList refact
carlossa added 1 commit 2024-08-30 07:53:51 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
d555b89598 refs #7355 remove bad code
carlossa added 1 commit 2024-08-30 07:54:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
76cb8c6b28 refs #7355 remove bug
carlossa added 1 commit 2024-08-30 07:55:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fa36f8d8af Merge branch 'dev' into 7355-accountMigrationFixes2
carlossa requested review from jsegarra 2024-08-30 07:55:19 +00:00
carlossa added 2 commits 2024-08-30 09:18:58 +00:00
carlossa added 1 commit 2024-08-30 09:25:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f33733c7f2 refs #7355 fix total
carlossa added 1 commit 2024-08-30 09:50:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
859eb918cd refs #6897 fix entry
jsegarra requested changes 2024-08-30 10:04:28 +00:00
Dismissed
src/pages/Travel/TravelList.vue Outdated
@ -146,3 +140,3 @@
label: t('travel.travelList.tableVisibleColumns.totalEntries'),
field: 'totalEntries',
component: 'input',
attrs: {},
jsegarra commented 2024-08-30 10:02:21 +00:00
Member
Copy Link

objeto vacio!

objeto vacio!
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-08-30 10:32:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
874cbfea9b refs #7366 fix travel hours
jsegarra approved these changes 2024-08-30 10:40:22 +00:00
carlossa merged commit 5b0df1124e into dev 2024-08-30 10:58:11 +00:00
carlossa deleted branch 7355-accountMigrationFixes2 2024-08-30 10:58:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#658
No description provided.
Delete Branch "7355-accountMigrationFixes2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?