refs #6943 remake, refactor, clean code Samples #677

Merged
carlossa merged 5 commits from 6943-fixCustomerSamples into master 2024-09-05 09:57:21 +00:00
Member
No description provided.
carlossa added 1 commit 2024-09-04 12:38:18 +00:00
carlossa requested review from jsegarra 2024-09-04 12:40:06 +00:00
jsegarra requested changes 2024-09-04 12:41:26 +00:00
Dismissed
@ -175,0 +175,4 @@
setParams(params);
const samplesData = await getSamples();
const path = `${samplesData.model}/${route.params.id}/${samplesData.code}-email`;
await sendEmail(path, params);
Member

try/catch?

try/catch?
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-09-04 12:41:42 +00:00
jsegarra requested changes 2024-09-04 12:42:03 +00:00
Dismissed
@ -174,1 +162,4 @@
let { data } = await axios.get('Samples', {
params: { filter: JSON.stringify(filter) },
});
return data[0];
Member

Si falla la peticion o data es nullo, que pasará?

Si falla la peticion o data es nullo, que pasará?
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-09-04 12:43:57 +00:00
carlossa added 1 commit 2024-09-04 12:46:31 +00:00
carlossa requested review from jsegarra 2024-09-04 12:47:21 +00:00
carlossa requested review from jgallego 2024-09-04 12:47:56 +00:00
jgallego approved these changes 2024-09-04 12:50:46 +00:00
jsegarra approved these changes 2024-09-04 12:52:45 +00:00
carlossa added 1 commit 2024-09-05 08:58:22 +00:00
carlossa merged commit 1662e3b459 into master 2024-09-05 09:57:21 +00:00
carlossa deleted branch 6943-fixCustomerSamples 2024-09-05 09:57:21 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#677
No description provided.