refs #6075 VnLabelValue created #68

Merged
jorgep merged 2 commits from 6075-createVnLabelValue into dev 2023-08-01 09:37:49 +00:00
Member
No description provided.
jorgep added 1 commit 2023-07-31 12:10:41 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
0d67ac4450
refs #6075 VnLabelValue created
jorgep requested review from alexm 2023-07-31 12:10:46 +00:00
alexm requested changes 2023-07-31 12:27:20 +00:00
@ -0,0 +4,4 @@
label: { type: String, default: '' },
value: {
type: [String, Boolean],
required: true,
Member

Value no es required

Value no es required
Author
Member

Que valor por defecto asigno: default: undefined?

Que valor por defecto asigno: default: undefined?
@ -0,0 +8,4 @@
},
info: { type: String, default: '' },
});
const isBooleanValue = computed(() => typeof $props.value === 'boolean');
Member

Entonces aquí seria $props.value && typeof $props.value === 'boolean'
(Creo que asi si es true $props.value, devolvera typeof $props.value === 'boolean')

Entonces aquí seria $props.value && typeof $props.value === 'boolean' (Creo que asi si es true $props.value, devolvera typeof $props.value === 'boolean')
Author
Member

Según el ticket, hay que comprobar si value es un valor booleano true o false, no si existe. Si existe no se muestra el check, se muestra el slot

Según el ticket, hay que comprobar si value es un valor booleano true o false, no si existe. Si existe no se muestra el check, se muestra el slot
@ -0,0 +14,4 @@
<template>
<div class="vn-label-value">
<div class="label">
<slot name="label"></slot>
Member

Segun ChatGPT: <div v-if="!$slots.label ">{{ $props.label }}</div>

Segun ChatGPT: `<div v-if="!$slots.label ">{{ $props.label }}</div>`
@ -0,0 +21,4 @@
<QIcon :name="value ? `check` : `close`" :class="value ? `positive` : `negative`" />
</span>
<span v-else>
<slot name="value"></slot>
Member

Segun ChatGPT:

{{ $props.value}}

Segun ChatGPT: <div v-if="!$slots.value">{{ $props.value}}</div>
@ -0,0 +33,4 @@
</div>
</div>
</template>
<style lang="scss" scoped>
Member

Quitar css se puede hacer sin

Quitar css se puede hacer sin
jorgep added 1 commit 2023-07-31 13:31:45 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
2549b20158
refs #6075 refactor changes
jorgep requested review from alexm 2023-07-31 13:33:22 +00:00
alexm approved these changes 2023-08-01 05:17:58 +00:00
alexm requested review from juan 2023-08-01 05:18:04 +00:00
juan approved these changes 2023-08-01 08:47:27 +00:00
jorgep merged commit b55e216d6a into dev 2023-08-01 09:37:49 +00:00
jorgep deleted branch 6075-createVnLabelValue 2023-08-01 09:37:49 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#68
No description provided.