verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

#8018 - Show fields instead null/undefined #737

Merged
jsegarra merged 9 commits from 8018_location_label into dev 2024-09-30 10:55:05 +00:00
Conversation 2 Commits 9 Files Changed 1 +33 -4
jsegarra commented 2024-09-20 09:56:08 +00:00
Member
Copy Link

image

![image](/attachments/fe0685bf-216d-4cd0-82e7-f8fc79f270d2)
image.png
133 KiB
jsegarra added 1 commit 2024-09-20 10:01:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
271e33a999 feat: formatLocation when field is null
jsegarra changed title from WIP: Show fields to Show fields 2024-09-20 11:08:21 +00:00
jsegarra changed title from Show fields to #8018 - Show fields instead null/undefined 2024-09-20 11:08:45 +00:00
jsegarra requested review from alexm 2024-09-20 11:08:47 +00:00
jsegarra commented 2024-09-23 09:39:20 +00:00
Author
Member
Copy Link

image

![image](/attachments/560ae300-18ed-44d0-97f0-6edd6aa1d92b)
image.png
23 KiB
jsegarra added 2 commits 2024-09-23 09:48:08 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
013a76cbce test: VnLocation
jsegarra added 1 commit 2024-09-23 09:48:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7713e33c67 Merge branch 'dev' into 8018_location_label
jsegarra added 1 commit 2024-09-26 12:48:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
428c6966f2 Merge branch 'dev' into 8018_location_label
jsegarra requested review from jgallego 2024-09-27 11:49:32 +00:00
jgallego requested changes 2024-09-27 11:52:11 +00:00
Dismissed
src/components/common/VnLocation.vue
@ -15,0 +35,4 @@
obj.city
? `${obj.city}${obj.province?.name ? `(${obj.province.name})` : ''}`
: null,
(obj) => obj.country?.name,
jgallego commented 2024-09-27 11:52:09 +00:00
Owner
Copy Link

mostrar el pais si esta informado

mostrar el pais si esta informado
jsegarra commented 2024-09-27 17:59:58 +00:00
Author
Member
Copy Link

@jgallego El pais se está informado correctamente si se ha indicado. Adjunto una captura de como está definido el proveedor con ciudad y countryFk
Adjunto también lo que ocurre cuando no hay pais informado

### Conclusión: en la fixture no estaba puesto el pais

@jgallego El pais se está informado correctamente ***si** se ha indicado*. Adjunto una captura de como está definido el proveedor con ciudad y countryFk Adjunto también lo que ocurre cuando no hay pais informado **### Conclusión: en la fixture no estaba puesto el pais**
jsegarra commented 2024-09-27 18:01:07 +00:00
Author
Member
Copy Link

Con countryFK: image
Sin countryFK: image

Con countryFK: ![image](/attachments/65d42596-9ce6-4ccf-9e20-2ffbb126293c) Sin countryFK: ![image](/attachments/a2f02255-737f-4bf7-b399-c5eefbfcece9)
image.png
159 KiB
image.png
121 KiB
jsegarra requested review from jgallego 2024-09-27 18:01:13 +00:00
jsegarra added 1 commit 2024-09-27 18:01:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cffd97a521 Merge branch 'dev' into 8018_location_label
jgallego approved these changes 2024-09-28 08:19:18 +00:00
jsegarra closed this pull request 2024-09-28 09:46:58 +00:00
jsegarra reopened this pull request 2024-09-28 09:47:04 +00:00
jsegarra added 2 commits 2024-09-30 07:43:11 +00:00
alexm approved these changes 2024-09-30 08:23:19 +00:00
jsegarra added 1 commit 2024-09-30 10:53:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cf509d608a Merge branch 'dev' into 8018_location_label
jsegarra merged commit d4dc12ebe3 into dev 2024-09-30 10:55:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#737
No description provided.
Delete Branch "8018_location_label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?