7129-fixMigrationIssues #754

Merged
pablone merged 10 commits from 7129-fixMigrationIssues into dev 2024-09-26 12:53:45 +00:00
Member
No description provided.
pablone added 4 commits 2024-09-24 10:58:56 +00:00
pablone requested review from jgallego 2024-09-24 10:59:01 +00:00
jgallego requested review from jsegarra 2024-09-24 11:34:49 +00:00
jgallego refused to review 2024-09-24 11:34:51 +00:00
jsegarra requested changes 2024-09-24 12:05:41 +00:00
Dismissed
@ -84,0 +76,4 @@
<div class="list-container">
<div class="list">
<VnTable
ref="tableRef"
Member

Hacemos operaciones sobre la tabla tipo redirect o reload?
Lo digo, por crear la variable que no tendría ninguna utilidad o quitar la propiedad

Hacemos operaciones sobre la tabla tipo redirect o reload? Lo digo, por crear la variable que no tendría ninguna utilidad o quitar la propiedad
pablone marked this conversation as resolved
@ -0,0 +23,4 @@
const { t } = useI18n();
const { viewSummary } = useSummaryDialog();
const quasar = useQuasar();
const session = useSession();
Member

session no se usa

session no se usa
pablone marked this conversation as resolved
@ -0,0 +310,4 @@
:row-click="false"
:create="{
urlCreate: 'Routes',
title: t('Create route'),
Member

no lo traduce. Creo que es newRoute

no lo traduce. Creo que es newRoute
pablone marked this conversation as resolved
@ -0,0 +375,4 @@
right: 0;
}
</style>
<i18n>
Member

Traducciones duplicadas
Propuesta: mover al archivo yml del módulo routes

Traducciones duplicadas Propuesta: mover al archivo yml del módulo routes
pablone marked this conversation as resolved
@ -215,3 +106,1 @@
icon: 'arrow_forward',
isPrimary: true,
action: (row) => navigate(row?.id),
color: 'primary',
Member

no hace falta definirlo

no hace falta definirlo
pablone marked this conversation as resolved
pablone added 2 commits 2024-09-25 09:16:34 +00:00
pablone requested review from jsegarra 2024-09-25 09:17:41 +00:00
jsegarra requested changes 2024-09-25 09:21:46 +00:00
Dismissed
@ -0,0 +225,4 @@
const cloneRoutes = () => {
if (!selectedRows.value.length || !startingDate.value) return;
axios.post('route.Routes/clone', {
Member

Esto es un endpoint válido?

Esto es un endpoint válido?
Author
Member

me he colado con las traducciones

me he colado con las traducciones
pablone marked this conversation as resolved
jsegarra requested changes 2024-09-25 09:42:03 +00:00
Dismissed
jsegarra left a comment
Member

Adjunto capturas de los comentarios
image
image

Adjunto capturas de los comentarios ![image](/attachments/469e6cea-0454-40d5-bd9f-ab20c6131061) ![image](/attachments/a31c42cf-e65c-4f8b-bbc1-2de89bb7ef27)
4.6 KiB
9.7 KiB
pablone added 1 commit 2024-09-25 09:51:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ca568c31ca
fix: refs #7129 clone post
pablone requested review from jsegarra 2024-09-25 10:31:13 +00:00
pablone added 1 commit 2024-09-25 10:33:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cea5edd506
fix: refs #7129 translate
jsegarra approved these changes 2024-09-25 10:45:30 +00:00
Dismissed
pablone added 1 commit 2024-09-26 05:58:04 +00:00
pablone dismissed jsegarra’s review 2024-09-26 05:58:04 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone requested review from jsegarra 2024-09-26 05:58:40 +00:00
pablone added 1 commit 2024-09-26 06:09:23 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6e6b65771a
Merge branch 'dev' into 7129-fixMigrationIssues
jsegarra approved these changes 2024-09-26 12:15:13 +00:00
pablone merged commit 6e6b88d340 into dev 2024-09-26 12:53:45 +00:00
pablone deleted branch 7129-fixMigrationIssues 2024-09-26 12:53:45 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#754
No description provided.