verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

#7793 - sortByWeight #763

Closed
jsegarra wants to merge 7 commits from 7793_sortByWeight into dev
pull from: 7793_sortByWeight
merge into: verdnatura:dev
Conversation 1 Commits 7 Files Changed 1 +36 -15
jsegarra commented 2024-09-25 13:22:31 +00:00
Member
Copy Link

DEP: verdnatura/salix#3020

DEP: https://gitea.verdnatura.es/verdnatura/salix/pulls/3020
jsegarra added 1 commit 2024-09-25 13:25:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3476b4807f feat: refs #7793 sortByWeight
jsegarra requested review from alexm 2024-09-25 13:29:01 +00:00
jgallego changed title from WIP: #7793 - sortByWeight to #7793 - sortByWeight 2024-09-27 11:44:34 +00:00
alexm requested changes 2024-09-30 08:19:48 +00:00
Dismissed
src/components/common/VnSelect.vue Outdated
@ -86,6 +86,10 @@ const $props = defineProps({
type: Boolean,
default: false,
},
sortByWeight: {
alexm commented 2024-09-30 08:19:46 +00:00
Member
Copy Link

Esta propiedad no se esta usando?

Esta propiedad no se esta usando?
😕 1
jsegarra added 4 commits 2024-10-08 23:45:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8f963ab78a perf: refs #7793 imrpove sort data method
jsegarra requested review from alexm 2024-10-08 23:45:48 +00:00
jsegarra added 1 commit 2024-10-10 20:57:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d7b0b8b356 Merge branch 'dev' into 7793_sortByWeight
alexm requested changes 2024-10-16 07:35:50 +00:00
Dismissed
src/components/common/VnSelect.vue Outdated
@ -139,6 +139,23 @@ function findKeyInOptions() {
}
function setOptions(data) {
data = data.sort((a, b) => {
alexm commented 2024-10-16 07:35:29 +00:00
Member
Copy Link

Para esto no seria mejor ya pedir los datos ordenadors por optionLabel?

Para esto no seria mejor ya pedir los datos ordenadors por optionLabel?
jsegarra commented 2024-10-16 12:14:16 +00:00
Author
Member
Copy Link

De esta manera nos aseguramos que se ordenan por optionLabel, porque que pasa con esos VnSelect que no tienen definidos los sortBy? Tendríamos que ir uno a uno indicándoles la ordenación.
De esta manera nos aseguramos que, definido o no, se ordenan por label.
También nos aseguramos de aplicar el criterio de ordenar según la posición del texto buscado dentro del valor

De esta manera nos aseguramos que se ordenan por optionLabel, porque que pasa con esos VnSelect que no tienen definidos los sortBy? Tendríamos que ir uno a uno indicándoles la ordenación. De esta manera nos aseguramos que, definido o no, se ordenan por label. También nos aseguramos de aplicar el criterio de ordenar según la posición del texto buscado dentro del valor
src/components/common/VnSelect.vue Outdated
@ -191,3 +213,4 @@
return dataRef.value.fetch(fetchOptions);
}
function getOrderCaseString(prop, value) {
alexm commented 2024-10-16 07:35:48 +00:00
Member
Copy Link

Esto funciona asi tal cual?

Esto funciona asi tal cual?
jsegarra commented 2024-10-16 12:11:55 +00:00
Author
Member
Copy Link

No, esto se elimina en favor del método sort
Grcias

No, esto se elimina en favor del método sort Grcias
jsegarra added 1 commit 2024-10-16 13:52:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fb340d1f27 perf: refs #7793 sort when filter without fetch
jsegarra requested review from alexm 2024-10-16 22:25:51 +00:00
alexm requested changes 2024-11-24 06:26:23 +00:00
alexm left a comment
Member
Copy Link

Diria que con esto se soluciona #918

Diria que con esto se soluciona https://gitea.verdnatura.es/verdnatura/salix-front/pulls/918
jsegarra commented 2024-11-24 08:10:21 +00:00
Author
Member
Copy Link

Si si, lo tengo en cuenta para probarlo después de la subida

Si si, lo tengo en cuenta para probarlo después de la subida
jsegarra closed this pull request 2024-11-25 20:55:53 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#763
No description provided.
Delete Branch "7793_sortByWeight"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?