verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 93 Releases Wiki Activity

#7679 Filter data from others filters #769

Merged
jsegarra merged 4 commits from 7679_improve_filters into dev 2024-09-30 07:19:31 +00:00
Conversation 0 Commits 4 Files Changed 3 +124 -19
jsegarra commented 2024-09-26 21:37:18 +00:00
Member
Copy Link
No description provided.
jsegarra added 2 commits 2024-09-26 21:39:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6b2e0df9c2 test: refs #7679 #7679 improve test
jsegarra changed title from WIP: #7679 Filter data from others filters to #7679 Filter data from others filters 2024-09-26 21:40:10 +00:00
jsegarra requested review from jgallego 2024-09-26 21:40:16 +00:00
jgallego requested changes 2024-09-27 06:36:29 +00:00
Dismissed
src/components/VnSelectProvince.vue
@ -14,0 +13,4 @@
const $props = defineProps({
countryFk: {
type: Number,
required: false,
jgallego commented 2024-09-27 06:36:09 +00:00
Owner
Copy Link

esta linea es necesaria?

esta linea es necesaria?
jsegarra commented 2024-09-27 08:36:07 +00:00
Author
Member
Copy Link

Esta prop es necesaria para que cuando se modifique el pais se actualicen las provincias

Esta prop es necesaria para que cuando se modifique el pais se actualicen las provincias
jsegarra marked this conversation as resolved
src/components/VnSelectProvince.vue
@ -25,0 +32,4 @@
() => $props.countryFk,
async (newProvinceFk) => {
if (newProvinceFk) {
// Assuming there's a townsFetchDataRef similar to provincesFetchDataRef
jgallego commented 2024-09-27 06:36:22 +00:00
Owner
Copy Link

es necesario el comentario?

es necesario el comentario?
jsegarra commented 2024-09-27 08:08:46 +00:00
Author
Member
Copy Link

No, no es necesario

No, no es necesario
jsegarra marked this conversation as resolved
jsegarra requested review from jgallego 2024-09-27 08:36:12 +00:00
jsegarra added 2 commits 2024-09-27 17:54:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bec50d6eed perf: refs #7679 #7679 comments
jgallego approved these changes 2024-09-28 08:22:36 +00:00
jsegarra merged commit 9d7db2020b into dev 2024-09-30 07:19:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#769
No description provided.
Delete Branch "7679_improve_filters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?