verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

refs 5987 index cards and light mode #79

Merged
alexm merged 10 commits from 5987-redisgnCards into dev 2023-08-17 08:41:58 +00:00
Conversation 0 Commits 10 Files Changed 15 +355 -472
jorgep commented 2023-08-10 11:21:36 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2023-08-10 11:21:38 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
a194ec745b refs 5987 index cards and light mode
jorgep requested review from alexm 2023-08-10 11:21:52 +00:00
alexm requested changes 2023-08-10 13:06:39 +00:00
src/components/ui/CardDescriptor.vue Outdated
@ -125,3 +125,3 @@
</QItemLabel>
<QItem dense>
<QItemLabel class="subtitle text-white" caption>
<QItemLabel class="subtitle" caption>
alexm commented 2023-08-10 13:06:30 +00:00
Member
Copy Link

Poner un poco mas pequeños los titulos del card.
Y descriptor que tenga elipsis
Y remirar CSS card

Poner un poco mas pequeños los titulos del card. Y descriptor que tenga elipsis Y remirar CSS card
alexm marked this conversation as resolved
jorgep added 1 commit 2023-08-10 14:09:59 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
cb52bfe171 refs 5987 fix title descriptor and card body
jorgep requested review from alexm 2023-08-10 14:10:38 +00:00
jorgep added 2 commits 2023-08-11 06:17:46 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
3d4aca52f8 refs 5987 center card descriptor item-list
jorgep added 1 commit 2023-08-11 12:49:49 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
787844a930 refs 5987 fixed cardList margin and breakpoint
alexm requested changes 2023-08-14 05:12:15 +00:00
src/components/ui/CardDescriptor.vue Outdated
@ -196,3 +197,2 @@
width: 90%;
background-color: rgba(87, 86, 86, 0.2);
margin: 20px 10px 0 10px;
background-color: $descriptor-items-box;
alexm commented 2023-08-14 05:06:50 +00:00
Member
Copy Link

Esta variable debería estar o definida aquí o tener un nombre mas genérico. Dado que esta definida de manera global

Esta variable debería estar o definida aquí o tener un nombre mas genérico. Dado que esta definida de manera global
src/components/ui/CardList.vue Outdated
@ -0,0 +106,4 @@
flex-direction: column;
justify-content: center;
}
@media (min-width: 1024px) and (max-width: 1100px) {
alexm commented 2023-08-14 05:12:07 +00:00
Member
Copy Link

Lo de tindre 3 media queries, vuic voreu visualment a vore si cal o podem solucionar-ho per altre cami

Lo de tindre 3 media queries, vuic voreu visualment a vore si cal o podem solucionar-ho per altre cami
src/css/app.scss Outdated
@ -30,3 +30,4 @@
color: #555;
}
.descriptor {
alexm commented 2023-08-14 05:09:39 +00:00
Member
Copy Link

Aço igual deuria estar en el propi component antes que en un fitxer global

Aço igual deuria estar en el propi component antes que en un fitxer global
src/css/app.scss Outdated
@ -33,0 +36,4 @@
}
}
.vn-label-value {
alexm commented 2023-08-14 05:09:26 +00:00
Member
Copy Link

Aço igual deuria estar en el propi component antes que en un fitxer global

Aço igual deuria estar en el propi component antes que en un fitxer global
src/css/app.scss Outdated
@ -33,0 +44,4 @@
color: $light-black;
}
}
.descriptor {
alexm commented 2023-08-14 05:09:30 +00:00
Member
Copy Link

Aço igual deuria estar en el propi component antes que en un fitxer global

Aço igual deuria estar en el propi component antes que en un fitxer global
src/pages/Ticket/Card/TicketDescriptor.vue Outdated
@ -89,3 +89,3 @@
<VnLv v-if="entity.ticketState" :label="t('ticket.card.state')">
<template #value>
<QBadge :color="entity.ticketState.state.classColor ?? 'dark'">
<QBadge :color="entity.ticketState.state.classColor ?? 'orange'">
alexm commented 2023-08-14 05:11:01 +00:00
Member
Copy Link

Este orange deuria ser primary entenc

Este orange deuria ser `primary` entenc
jorgep added 1 commit 2023-08-14 07:00:39 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
670882024a refs 6105 css refactoring
jorgep requested review from alexm 2023-08-14 07:17:30 +00:00
alexm requested changes 2023-08-14 12:15:25 +00:00
src/components/ui/CardDescriptor.vue Outdated
@ -183,3 +193,4 @@
</style>
<style lang="scss" scoped>
$descriptor--light: rgb(87 86 86 / 6%);
alexm commented 2023-08-14 12:15:20 +00:00
Member
Copy Link

Podries gastar el color de una de les variables que has creat:
https://gitea.verdnatura.es/verdnatura/salix-front/pulls/79/files#diff-b1e76443679ed8e3f9150534016e8ec63d3c1f9f

$white: #fff;
$black: #000;
$light-black: #4e4c4c;
$gray: gray;
$light-gray: #57565633;
$lighter-gray: #5756560f;

I possarli lo de light i tal pero de manera global

Podries gastar el color de una de les variables que has creat: https://gitea.verdnatura.es/verdnatura/salix-front/pulls/79/files#diff-b1e76443679ed8e3f9150534016e8ec63d3c1f9f ``` $white: #fff; $black: #000; $light-black: #4e4c4c; $gray: gray; $light-gray: #57565633; $lighter-gray: #5756560f; ``` I possarli lo de light i tal pero de manera global
src/components/ui/CardList.vue Outdated
@ -0,0 +123,4 @@
column-gap: 5vw;
}
}
@media (max-width: 600px) {
alexm commented 2023-08-14 12:10:23 +00:00
Member
Copy Link

Para que toda la web funcione igual creo que seria mas conveniente usar este tipo de media queris asi todos usamos el mismo tipo.
@media (max-width: $breakpoint-xs)
Ejemplo: src/components/ui/VnSearchbar.vue

Para que toda la web funcione igual creo que seria mas conveniente usar este tipo de media queris asi todos usamos el mismo tipo. @media (max-width: $breakpoint-xs) Ejemplo: src/components/ui/VnSearchbar.vue
src/pages/Ticket/Card/TicketDescriptor.vue Outdated
@ -89,3 +89,3 @@
<VnLv v-if="entity.ticketState" :label="t('ticket.card.state')">
<template #value>
<QBadge :color="entity.ticketState.state.classColor ?? 'dark'">
<QBadge :color="entity.ticketState.state.classColor ?? 'primary'">
alexm commented 2023-08-14 12:08:25 +00:00
Member
Copy Link

Por defecto naranja??

Por defecto naranja??
jorgep added 1 commit 2023-08-14 13:19:13 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
96d0ba3e0a refs 5987 fix media queries
jorgep requested review from alexm 2023-08-14 13:29:09 +00:00
alexm approved these changes 2023-08-16 05:14:42 +00:00
Dismissed
alexm requested review from juan 2023-08-16 05:14:49 +00:00
jgallego approved these changes 2023-08-17 05:52:31 +00:00
Dismissed
jgallego removed review request for juan 2023-08-17 05:52:40 +00:00
jorgep added 1 commit 2023-08-17 06:50:58 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
b7e9aee1d5 refs 5987 var-colors
jorgep dismissed alexm’s review 2023-08-17 06:50:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep dismissed jgallego’s review 2023-08-17 06:50:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 1 commit 2023-08-17 08:32:41 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
76071240d1 refs 5987 var-colors fixed
alexm approved these changes 2023-08-17 08:39:37 +00:00
Dismissed
alexm added 1 commit 2023-08-17 08:39:54 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
831dcfbf6d Merge branch 'dev' into 5987-redisgnCards
alexm dismissed alexm’s review 2023-08-17 08:39:55 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2023-08-17 08:41:32 +00:00
alexm merged commit e8775a9585 into dev 2023-08-17 08:41:58 +00:00
alexm deleted branch 5987-redisgnCards 2023-08-17 08:41:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#79
No description provided.
Delete Branch "5987-redisgnCards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?