verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

refs 5987 index cards and light mode #79

Merged
alexm merged 10 commits from 5987-redisgnCards into dev 2023-08-17 08:41:58 +00:00
Conversation 0 Commits 10 Files Changed 15 +9 -7
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 96d0ba3e0a - Show all commits

3
src/components/ui/CardDescriptor.vue
View File

@ -193,14 +193,13 @@ body.body--light {
</style> </style>
<style lang="scss" scoped> <style lang="scss" scoped>
$descriptor--light: rgb(87 86 86 / 6%);
body.body--light { body.body--light {
alexm commented 2023-08-14 12:15:20 +00:00
Outdated
Review
Copy Link

Podries gastar el color de una de les variables que has creat:
https://gitea.verdnatura.es/verdnatura/salix-front/pulls/79/files#diff-b1e76443679ed8e3f9150534016e8ec63d3c1f9f

$white: #fff;
$black: #000;
$light-black: #4e4c4c;
$gray: gray;
$light-gray: #57565633;
$lighter-gray: #5756560f;

I possarli lo de light i tal pero de manera global

Podries gastar el color de una de les variables que has creat: https://gitea.verdnatura.es/verdnatura/salix-front/pulls/79/files#diff-b1e76443679ed8e3f9150534016e8ec63d3c1f9f ``` $white: #fff; $black: #000; $light-black: #4e4c4c; $gray: gray; $light-gray: #57565633; $lighter-gray: #5756560f; ``` I possarli lo de light i tal pero de manera global
.descriptor { .descriptor {
.subtitle { .subtitle {
alexm commented 2023-08-14 05:06:50 +00:00
Outdated
Review
Copy Link

Esta variable debería estar o definida aquí o tener un nombre mas genérico. Dado que esta definida de manera global

Esta variable debería estar o definida aquí o tener un nombre mas genérico. Dado que esta definida de manera global
color: $gray; color: $gray;
} }
.list-box { .list-box {
background-color: $descriptor--light; background-color: $lighter-gray;
} }
} }
} }

11
src/components/ui/CardList.vue
View File

@ -109,21 +109,24 @@ body.body--light {
display: grid; display: grid;
alexm commented 2023-08-14 05:12:07 +00:00
Outdated
Review
Copy Link

Lo de tindre 3 media queries, vuic voreu visualment a vore si cal o podem solucionar-ho per altre cami

Lo de tindre 3 media queries, vuic voreu visualment a vore si cal o podem solucionar-ho per altre cami
grid-template-columns: repeat(2, 1fr); grid-template-columns: repeat(2, 1fr);
row-gap: 10px; row-gap: 10px;
column-gap: 10vw;
margin-right: 10px; margin-right: 10px;
} }
.actions { .actions {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
justify-content: center; justify-content: center;
} }
@media (min-width: 1024px) and (max-width: 1100px) { @media screen and (min-width: $breakpoint-lg) {
.list-items {
column-gap: 10vw;
}
}
@media screen and (min-width: $breakpoint-sm) {
.list-items { .list-items {
column-gap: 5vw; column-gap: 5vw;
alexm commented 2023-08-14 12:10:23 +00:00
Outdated
Review
Copy Link

Para que toda la web funcione igual creo que seria mas conveniente usar este tipo de media queris asi todos usamos el mismo tipo.
@media (max-width: $breakpoint-xs)
Ejemplo: src/components/ui/VnSearchbar.vue

Para que toda la web funcione igual creo que seria mas conveniente usar este tipo de media queris asi todos usamos el mismo tipo. @media (max-width: $breakpoint-xs) Ejemplo: src/components/ui/VnSearchbar.vue
} }
} }
@media (max-width: 600px) { @media (max-width: $breakpoint-xs) {
.list-items { .list-items {
grid-template-columns: 1fr; grid-template-columns: 1fr;
grid-gap: 5px; grid-gap: 5px;

2
src/pages/Ticket/Card/TicketDescriptor.vue
View File

@ -88,7 +88,7 @@ const setData = (entity) =>
<template #body="{ entity }"> <template #body="{ entity }">
<VnLv v-if="entity.ticketState" :label="t('ticket.card.state')"> <VnLv v-if="entity.ticketState" :label="t('ticket.card.state')">
<template #value> <template #value>
<QBadge :color="entity.ticketState.state.classColor ?? 'primary'"> <QBadge :color="entity.ticketState.state.classColor">
alexm commented 2023-08-14 05:11:01 +00:00
Outdated
Review
Copy Link

Este orange deuria ser primary entenc

Este orange deuria ser `primary` entenc
alexm commented 2023-08-14 12:08:25 +00:00
Outdated
Review
Copy Link

Por defecto naranja??

Por defecto naranja??
{{ entity.ticketState.state.name }} {{ entity.ticketState.state.name }}
</QBadge> </QBadge>
</template> </template>