verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#7346 manualInvoice #793

Merged
jgallego merged 19 commits from 7346-manualInvoice into dev 2024-11-19 07:10:07 +00:00
Conversation 5 Commits 19 Files Changed 15 +282 -335
jgallego commented 2024-10-02 13:39:15 +00:00
Owner
Copy Link
No description provided.
jgallego added 3 commits 2024-10-02 13:39:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6d08875809 fix: icons
jgallego added 1 commit 2024-10-02 14:38:05 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
789e70b7a8 feat: all clients just with global series
jgallego added 2 commits 2024-10-03 08:17:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6eb0c93802 feat: manual invoice in two lines
jgallego commented 2024-10-03 08:19:48 +00:00
Author
Owner
Copy Link

image

![image](/attachments/3b18e946-1433-412c-8c2a-ecf26ec93189)
image.png
24 KiB
jgallego requested review from jsegarra 2024-10-03 08:20:02 +00:00
jgallego commented 2024-10-03 08:20:36 +00:00
Author
Owner
Copy Link

@jsegarra revisa bien, porque no se si visualmente es la mejor opcion o si habría otras mas elegantes

@jsegarra revisa bien, porque no se si visualmente es la mejor opcion o si habría otras mas elegantes
jsegarra added 1 commit 2024-10-04 07:45:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1aab0abbcd Merge branch 'dev' into 7346-manualInvoice
jsegarra requested changes 2024-10-04 07:55:59 +00:00
Dismissed
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -290,3 +319,1 @@
searchInvoice: Buscar factura emitida
fileDenied: El navegador denegó la descarga de archivos...
fileAllowed: Descarga exitosa de archivo CSV
createInvoice: Make invoice Create manual invoice: Create manual invoice
jsegarra commented 2024-10-04 07:55:55 +00:00
Member
Copy Link

El formateador o eslint ha roto el módulo

El formateador o eslint ha roto el módulo
jsegarra commented 2024-10-04 07:58:45 +00:00
Member
Copy Link

Revisar image

Revisar ![image](/attachments/52c6b2ae-abd5-4b06-9046-07a0f262669d)
image.png
48 KiB
jsegarra commented 2024-10-04 07:59:37 +00:00
Member
Copy Link

Se que no aplica a tus cambios pero image

Se que no aplica a tus cambios pero ![image](/attachments/b8d41e80-bfd1-46b9-972a-cd72db48d7d3)
image.png
48 KiB
jgallego added 1 commit 2024-10-21 12:01:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
69215851bb Merge branch 'dev' into 7346-manualInvoice
jgallego added 1 commit 2024-10-22 13:04:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2a94916bc2 feat: refs #7346 radioButton
jgallego added 2 commits 2024-11-12 06:29:04 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
76e35cc758 feat: refs #7346 address ordered
jgallego added 1 commit 2024-11-12 06:43:10 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8e4931516a feat: refs #7346 traducciones en cammelCase
jgallego requested review from alexm 2024-11-12 07:50:15 +00:00
jgallego requested review from jsegarra 2024-11-12 07:50:16 +00:00
alexm requested changes 2024-11-12 13:56:45 +00:00
Dismissed
alexm left a comment
Member
Copy Link

També se me fa raro vore 2 clients i depen de que tries va uno o el altre

També se me fa raro vore 2 clients i depen de que tries va uno o el altre
src/components/VnTable/VnTable.vue Outdated
@ -236,7 +234,7 @@ function splitColumns(columns) {
if (col.create) splittedColumns.value.create.push(col);
if (col.cardVisible) splittedColumns.value.cardVisible.push(col);
if ($props.isEditable && col.disable == null) col.disable = false;
if ($props.useModel && col.columnFilter != false)
alexm commented 2024-11-12 13:50:27 +00:00
Member
Copy Link

Estava ficat aixina pq si li fiques false es pq no vols q se puga filtrar la columna. Pero null/undefined es pq si

Estava ficat aixina pq si li fiques false es pq no vols q se puga filtrar la columna. Pero null/undefined es pq si
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +234,4 @@
<VnRadio
v-model="selectedOption"
val="cliente"
label="Cliente"
alexm commented 2024-11-12 13:55:56 +00:00
Member
Copy Link

Seria en t('') (esta consignatario tb)

Seria en t('') (esta consignatario tb)
jsegarra requested changes 2024-11-12 13:58:51 +00:00
Dismissed
src/pages/InvoiceOut/InvoiceOutList.vue
@ -252,0 +226,4 @@
<VnInput
:disable="selectedOption !== 'ticket'"
v-model="data.ticketFk"
label="Ticket ID"
jsegarra commented 2024-11-12 13:54:49 +00:00
Member
Copy Link

traducción?
Entiendo que si algún día cambia el criterio solo habrá que hacer una modificación

traducción? Entiendo que si algún día cambia el criterio solo habrá que hacer una modificación
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +234,4 @@
<VnRadio
v-model="selectedOption"
val="cliente"
label="Cliente"
jsegarra commented 2024-11-12 13:53:56 +00:00
Member
Copy Link

traducción?

traducción?
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +240,4 @@
<VnSelect
:disable="selectedOption !== 'cliente'"
v-model="data.clientFk"
label="Cliente"
jsegarra commented 2024-11-12 13:54:03 +00:00
Member
Copy Link

traducción?

traducción?
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +267,4 @@
<VnRadio
v-model="selectedOption"
val="consignatario"
label="Consignatario"
jsegarra commented 2024-11-12 13:55:04 +00:00
Member
Copy Link

Traducción?

Traducción?
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +283,4 @@
option-label="name"
option-value="id"
@update:model-value="fetchClientAddress"
:disable="selectedOption !== 'consignatario'"
jsegarra commented 2024-11-12 13:55:36 +00:00
Member
Copy Link

repetimos condición?

repetimos condición?
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -252,0 +303,4 @@
<div class="col">
<VnSelect
v-model="data.addressFk"
label="Consignatario"
jsegarra commented 2024-11-12 13:55:48 +00:00
Member
Copy Link

traducción

traducción
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -286,3 +404,4 @@
</VnTable>
</template>
<style lang="scss" scoped>
jsegarra commented 2024-11-12 13:57:27 +00:00
Member
Copy Link

esto la IA te lo simplifica

esto la IA te lo simplifica
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -304,0 +422,4 @@
en:
invoiceId: Invoice ID
viewSummary: View Summary
downloadPdf: Download PDF
jsegarra commented 2024-11-12 13:57:59 +00:00
Member
Copy Link

esta traducción, por ejemplo ya está definida en globals

esta traducción, por ejemplo ya está definida en globals
jsegarra commented 2024-11-13 11:55:28 +00:00
Member
Copy Link

@jgallego Tanto @alexm como yo hemos coincido en que hay duplicidad de campos y de lógica.
Por tanto, llegamos a una propuesta que pasa por solo tener un radioButton para Ticket. De esta manera si seleccionas ticket, los campos de cliente y consignatario se bloquean; si no lo seleccionas puedes indicar la información que quieras(cliente y/o consignatario).

@jgallego Tanto @alexm como yo hemos coincido en que hay duplicidad de campos y de lógica. Por tanto, llegamos a una propuesta que pasa por solo tener un radioButton para Ticket. De esta manera si seleccionas ticket, los campos de cliente y consignatario se bloquean; si no lo seleccionas puedes indicar la información que quieras(cliente y/o consignatario).
jsegarra changed title from 7346-manualInvoice to #7346 manualInvoice 2024-11-13 11:56:14 +00:00
jgallego added 2 commits 2024-11-14 09:47:28 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c0ddc2c5b4 fix: refs #7346 traslations
jsegarra added 3 commits 2024-11-14 10:51:17 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
aa05b4b0cb perf: refs #7346 #7346 Imrpove interface dialog
jsegarra added 1 commit 2024-11-14 10:54:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5af494e13c perf: refs #7346 #7346 use v-show instead v-if
jgallego requested review from alexm 2024-11-14 11:27:06 +00:00
jgallego requested review from jsegarra 2024-11-14 11:27:08 +00:00
jsegarra approved these changes 2024-11-14 13:49:29 +00:00
Dismissed
alexm approved these changes 2024-11-15 08:21:15 +00:00
Dismissed
jgallego added 1 commit 2024-11-18 14:46:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7d2f4bcf44 Merge branch 'dev' into 7346-manualInvoice
jgallego dismissed jsegarra’s review 2024-11-18 14:46:19 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jgallego dismissed alexm’s review 2024-11-18 14:46:19 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jgallego merged commit 9c271eee08 into dev 2024-11-19 07:10:07 +00:00
jgallego deleted branch 7346-manualInvoice 2024-11-19 07:10:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#793
No description provided.
Delete Branch "7346-manualInvoice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?