verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#6943 - Customer specs #822

Merged
jsegarra merged 6 commits from 6943_customer_spec into dev 2024-10-21 11:14:58 +00:00
Conversation 2 Commits 6 Files Changed 19 +297
jsegarra commented 2024-10-11 13:46:59 +00:00
Member
Copy Link

Lo he comentado con Javi y si son test que nos aporten seguridad de que las secciones cargan, el que venga después que lo continue

Lo he comentado con Javi y si son test que nos aporten seguridad de que las secciones cargan, el que venga después que lo continue
jsegarra added 1 commit 2024-10-11 13:47:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3d9d08146c test: refs #6943 add customer test
jsegarra added 1 commit 2024-10-14 12:35:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6633e65ee2 Merge branch 'dev' into 6943_customer_spec
jsegarra changed title from WIP: #6943 - Customer specs to #6943 - Customer specs 2024-10-14 12:35:55 +00:00
jsegarra added the
CR / Tests passed
 label 2024-10-14 12:36:01 +00:00
jsegarra requested review from alexm 2024-10-14 12:36:04 +00:00
alexm reviewed 2024-10-14 12:44:25 +00:00
test/cypress/integration/client/clientList.spec.js
@ -0,0 +6,4 @@
cy.visit('/#/customer/list', {
timeout: 5000,
onBeforeLoad(win) {
cy.stub(win, 'open');
alexm commented 2024-10-14 12:44:24 +00:00
Member
Copy Link

Eso para que es?

Eso para que es?
jsegarra commented 2024-10-14 12:45:16 +00:00
Author
Member
Copy Link

Esto lo tenemos en otros tests para evitar que se abra una segunda ventana de cypress

Esto lo tenemos en otros tests para evitar que se abra una segunda ventana de cypress
alexm marked this conversation as resolved
alexm approved these changes 2024-10-14 12:46:16 +00:00
Dismissed
alexm commented 2024-10-14 12:46:40 +00:00
Member
Copy Link

Personalmente quitaria el prefijo Handle, lo veo redundante

Personalmente quitaria el prefijo Handle, lo veo redundante
❤️ 1
jsegarra added 2 commits 2024-10-16 07:22:15 +00:00
jsegarra dismissed alexm’s review 2024-10-16 07:22:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-10-16 07:22:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4115b1b303 Merge branch 'dev' into 6943_customer_spec
jsegarra requested review from alexm 2024-10-16 07:23:03 +00:00
alexm approved these changes 2024-10-21 10:52:30 +00:00
jsegarra added 1 commit 2024-10-21 11:14:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cdce4d063c Merge branch 'dev' into 6943_customer_spec
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-10-21 11:14:50 +00:00
jsegarra merged commit 76b69a7588 into dev 2024-10-21 11:14:58 +00:00
alexm commented 2024-10-21 11:44:58 +00:00
Member
Copy Link

Me fallan muchos

Me fallan muchos
alexm deleted branch 6943_customer_spec 2024-10-21 11:57:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#822
No description provided.
Delete Branch "6943_customer_spec"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?