verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

refs 6105 claimNotes and VnNotes created #83

Merged
jorgep merged 11 commits from 6105-createClaimNotes into dev 2023-08-25 08:43:09 +00:00
Conversation 0 Commits 11 Files Changed 11 +251 -13
jorgep commented 2023-08-16 07:05:13 +00:00
Member
Copy Link
No description provided.
jorgep added the
CR / Tests passed
 label 2023-08-16 07:05:13 +00:00
jorgep added 1 commit 2023-08-16 07:05:15 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
ee7c2389b5 refs 6105 claimNotes and VnNotes created
jorgep requested review from alexm 2023-08-16 07:05:22 +00:00
alexm requested changes 2023-08-17 05:25:55 +00:00
src/components/ui/AvatarPicture.vue Outdated
@ -0,0 +24,4 @@
</div>
</div>
</template>
<style lang="scss" scoped>
alexm commented 2023-08-17 05:25:52 +00:00
Member
Copy Link

class="column items-centar" fa el mateix (crec)

i en .description "text-center"

class="column items-centar" fa el mateix (crec) i en .description "text-center"
👍 1
jorgep marked this conversation as resolved
src/components/ui/VnNotes.vue
@ -0,0 +18,4 @@
const notes = ref([]);
const noteModal = ref(false);
const newNote = ref('');
const claimObservationRef = ref();
alexm commented 2023-08-17 05:12:26 +00:00
Member
Copy Link

Un component global, que se gastara en ticket, worker, etc no deuria tindre algo tan especific de claim

Un component global, que se gastara en ticket, worker, etc no deuria tindre algo tan especific de claim
👍 1
jorgep marked this conversation as resolved
src/components/ui/VnNotes.vue Outdated
@ -0,0 +33,4 @@
</script>
<template>
<FetchData
:url="$props.url"
alexm commented 2023-08-17 05:12:52 +00:00
Member
Copy Link

Sols seria canviar el nom del ref, pq la url i tot si q ho tens dinamic

Sols seria canviar el nom del ref, pq la url i tot si q ho tens dinamic
👍 1
jorgep marked this conversation as resolved
src/components/ui/VnNotes.vue Outdated
@ -0,0 +39,4 @@
auto-load
ref="claimObservationRef"
/>
<div class="notes" ref="notesContainer">
alexm commented 2023-08-17 05:19:09 +00:00
Member
Copy Link

El ref este si no es gasta en cap lloc lleval

El ref este si no es gasta en cap lloc lleval
👍 1
jorgep marked this conversation as resolved
src/components/ui/VnNotes.vue Outdated
@ -0,0 +40,4 @@
ref="claimObservationRef"
/>
<div class="notes" ref="notesContainer">
<QDialog v-model="noteModal" persistent>
alexm commented 2023-08-17 05:19:41 +00:00
Member
Copy Link

El QDialog dixal al final del html, si no queda confus

El QDialog dixal al final del html, si no queda confus
👍 1
jgallego marked this conversation as resolved
src/components/ui/VnNotes.vue Outdated
@ -0,0 +77,4 @@
</QCardActions>
</QCard>
</QDialog>
<QCard class="q-pa-md" v-for="(note, index) in notes" :key="index">
alexm commented 2023-08-17 05:22:11 +00:00
Member
Copy Link

Podries gastar el component VnPaginate i te ahorraries el fetch de dalt i el v.for de aci.
Apart aixina tens millor logica per als filtros (VnPaginate te mes props que podrien ser utils en un futur):

    dataKey: {
        type: String,
        required: true,
    },
    autoLoad: {
        type: Boolean,
        default: false,
    },
    data: {
        type: Array,
        default: null,
    },
    url: {
        type: String,
        default: '',
    },
    filter: {
        type: Object,
        default: null,
    },
    where: {
        type: Object,
        default: null,
    },
    order: {
        type: String,
        default: '',
    },
    limit: {
        type: Number,
        default: 10,
    },
    userParams: {
        type: Object,
        default: null,
    },
    offset: {
        type: Number,
        default: 500,
    },

Pots gastar el component i possarli v-bind="$attrs" i li pasa les propietats que a tu te hajen pasat. I ja no has ni de fenirles tu

Podries gastar el component VnPaginate i te ahorraries el fetch de dalt i el v.for de aci. Apart aixina tens millor logica per als filtros (VnPaginate te mes props que podrien ser utils en un futur): ``` dataKey: { type: String, required: true, }, autoLoad: { type: Boolean, default: false, }, data: { type: Array, default: null, }, url: { type: String, default: '', }, filter: { type: Object, default: null, }, where: { type: Object, default: null, }, order: { type: String, default: '', }, limit: { type: Number, default: 10, }, userParams: { type: Object, default: null, }, offset: { type: Number, default: 500, }, ``` Pots gastar el component i possarli v-bind="$attrs" i li pasa les propietats que a tu te hajen pasat. I ja no has ni de fenirles tu
jorgep marked this conversation as resolved
src/components/ui/VnNotes.vue
@ -0,0 +118,4 @@
.q-card {
min-width: 350px;
}
.note-dialog {
alexm commented 2023-08-17 05:16:01 +00:00
Member
Copy Link

Quasar te clases (paregut a bootstrap) que te dixa fer coses de estes i te ahorra CSS.
Per exemple esta la clase column que ja te fa esta part:

	    display: flex;
    flex-direction: column;

igual que la part de:

        align-self: flex-start;
        display: flex;
        justify-content: space-between;

Es pot fer tambe:
https://quasar.dev/layout/grid/column#introduction

Quasar te clases (paregut a bootstrap) que te dixa fer coses de estes i te ahorra CSS. Per exemple esta la clase column que ja te fa esta part: ``` display: flex; flex-direction: column; ``` igual que la part de: ``` align-self: flex-start; display: flex; justify-content: space-between; ``` Es pot fer tambe: https://quasar.dev/layout/grid/column#introduction
👍 1
jorgep marked this conversation as resolved
src/pages/Claim/Card/ClaimNotes.vue Outdated
@ -0,0 +36,4 @@
/>
</div>
</template>
<style lang="scss">
alexm commented 2023-08-17 05:23:54 +00:00
Member
Copy Link

Lo mateix intentem no gastar tant de CSS i gastar mes coses de Quasar. https://quasar.dev/layout/grid/column#introduction

Lo mateix intentem no gastar tant de CSS i gastar mes coses de Quasar. https://quasar.dev/layout/grid/column#introduction
jorgep commented 2023-08-17 12:29:23 +00:00
Author
Member
Copy Link

Estoy dando estilo a clases de un componente hijo desde el padre, aquí no puedo usar las clases de quasar.

Estoy dando estilo a clases de un componente hijo desde el padre, aquí no puedo usar las clases de quasar.
alexm commented 2023-08-18 11:02:54 +00:00
Member
Copy Link

Pero entonces estas clases (si son de quasar mejor). Deberian estar en el componente. Si no en cada sitio donde uses el componente lo tendrás que estilar.

De hecho cuando hice esta sección: src/pages/Ticket/Card/TicketSms.vue use 0 lineas de CSS.
Y VnNotes es un 99% igual
http://localhost:9000/#/ticket/1/sms?order=smsFk+DESC&limit=5

Pero entonces estas clases (si son de quasar mejor). Deberian estar en el componente. Si no en cada sitio donde uses el componente lo tendrás que estilar. De hecho cuando hice esta sección: src/pages/Ticket/Card/TicketSms.vue use 0 lineas de CSS. Y VnNotes es un 99% igual http://localhost:9000/#/ticket/1/sms?order=smsFk+DESC&limit=5
jorgep marked this conversation as resolved
src/pages/Claim/Card/ClaimNotes.vue Outdated
@ -0,0 +70,4 @@
}
}
}
@media (max-width: 1150px) {
alexm commented 2023-08-17 05:24:23 +00:00
Member
Copy Link

Aci seria mes convenient lo de $breakpoint-md (per exemple)

Aci seria mes convenient lo de $breakpoint-md (per exemple)
👍 1
jorgep marked this conversation as resolved
jorgep added 4 commits 2023-08-18 10:13:10 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
4bac67de38 refs 6105 VnNotes and ClaimNotes refactored
jorgep requested review from alexm 2023-08-18 10:13:13 +00:00
alexm reviewed 2023-08-18 10:49:04 +00:00
src/components/ui/AvatarPicture.vue Outdated
@ -0,0 +1,26 @@
<script setup>
alexm commented 2023-08-18 10:49:04 +00:00
Member
Copy Link

El nom de avatar picture no me acaba, voria mes un WorkerAvatar, VnAvatar, ns

El nom de avatar picture no me acaba, voria mes un WorkerAvatar, VnAvatar, ns
jorgep marked this conversation as resolved
alexm reviewed 2023-08-18 10:58:58 +00:00
src/components/ui/VnNotes.vue
@ -0,0 +111,4 @@
:label="t('globals.save')"
color="primary"
v-close-popup
@click="fetch"
alexm commented 2023-08-18 10:58:58 +00:00
Member
Copy Link

fetch? Seria mas correcto submit, insert, etc

fetch? Seria mas correcto submit, insert, etc
jorgep marked this conversation as resolved
alexm reviewed 2023-08-18 10:59:52 +00:00
src/components/ui/VnNotes.vue Outdated
@ -0,0 +130,4 @@
width: 95%;
}
}
.add-btn {
alexm commented 2023-08-18 10:59:52 +00:00
Member
Copy Link

Si ya tiene la propiedad size="md" pq tiene una clase?

Si ya tiene la propiedad size="md" pq tiene una clase?
jorgep marked this conversation as resolved
alexm requested changes 2023-08-18 11:05:48 +00:00
alexm left a comment
Member
Copy Link

.

.
jorgep added 1 commit 2023-08-18 12:35:17 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
9f9a44ee37 refs 6105 VnNotes refactored with quasar classes
jorgep added 1 commit 2023-08-18 12:42:34 +00:00
jorgep requested review from alexm 2023-08-18 12:46:52 +00:00
alexm reviewed 2023-08-21 05:20:35 +00:00
src/components/ui/VnNotes.vue Outdated
@ -0,0 +123,4 @@
</QDialog>
</div>
</template>
<style lang="scss" scoped>
alexm commented 2023-08-21 05:20:35 +00:00
Member
Copy Link

Ya esta todo bien, faltaría mirar si podemos quitar CSS

Ya esta todo bien, faltaría mirar si podemos quitar CSS
jorgep commented 2023-08-21 06:05:06 +00:00
Author
Member
Copy Link

Creo que no, son propiedades width y order.

Creo que no, son propiedades width y order.
jorgep marked this conversation as resolved
alexm requested changes 2023-08-24 11:46:41 +00:00
alexm left a comment
Member
Copy Link

Modificaciones comentadas en persona

Modificaciones comentadas en persona
alexm added 1 commit 2023-08-24 11:46:48 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
628f51d6de Merge branch 'dev' into 6105-createClaimNotes
jorgep added 2 commits 2023-08-24 12:56:52 +00:00
jorgep requested review from alexm 2023-08-24 12:56:58 +00:00
jorgep added 1 commit 2023-08-24 12:59:27 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
75e0f4c7fe refs #6105 spacing card notes
alexm approved these changes 2023-08-25 07:59:17 +00:00
jorgep merged commit 337b3d369a into dev 2023-08-25 08:43:09 +00:00
jorgep deleted branch 6105-createClaimNotes 2023-08-25 08:43:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#83
No description provided.
Delete Branch "6105-createClaimNotes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?