verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#7229 download file #833

Merged
jorgep merged 10 commits from 7229-fixDownloadFile into dev 2024-11-22 09:34:32 +00:00
Conversation 1 Commits 10 Files Changed 2 +38 -14
jorgep commented 2024-10-15 08:26:43 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-10-15 08:26:43 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
fb7087d38a fix: refs #7229 download file
jorgep added 1 commit 2024-10-16 09:49:54 +00:00
jorgep added 1 commit 2024-10-28 15:25:25 +00:00
jorgep added 1 commit 2024-11-19 14:49:55 +00:00
jorgep added 1 commit 2024-11-19 14:54:44 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
9665a3407f fix: refs #7229 remove catch
jorgep added 1 commit 2024-11-20 12:15:06 +00:00
jorgep added 1 commit 2024-11-20 12:50:40 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ad93e16896 fix: refs #7229 url
jorgep reviewed 2024-11-20 12:57:21 +00:00
src/composables/downloadFile.js
@ -1,11 +1,24 @@
import { useSession } from 'src/composables/useSession';
import { getUrl } from './getUrl';
import axios from 'axios';
jorgep commented 2024-11-20 12:57:21 +00:00
Author
Member
Copy Link

Así en lugar de abrirlo en una ventana de al lado, lo descarga

Así en lugar de abrirlo en una ventana de al lado, lo descarga
jorgep added 1 commit 2024-11-20 15:44:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
43f94ede64 fix: refs #7229 url + test
jorgep added 1 commit 2024-11-20 15:47:05 +00:00
jorgep changed title from WIP: fix: refs #7229 download file to #7229 download file 2024-11-20 15:47:42 +00:00
jorgep reviewed 2024-11-20 15:48:06 +00:00
test/vitest/__tests__/composables/downloadFile.spec.js
@ -10,0 +9,4 @@
const baseUrl = 'http://localhost:9000';
let defaulCreateObjectURL;
beforeAll(() => {
jorgep commented 2024-11-20 15:48:06 +00:00
Author
Member
Copy Link

Hay que mockearlo, si no da fallo

Hay que mockearlo, si no da fallo
jorgep requested review from alexm 2024-11-20 16:16:31 +00:00
jorgep added the
CR / Tests passed
 label 2024-11-20 16:16:34 +00:00
alexm approved these changes 2024-11-21 06:55:42 +00:00
alexm commented 2024-11-21 06:56:10 +00:00
Member
Copy Link

Prueba que otros sitios donde se use downloadFile sigan funcionando

Prueba que otros sitios donde se use downloadFile sigan funcionando
👍 1
jorgep added 1 commit 2024-11-22 09:25:11 +00:00
jorgep merged commit 55f9023201 into dev 2024-11-22 09:34:32 +00:00
jorgep deleted branch 7229-fixDownloadFile 2024-11-22 09:34:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#833
No description provided.
Delete Branch "7229-fixDownloadFile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?