verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#8036 - arrayData_exprBuilder_after #845

Merged
alexm merged 7 commits from 8036-arrayData_exprBuilder_after into dev 2024-11-19 09:03:50 +00:00
Conversation 0 Commits 7 Files Changed 2 +22 -14
alexm commented 2024-10-18 12:05:16 +00:00
Member
Copy Link

Me he equivocado poniendo revisor, no me he dado cuenta que estaba en análisis

Me he equivocado poniendo revisor, no me he dado cuenta que estaba en análisis
alexm added 2 commits 2024-10-18 12:05:17 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bfc906a346 fix: refs #8036 only add where when required
alexm reviewed 2024-10-18 12:05:42 +00:00
src/components/ui/VnFilterPanel.vue Outdated
@ -62,7 +62,6 @@ const emit = defineEmits([
'update:modelValue',
'refresh',
'clear',
'search',
alexm commented 2024-10-18 12:05:42 +00:00
Author
Member
Copy Link

Como ahora se muestra bien, se puede mostrar

Como ahora se muestra bien, se puede mostrar
alexm requested review from jorgep 2024-10-18 12:05:56 +00:00
alexm added the
CR / Tests passed
 label 2024-10-18 12:05:59 +00:00
alexm changed title from 8036-arrayData_exprBuilder_after to WIP: 8036-arrayData_exprBuilder_after 2024-10-18 12:06:49 +00:00
alexm reviewed 2024-10-18 12:07:41 +00:00
src/composables/useArrayData.js Outdated
@ -76,4 +76,2 @@
let exprFilter;
let userParams = { ...store.userParams };
if (store?.exprBuilder) {
alexm commented 2024-10-18 12:07:41 +00:00
Author
Member
Copy Link

La solucion era ejecutar el exprBuilder despues de todo, y guardar el filtro antes de aplicarlo

La solucion era ejecutar el exprBuilder despues de todo, y guardar el filtro antes de aplicarlo
alexm reviewed 2024-10-23 09:34:51 +00:00
src/composables/useArrayData.js Outdated
@ -98,8 +90,23 @@ export function useArrayData(key = useRoute().meta.moduleName, userOptions) {
if (store.order && store.order.length) params.filter.order = store.order;
else delete params.filter.order;
store.currentFilter = JSON.parse(JSON.stringify(params));
alexm commented 2024-10-23 09:34:51 +00:00
Author
Member
Copy Link

Usar structuredClone

Usar structuredClone
alexm added 1 commit 2024-10-24 05:58:17 +00:00
alexm added 2 commits 2024-10-24 13:12:06 +00:00
gitea/salix-front/pipeline/pr-test Build started... Details
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1e04ead780 perf: refs #8036 currentFilter
alexm reviewed 2024-10-25 06:10:56 +00:00
src/composables/useArrayData.js Outdated
@ -99,2 +92,4 @@
else delete params.filter.order;
store.currentFilter = JSON.parse(JSON.stringify(params));
delete store.currentFilter.filter.include;
alexm commented 2024-10-25 06:10:56 +00:00
Author
Member
Copy Link

Els borre per a que no moleste en la url

Els borre per a que no moleste en la url
alexm reviewed 2024-10-25 06:12:03 +00:00
src/composables/useArrayData.js Outdated
@ -99,2 +91,4 @@
if (store.order && store.order.length) params.filter.order = [...store.order];
else delete params.filter.order;
store.currentFilter = JSON.parse(JSON.stringify(params));
alexm commented 2024-10-25 06:12:03 +00:00
Author
Member
Copy Link

No se pot fer sense JSON.parse(JSON.stringify , he provat en structuredClone, pero no permitix gastar dins Proxys. I la opcio de fer {...params} mantendria la refernecia de 2n nivell

No se pot fer sense JSON.parse(JSON.stringify , he provat en structuredClone, pero no permitix gastar dins Proxys. I la opcio de fer {...params} mantendria la refernecia de 2n nivell
alexm changed title from WIP: 8036-arrayData_exprBuilder_after to 8036-arrayData_exprBuilder_after 2024-10-25 06:34:13 +00:00
alexm requested review from jgallego 2024-10-25 06:34:21 +00:00
alexm changed title from 8036-arrayData_exprBuilder_after to #8036 - arrayData_exprBuilder_after 2024-10-25 06:34:56 +00:00
jgallego refused to review 2024-10-25 07:18:49 +00:00
jgallego requested review from juan 2024-10-25 07:19:02 +00:00
jorgep refused to review 2024-10-25 07:22:13 +00:00
alexm added 1 commit 2024-11-13 06:22:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6f1e6a3bfa Merge branch 'dev' into 8036-arrayData_exprBuilder_after
juan refused to review 2024-11-18 13:57:07 +00:00
jgallego requested review from jgallego 2024-11-18 14:22:22 +00:00
jgallego approved these changes 2024-11-18 14:22:26 +00:00
Dismissed
alexm added 1 commit 2024-11-19 09:00:27 +00:00
alexm dismissed jgallego’s review 2024-11-19 09:00:27 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa approved these changes 2024-11-19 09:03:26 +00:00
alexm merged commit 19cb781800 into dev 2024-11-19 09:03:50 +00:00
alexm deleted branch 8036-arrayData_exprBuilder_after 2024-11-19 09:03:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlossa
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#845
No description provided.
Delete Branch "8036-arrayData_exprBuilder_after"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?