verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

#6943 add comands to solve tests #851

Merged
alexm merged 8 commits from 6943_customer_spec into dev 2024-10-25 09:08:10 +00:00
Conversation 3 Commits 8 Files Changed 12 +32 -33
jsegarra commented 2024-10-21 12:31:46 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2024-10-21 12:31:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f4a7e20c57 test: refs #6943 #6943 add comands to solve tests
jsegarra added the
CR / Tests passed
 label 2024-10-21 12:31:51 +00:00
jsegarra commented 2024-10-21 12:34:35 +00:00
Author
Member
Copy Link

image

![image](/attachments/2e96f86c-b6d2-442d-97fa-4f20f63b264c)
image.png
72 KiB
jsegarra requested review from alexm 2024-10-21 12:34:38 +00:00
alexm requested changes 2024-10-21 12:40:20 +00:00
Dismissed
test/cypress/integration/client/clientList.spec.js Outdated
@ -45,3 +45,3 @@
});
it('Client founded create ticket', () => {
it.skip('Client founded create ticket', () => {
alexm commented 2024-10-21 12:40:01 +00:00
Member
Copy Link

skip?

skip?
jsegarra commented 2024-10-22 10:44:41 +00:00
Author
Member
Copy Link

Si, a la espera de que se bajen los cambios de master que es donde se hizo el test en origen

Si, a la espera de que se bajen los cambios de master que es donde se hizo el test en origen
alexm commented 2024-10-22 11:34:50 +00:00
Member
Copy Link

No hay nada por bajar

No hay nada por bajar
jsegarra commented 2024-10-22 11:52:27 +00:00
Author
Member
Copy Link

pero todavía no está fusionada

pero todavía no está fusionada
test/cypress/support/commands.js Outdated
@ -245,6 +245,13 @@ Cypress.Commands.add('validateContent', (selector, expectedValue) => {
cy.get(selector).should('have.text', expectedValue);
alexm commented 2024-10-21 12:40:18 +00:00
Member
Copy Link

Donde se usan?

Donde se usan?
jsegarra commented 2024-10-22 10:44:07 +00:00
Author
Member
Copy Link

los he extraído de hacer los test de client.

los he extraído de hacer los test de client.
alexm commented 2024-10-24 06:54:21 +00:00
Member
Copy Link

Pues ya bajaran, no hay que subir cosas que no se usan

Pues ya bajaran, no hay que subir cosas que no se usan
jsegarra added 2 commits 2024-10-22 10:44:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d25cdbf34e test: refs #6943 #6943 use command correctly
jsegarra requested review from alexm 2024-10-22 10:44:56 +00:00
alexm commented 2024-10-24 06:54:44 +00:00
Member
Copy Link

En general quitar cosas si no son propias de dev, si se suben a master, ya bajaran

En general quitar cosas si no son propias de dev, si se suben a master, ya bajaran
jsegarra added 1 commit 2024-10-24 09:35:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2d8789312b test: refs #6943 #6943 remove skip tests
alexm requested changes 2024-10-25 08:09:13 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Creo que da conflicto pq ya se ha subido jaja

Creo que da conflicto pq ya se ha subido jaja
jsegarra commented 2024-10-25 08:27:23 +00:00
Author
Member
Copy Link

Creo que da conflicto pq ya se ha subido jaja

Es porque has creado un comando hasNotify y yo he hecho uno de checkNotification para valores predefinidos de created, updated, deleted.

Podríamos combinarlas, ya que hasNotify debería devolver solo si existe o no la notificación(hasta el should) y check debería hacer una comprobación del contenido

> Creo que da conflicto pq ya se ha subido jaja Es porque has creado un comando hasNotify y yo he hecho uno de checkNotification para valores predefinidos de created, updated, deleted. Podríamos combinarlas, ya que hasNotify debería devolver solo si existe o no la notificación(hasta el should) y check debería hacer una comprobación del contenido
jsegarra added 2 commits 2024-10-25 08:34:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ff559384aa perf: refs #6943 #6943 merge command
jsegarra requested review from alexm 2024-10-25 08:34:11 +00:00
alexm reviewed 2024-10-25 08:41:38 +00:00
test/cypress/support/commands.js Outdated
@ -268,0 +275,4 @@
});
Cypress.Commands.add('checkNotification', (tag) => {
const defaultTags = {
alexm commented 2024-10-25 08:41:38 +00:00
Member
Copy Link

No veo la necesidad

No veo la necesidad
jsegarra commented 2024-10-25 08:54:56 +00:00
Author
Member
Copy Link

Queria reducir el numero de palabras que le pasas por argumento y que a futuro si cambia, pues hacer el menor numero de cambios pero las probabilidades de que cambie el valor de data*: Data *, es muy muy baja

Queria reducir el numero de palabras que le pasas por argumento y que a futuro si cambia, pues hacer el menor numero de cambios pero las probabilidades de que cambie el valor de data*: Data *, es muy muy baja
alexm approved these changes 2024-10-25 08:41:40 +00:00
Dismissed
jsegarra added 1 commit 2024-10-25 08:53:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
02f682ac0b perf: refs #6943 #6943 merge command
jsegarra dismissed alexm’s review 2024-10-25 08:53:24 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-10-25 08:55:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6bb6cd8d93 Merge branch 'dev' into 6943_customer_spec
jsegarra requested review from alexm 2024-10-25 08:55:09 +00:00
alexm approved these changes 2024-10-25 09:08:01 +00:00
alexm merged commit fc175666b1 into dev 2024-10-25 09:08:10 +00:00
alexm deleted branch 6943_customer_spec 2024-10-25 09:08:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#851
No description provided.
Delete Branch "6943_customer_spec"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?