verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 58 Releases Wiki Activity

ref #6175 VnLinkPhone and MicroSIP icon created #87

Merged
jorgep merged 12 commits from 6175-addMicrosipLink into dev 2023-12-07 15:09:19 +00:00
Conversation 0 Commits 12 Files Changed 10 +111 -37
jorgep commented 2023-08-31 07:10:38 +00:00
Member
Copy Link
No description provided.
jorgep added the
CR / Tests passed
 label 2023-08-31 07:10:38 +00:00
jorgep added 1 commit 2023-08-31 07:10:40 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
3a3ae14dc5 ref #6175 VnLinkPhone and MicroSIP icon created
jorgep requested review from jgallego 2023-08-31 07:10:49 +00:00
jgallego requested changes 2023-09-01 12:48:11 +00:00
src/pages/Worker/Card/WorkerDescriptor.vue Outdated
@ -101,0 +114,4 @@
<VnLinkPhone
v-if="sip"
:phone-number="sip"
scheme-url="sip"
jgallego commented 2023-09-01 12:47:57 +00:00
Owner
Copy Link

en todos has puesto scheme-url="sip"
no puede esto ir en el componente?

en todos has puesto scheme-url="sip" no puede esto ir en el componente?
jorgep commented 2023-09-01 13:05:56 +00:00
Author
Member
Copy Link

Crear un VnLinkPhoneSip?

Crear un VnLinkPhoneSip?
jgallego commented 2023-09-05 11:52:35 +00:00
Owner
Copy Link

vnLinkPhone yo creo que ya es suficiente, no tendremos otro linkPhone en verdnatura que no sea sip

vnLinkPhone yo creo que ya es suficiente, no tendremos otro linkPhone en verdnatura que no sea sip
jorgep commented 2023-09-06 08:14:37 +00:00
Author
Member
Copy Link

vale, pues lo pongo para que sea siempre en sip.

vale, pues lo pongo para que sea siempre en sip.
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-09-06 12:26:38 +00:00
jorgep requested review from jgallego 2023-09-06 12:34:36 +00:00
jorgep added 1 commit 2023-09-06 12:40:49 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
48b4fd96e5 ref #6175 scheme url removed
jgallego requested changes 2023-09-06 12:41:51 +00:00
Dismissed
src/components/ui/VnLinkPhone.vue Outdated
@ -0,0 +9,4 @@
</script>
<template>
<div v-if="props.phoneNumber">
<span v-if="props.icon">
jgallego commented 2023-09-06 12:41:48 +00:00
Owner
Copy Link

si este v-if lo pones bajo en el QBtn no usamos menos codigo y no usamos las variables mas de una vez, simplemente que muestre el botón o no. El resto igual

si este v-if lo pones bajo en el QBtn no usamos menos codigo y no usamos las variables mas de una vez, simplemente que muestre el botón o no. El resto igual
jorgep marked this conversation as resolved
src/pages/Worker/Card/WorkerSummary.vue Outdated
@ -104,0 +110,4 @@
<template #value>
<VnLinkPhone
:phone-number="worker.client.phone"
scheme-url="sip"
jgallego commented 2023-09-06 12:35:42 +00:00
Owner
Copy Link

scheme-url="sip"
no se puede poner en el componente para no repetirlo?

scheme-url="sip" no se puede poner en el componente para no repetirlo?
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-09-07 06:24:18 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
e4efffb336 ref #6175 simplify the component
jorgep added 1 commit 2023-09-07 06:43:04 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
71d3f0c4c6 ref #6175 tests fixed
jorgep requested review from jgallego 2023-09-07 06:43:15 +00:00
jorgep added 1 commit 2023-09-07 07:32:02 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
a4a62c8e3b ref #6175 match linkPhone
jorgep added 1 commit 2023-09-18 12:17:41 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
a2b619b0af Merge branch 'dev' into 6175-addMicrosipLink
jorgep added 2 commits 2023-09-29 06:31:36 +00:00
jgallego requested review from juan 2023-10-05 06:12:23 +00:00
jgallego refused to review 2023-10-05 06:12:25 +00:00
jgallego dismissed jgallego’s review 2023-10-05 06:12:38 +00:00
Reason:

revisa Juan

jgallego approved these changes 2023-10-05 06:12:50 +00:00
Dismissed
jorgep added 1 commit 2023-10-31 11:45:33 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
60523c04c8 Merge branch 'dev' into 6175-addMicrosipLink
jorgep dismissed jgallego’s review 2023-10-31 11:45:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 2 commits 2023-12-07 14:55:26 +00:00
jgallego approved these changes 2023-12-07 15:07:58 +00:00
jgallego removed review request for juan 2023-12-07 15:08:00 +00:00
jorgep merged commit 89198ffe11 into dev 2023-12-07 15:09:19 +00:00
jorgep deleted branch 6175-addMicrosipLink 2023-12-07 15:09:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#87
No description provided.
Delete Branch "6175-addMicrosipLink"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?