verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

Improve required attrs for VnInput* #886

Merged
jsegarra merged 7 commits from improve_isRequired_input into dev 2024-11-08 10:47:56 +00:00
Conversation 0 Commits 7 Files Changed 7 +49 -30
jsegarra commented 2024-10-29 01:31:59 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2024-10-29 01:31:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4b00ab877c perf: use required instead :required="true"
jsegarra changed title from Improve required attrs to Improve required attrs for VnInput* 2024-10-29 01:32:12 +00:00
jsegarra requested review from alexm 2024-10-29 13:03:13 +00:00
alexm approved these changes 2024-10-29 13:13:56 +00:00
Dismissed
alexm added 1 commit 2024-10-29 13:14:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f4bdefd4e7 Merge branch 'dev' into improve_isRequired_input
jsegarra reviewed 2024-10-29 13:17:30 +00:00
src/components/common/VnInput.vue Outdated
@ -33,3 +35,2 @@
const { t } = useI18n();
const requiredFieldRule = (val) => validations().required($attrs.required, val);
const isRequired = computed(() => Object.keys($attrs).includes('required'));
jsegarra commented 2024-10-29 13:17:26 +00:00
Author
Member
Copy Link

@alexm deberíamos crear un composable para que estas 2 lineas fuesen comunes no?
He pensado en usar getCurrentInstance para extraer los $attrs y que devuelva {isRequired y requiredFieldRule.

Te solicito cambios

@alexm deberíamos crear un composable para que estas 2 lineas fuesen comunes no? He pensado en usar getCurrentInstance para extraer los $attrs y que devuelva {isRequired y requiredFieldRule. Te solicito cambios
jsegarra marked this conversation as resolved
jsegarra changed title from Improve required attrs for VnInput* to WIP: Improve required attrs for VnInput* 2024-10-29 13:17:36 +00:00
jsegarra added 1 commit 2024-10-29 14:02:08 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4de23c31b3 feat: use composable to unify logic
jsegarra dismissed alexm’s review 2024-10-29 14:02:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from alexm 2024-10-29 14:02:17 +00:00
jsegarra changed title from WIP: Improve required attrs for VnInput* to Improve required attrs for VnInput* 2024-10-29 14:02:20 +00:00
alexm approved these changes 2024-11-04 06:04:55 +00:00
Dismissed
jsegarra added 1 commit 2024-11-08 07:29:56 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0a5c3bfe5b Merge branch 'dev' into improve_isRequired_input
jsegarra dismissed alexm’s review 2024-11-08 07:29:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from alexm 2024-11-08 07:30:52 +00:00
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-11-08 07:30:59 +00:00
alexm added 1 commit 2024-11-08 07:32:08 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
dce57f4638 Merge branch 'dev' into improve_isRequired_input
alexm approved these changes 2024-11-08 07:32:12 +00:00
Dismissed
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-11-08 07:37:26 +00:00
jsegarra added 2 commits 2024-11-08 07:40:39 +00:00
jsegarra dismissed alexm’s review 2024-11-08 07:40:39 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from alexm 2024-11-08 07:41:57 +00:00
alexm approved these changes 2024-11-08 10:47:33 +00:00
jsegarra merged commit c22c8d9f11 into dev 2024-11-08 10:47:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#886
No description provided.
Delete Branch "improve_isRequired_input"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?