verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

#8002 addSupportService #894

Open
jorgep wants to merge 13 commits from xxxx-addSupportService into dev
pull from: xxxx-addSupportService
merge into: verdnatura:dev
Conversation 0 Commits 13 Files Changed 6 +98 -17
jorgep commented 2024-11-05 08:47:20 +00:00
Member
Copy Link
No description provided.
jorgep added 3 commits 2024-11-05 08:47:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f6d200405c feat: message to grant access
jorgep changed title from #8002 addSupportService to WIP: #8002 addSupportService 2024-11-05 08:47:33 +00:00
jorgep reviewed 2024-11-05 08:58:27 +00:00
src/components/NavBar.vue Outdated
@ -21,1 +21,3 @@
onMounted(() => stateStore.setMounted());
onMounted(() => {
stateStore.setMounted();
stateQuery.add(useRoute());
jorgep commented 2024-11-05 08:58:27 +00:00
Author
Member
Copy Link

useRoute no es accesible desde un composable, si este no se usa dentro de un componente. Por eso lo guardo en stateQuery.

useRoute no es accesible desde un composable, si este no se usa dentro de un componente. Por eso lo guardo en stateQuery.
jorgep reviewed 2024-11-05 08:59:16 +00:00
src/composables/useVnConfirm.js
@ -17,3 +22,1 @@
.onOk(async () => {
if (successFn) successFn();
});
{ customHTML: () => h(component, props) }
jorgep commented 2024-11-05 08:59:16 +00:00
Author
Member
Copy Link

Con la fn h se pueden pasar slots como parámetros.

Con la fn **h** se pueden pasar slots como parámetros.
jorgep added 1 commit 2024-11-11 12:16:28 +00:00
jgallego requested changes 2024-11-13 09:12:26 +00:00
Dismissed
src/boot/quasar.js Outdated
@ -47,1 +54,4 @@
}
// Convey to Alex or Juan...
const additionalData = {
frontPath: stateQuery.route.name,
jgallego commented 2024-11-13 09:09:24 +00:00
Owner
Copy Link

buscar alternativa para no usar stateQuery

buscar alternativa para no usar stateQuery
jorgep commented 2024-11-13 16:41:08 +00:00
Author
Member
Copy Link

Pongo location.href que sirve . Si se quiere implementar una solución más elegante como investigar la posibilidad de usar vue-router como un plugin en pinia o hacer un provide de useRoute() a nivel de la app e inyectarlo donde se necesite, pero, necesito más tiempo para probarlo. Para este caso con location.href es suficiente y efectivo

Pongo location.href que sirve . Si se quiere implementar una solución más elegante como investigar la posibilidad de usar vue-router como un plugin en pinia o hacer un provide de useRoute() a nivel de la app e inyectarlo donde se necesite, pero, necesito más tiempo para probarlo. Para este caso con location.href es suficiente y efectivo
src/boot/quasar.js Outdated
@ -50,0 +72,4 @@
dense: true,
flat: false,
round: true,
noDismiss: isErrorPrivaleges,
jgallego commented 2024-11-13 09:05:17 +00:00
Owner
Copy Link

privileges

privileges
jorgep marked this conversation as resolved
src/i18n/locale/es.yml Outdated
@ -320,1 +320,4 @@
raid: 'Redada {daysInForward} días'
sendCau: Enviar cau
ExplainReason: Explique el motivo por el que no deberia aparecer este fallo
By sending this ticket, all the data related to the error, the section, the user, etc., are already sent.: Al enviar este cau ya se envían todos los datos relacionados con el error, la sección, el usuario, etc
jgallego commented 2024-11-13 08:57:29 +00:00
Owner
Copy Link

la clave tiene que ser mas corta

la clave tiene que ser mas corta
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-11-13 11:37:51 +00:00
jorgep added 1 commit 2024-11-13 12:11:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0c476725ae refactor: use locale keys
jorgep added 1 commit 2024-11-13 14:33:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
34df9cf254 fix: rollback
jorgep added 1 commit 2024-11-13 16:29:23 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a5d032f022 feat: make additional data object
jorgep added 1 commit 2024-11-13 16:45:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
81f1c447ad fix: rollback
jorgep requested review from jgallego 2024-11-13 16:46:15 +00:00
jorgep changed title from WIP: #8002 addSupportService to #8002 addSupportService 2024-11-13 16:46:21 +00:00
jgallego requested review from juan 2024-11-14 06:49:13 +00:00
jgallego refused to review 2024-11-14 06:49:16 +00:00
jgallego dismissed jgallego’s review 2024-11-14 06:49:24 +00:00
Reason:

juan

jorgep added 1 commit 2024-11-14 08:37:36 +00:00
jorgep added 1 commit 2024-11-14 10:41:10 +00:00
jorgep added 1 commit 2024-11-14 11:02:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fa43f270ca fix: prevent null
jorgep added 1 commit 2024-11-14 12:20:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0fe740e415 fix: e2e
jorgep added the
CR / Tests passed
 label 2024-11-14 12:32:30 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#894
No description provided.
Delete Branch "xxxx-addSupportService"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?