verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

fix(InvoiceOutGlobal): parallelism #900

Merged
alexm merged 4 commits from warmFix_invoiceOut_Global into dev 2024-11-07 09:43:19 +00:00
Conversation 0 Commits 4 Files Changed 2 +20 -23
alexm commented 2024-11-06 12:54:11 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2024-11-06 12:54:11 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
ead241e7da chore: remove console.log
alexm requested review from jorgep 2024-11-06 12:54:16 +00:00
alexm added 1 commit 2024-11-06 12:54:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2b02c9fbd3 Merge branch 'dev' into warmFix_invoiceOut_Global
jorgep reviewed 2024-11-06 15:05:22 +00:00
jorgep reviewed 2024-11-06 15:10:00 +00:00
src/pages/InvoiceOut/InvoiceOutGlobalForm.vue
@ -154,3 +154,2 @@
<QBtn
v-if="!invoicing"
v-if="!getStatus || getStatus === 'stopping'"
jorgep commented 2024-11-06 15:10:00 +00:00
Member
Copy Link

El nombre getStatus no me parece correcto. Como veo que puede implicar un refactor algo tedioso vale, pero yo crearía una tarea para refactorizar la store y no tener que hacer esas cosas raras con el computed. Las stores ya son reactivas.

El nombre getStatus no me parece correcto. Como veo que puede implicar un refactor algo tedioso vale, pero yo crearía una tarea para refactorizar la store y no tener que hacer esas cosas raras con el computed. Las stores ya son reactivas.
jorgep reviewed 2024-11-06 15:12:49 +00:00
src/stores/invoiceOutGlobal.js
@ -200,4 +197,3 @@
this.addressIndex++;
this.isInvoicing = false;
} catch (err) {
if (err?.response?.status >= 400 && err?.response?.status < 500) {
jorgep commented 2024-11-06 15:12:49 +00:00
Member
Copy Link

habiamos dicho que los errores los maneje quasar, si se quiere que el usuario pueda notificar de este error (cuando se añada el btn de notificar) no tenemos que usar useNotify(). Se puede crear tarea.

habiamos dicho que los errores los maneje quasar, si se quiere que el usuario pueda notificar de este error (cuando se añada el btn de notificar) no tenemos que usar useNotify(). Se puede crear tarea.
alexm commented 2024-11-07 09:42:07 +00:00
Author
Member
Copy Link

En este caso es correcto pq no se quiere que el error interrumpa el proceso

En este caso es correcto pq no se quiere que el error interrumpa el proceso
jorgep approved these changes 2024-11-06 15:54:29 +00:00
alexm added 1 commit 2024-11-07 09:42:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
18cc3888e5 Merge branch 'dev' into warmFix_invoiceOut_Global
alexm merged commit 5d0c91187e into dev 2024-11-07 09:43:19 +00:00
alexm deleted branch warmFix_invoiceOut_Global 2024-11-07 09:43:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jorgep
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#900
No description provided.
Delete Branch "warmFix_invoiceOut_Global"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?