verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

feat: refs #6818 saysimple integration #904

Merged
jorgep merged 11 commits from 6818-saySimpleIntegration into dev 2024-11-13 08:25:27 +00:00
Conversation 0 Commits 11 Files Changed 2 +50 -5
jorgep commented 2024-11-08 11:19:04 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-11-08 11:19:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a467c44b91 feat: refs #6818 saysimple integration
jorgep added 1 commit 2024-11-08 12:06:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3bae121ed7 fix: refs #6818 use right icon
jorgep added 1 commit 2024-11-11 15:42:27 +00:00
jorgep requested review from alexm 2024-11-11 15:44:16 +00:00
alexm reviewed 2024-11-12 07:56:15 +00:00
src/components/ui/VnLinkPhone.vue Outdated
@ -3,0 +9,4 @@
const config = reactive({
sip: { icon: 'phone', href: `sip:${props.phoneNumber}` },
'say-simple': {
icon: 'help', // 'whatsapp',
alexm commented 2024-11-12 07:56:15 +00:00
Member
Copy Link

quitar comentario?

quitar comentario?
jorgep commented 2024-11-12 08:44:17 +00:00
Author
Member
Copy Link

Lo quiero dejar porque está pendiente. Cuando Paco rico lo pase lo añadiré pero de momento pongo ese. Le añado el número de tarea

Lo quiero dejar porque está pendiente. Cuando Paco rico lo pase lo añadiré pero de momento pongo ese. Le añado el número de tarea
jorgep marked this conversation as resolved
alexm requested changes 2024-11-12 07:58:11 +00:00
Dismissed
src/components/ui/VnLinkPhone.vue Outdated
@ -3,0 +20,4 @@
let channel = props.channel;
if (type === 'say-simple')
url = (await axios.get('SaySimpleConfigs/findOne')).data.url;
if (!props.channel)
alexm commented 2024-11-12 07:58:10 +00:00
Member
Copy Link

Y si el tipo no es say-simple igualmente le pone el canal?

Y si el tipo no es say-simple igualmente le pone el canal?
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-11-12 09:10:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
700701f055 refactor: refs #6818 channel logic
jorgep added 1 commit 2024-11-12 09:11:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
81b35aa75b chore: refs #6818 add spaces
jorgep requested review from alexm 2024-11-12 09:11:43 +00:00
alexm requested changes 2024-11-12 13:43:23 +00:00
Dismissed
src/components/ui/VnLinkPhone.vue Outdated
@ -3,0 +21,4 @@
let { channel } = config[type];
if (type === 'sip') return;
else if (type === 'say-simple') {
alexm commented 2024-11-12 13:42:25 +00:00
Member
Copy Link

es lo mismo que poner if (type === 'say-simple') directamente jaja

es lo mismo que poner if (type === 'say-simple') directamente jaja
jorgep commented 2024-11-12 13:59:48 +00:00
Author
Member
Copy Link

Tiene usted razón

Tiene usted razón
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-11-12 14:00:23 +00:00
jorgep added 1 commit 2024-11-12 14:01:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
83be57a0c4 chore: refs #6818 drop useless code & comment
jorgep requested review from alexm 2024-11-12 14:03:16 +00:00
alexm approved these changes 2024-11-13 08:19:10 +00:00
jorgep added 1 commit 2024-11-13 08:22:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
96e9de519f Merge branch 'dev' into 6818-saySimpleIntegration
jorgep merged commit d474fb924f into dev 2024-11-13 08:25:27 +00:00
jorgep deleted branch 6818-saySimpleIntegration 2024-11-13 08:25:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#904
No description provided.
Delete Branch "6818-saySimpleIntegration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?