verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

refs #6118 importSalixVariables #93

Merged
pablone merged 19 commits from 6118-responsiveFixes into dev 2023-10-30 10:32:15 +00:00
Conversation 0 Commits 19 Files Changed 4 +261 -254
pablone commented 2023-09-12 17:25:41 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2023-09-12 17:25:42 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
924dea66d4 refs #6118 importSalixVariables
pablone added 1 commit 2023-09-13 14:23:53 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
ae1ba448f7 refs #6118 fix
pablone added 1 commit 2023-09-13 14:29:14 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
39cbc32547 refs #6118 newVariable
pablone added 1 commit 2023-09-13 14:45:04 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
c727480569 refs #6118 scoppedcss
pablone changed title from WIP: refs #6118 importSalixVariables to refs #6118 importSalixVariables 2023-09-13 14:48:32 +00:00
pablone requested review from alexm 2023-09-13 14:48:37 +00:00
pablone requested review from juan 2023-09-14 16:06:37 +00:00
alexm reviewed 2023-09-18 08:15:42 +00:00
src/css/app.scss Outdated
@ -14,6 +14,12 @@ a {
color: $orange-4;
}
@media screen and (max-width: $width-md) {
alexm commented 2023-09-18 08:15:42 +00:00
Member
Copy Link

Esto lo arreglaria a nivel del componente (Es src/components/FormModel.vue)

Esto lo arreglaria a nivel del componente (Es src/components/FormModel.vue)
pablone marked this conversation as resolved
alexm reviewed 2023-09-18 08:17:57 +00:00
src/css/quasar.variables.scss Outdated
@ -48,2 +48,4 @@
$layout-shadow-dark: 0 0 10px 2px rgba(0, 0, 0, 0.2), 0 0px 10px rgba(0, 0, 0, 0.24);
$spacing-md: 16px;
// Width from Salix variables.scss
alexm commented 2023-09-18 08:17:57 +00:00
Member
Copy Link

Estes variables quasar ja les te definides, per exemple max-width: $breakpoint-xs
Pots buscar en VSC, $breakpoint

Aci tens mes info de quasar: https://quasar.dev/style/breakpoints/

Estes variables quasar ja les te definides, per exemple `max-width: $breakpoint-xs` Pots buscar en VSC, $breakpoint Aci tens mes info de quasar: https://quasar.dev/style/breakpoints/
pablone marked this conversation as resolved
alexm requested changes 2023-09-18 08:19:42 +00:00
src/pages/Customer/Card/CustomerBasicData.vue Outdated
@ -173,6 +173,7 @@ const filterOptions = {
<style lang="scss" scoped>
alexm commented 2023-09-18 08:19:38 +00:00
Member
Copy Link

Si ho fas a nivell de component pots borrar, estos codis que veges (com provant que funcione igual)

Si ho fas a nivell de component pots borrar, estos codis que veges (com provant que funcione igual)
pablone marked this conversation as resolved
pablone added 1 commit 2023-09-19 07:41:47 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
8d27ef5402 refs #6118 fixResponsive
pablone added 1 commit 2023-09-19 07:42:20 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
b66c265dee refs #6118 removeVariables
pablone requested review from alexm 2023-09-19 07:44:51 +00:00
alexm approved these changes 2023-09-20 05:07:00 +00:00
Dismissed
juan requested changes 2023-09-22 08:13:04 +00:00
src/components/FormModel.vue Outdated
@ -131,2 +138,4 @@
/>
</template>
<style lang="scss">
juan commented 2023-09-22 08:12:59 +00:00
Owner
Copy Link

Declarar como scoped y usar un id

Declarar como scoped y usar un id
pablone marked this conversation as resolved
pablone force-pushed 6118-responsiveFixes from 631c77b850 to 9dd69dbcb7 2023-10-19 06:45:34 +00:00 Compare
pablone dismissed alexm’s review 2023-10-19 06:45:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone added 1 commit 2023-10-19 12:50:38 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
edf6de2510 feat(app.scss): vn-horizontal flex direction column refs #6118
pablone requested review from juan 2023-10-19 12:51:10 +00:00
alexm reviewed 2023-10-20 11:43:31 +00:00
src/pages/Claim/Card/ClaimBasicData.vue Outdated
@ -143,0 +99,4 @@
model="claim"
>
<template #form="{ data, validate, filter }">
<vn-horizontal class="row q-gutter-md q-mb-md">
alexm commented 2023-10-20 11:43:31 +00:00
Member
Copy Link

Si el fiques en KebabCase com esta quasar funciona??

Si el fiques en KebabCase com esta quasar funciona??
pablone marked this conversation as resolved
alexm approved these changes 2023-10-20 11:44:04 +00:00
Dismissed
alexm left a comment
Member
Copy Link

encomter de vn-horizontal, VnHorizontal funciona?

encomter de vn-horizontal, VnHorizontal funciona?
pablone added 1 commit 2023-10-20 12:21:20 +00:00
pablone dismissed alexm’s review 2023-10-20 12:21:20 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone added 1 commit 2023-10-20 12:37:20 +00:00
alexm requested changes 2023-10-24 07:54:29 +00:00
src/css/app.scss Outdated
@ -46,2 +46,4 @@
background-color: var(--vn-dark);
}
html [vnRow],
alexm commented 2023-10-24 07:54:26 +00:00
Member
Copy Link

VnRow no se pot?

VnRow no se pot?
pablone marked this conversation as resolved
pablone added 1 commit 2023-10-25 16:44:44 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
36cf762857 feat(VnRow): add new conponenet VnRow refs #6118
pablone added 1 commit 2023-10-25 16:48:59 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
157a2b854e fix(vnRow): refs #6118 remove script label
pablone added 1 commit 2023-10-25 16:50:53 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d31757e63d remove(vnRow): refs #6118 remove html custom elemnt
pablone added 1 commit 2023-10-25 18:09:48 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
b3df66b566 remove(div): refs #6118 unificar los divs en el componente
pablone requested review from alexm 2023-10-25 18:13:31 +00:00
pablone added 1 commit 2023-10-26 08:24:47 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
e1340b59d2 Merge branch 'dev' into 6118-responsiveFixes
alexm requested changes 2023-10-26 10:56:44 +00:00
alexm left a comment
Member
Copy Link

Revisar minusculas

Revisar minusculas
src/pages/Customer/Card/CustomerBasicData.vue Outdated
@ -178,1 +63,3 @@
</style>
<FormModel :url="`Clients/${route.params.id}`" model="customer">
<template #form="{ data, validate, filter }">
<vnRow class="row q-gutter-md q-mb-md">
alexm commented 2023-10-26 10:56:22 +00:00
Member
Copy Link

Aci

Aci
pablone marked this conversation as resolved
src/pages/Customer/Card/CustomerBasicData.vue Outdated
@ -179,0 +84,4 @@
:input-debounce="0"
/>
</div>
</vnRow>
alexm commented 2023-10-26 10:56:25 +00:00
Member
Copy Link

Aci

Aci
pablone marked this conversation as resolved
pablone added 2 commits 2023-10-26 13:01:34 +00:00
pablone requested review from alexm 2023-10-26 13:02:49 +00:00
alexm approved these changes 2023-10-27 05:53:54 +00:00
juan approved these changes 2023-10-30 10:02:23 +00:00
pablone merged commit 2dab91ea19 into dev 2023-10-30 10:32:15 +00:00
pablone deleted branch 6118-responsiveFixes 2023-10-30 10:32:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
juan
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#93
No description provided.
Delete Branch "6118-responsiveFixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?