verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

Change layout CustomerDescriptor Actions #931

Merged
jsegarra merged 3 commits from warmFix_customerDescriptorActions into dev 2024-11-14 12:23:33 +00:00
Conversation 0 Commits 3 Files Changed 4 +49 -41
jsegarra commented 2024-11-14 10:18:32 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2024-11-14 11:06:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ecf131ba78 feat: move buttons to DescriptorMenu
jsegarra requested review from jorgep 2024-11-14 11:08:02 +00:00
jorgep reviewed 2024-11-14 11:12:22 +00:00
src/pages/Customer/Card/CustomerDescriptorMenu.vue
@ -41,2 +41,4 @@
}
};
const openTicketCreateForm = () => {
jorgep commented 2024-11-14 11:12:22 +00:00
Member
Copy Link

Solo cambia el parámetro que pasas a openWindow, porque no llamas directamente a openWindow con el parámetro (order || ticket) y que este cree la query?
De paso, si lo ves útil, mira a ver si puedes usar esto: https://quasar.dev/quasar-utils/other-utils#openurl para no usar window.open

Solo cambia el parámetro que pasas a openWindow, porque no llamas directamente a openWindow con el parámetro (order || ticket) y que este cree la query? De paso, si lo ves útil, mira a ver si puedes usar esto: https://quasar.dev/quasar-utils/other-utils#openurl para no usar window.open
jsegarra commented 2024-11-14 11:23:00 +00:00
Author
Member
Copy Link

Me gusta lo de quasar, creo nadie lo usa, creo composable!
Por otra parte, fijate que las claves de query.createForm no coinciden para los 2 modelos

Me gusta lo de quasar, creo nadie lo usa, creo composable! Por otra parte, fijate que las claves de query.createForm no coinciden para los 2 modelos
jorgep commented 2024-11-14 11:25:44 +00:00
Member
Copy Link

Tienes razón, cambia 1, de todas maneras el 90% de ambas fn es el mismo código, Usar solo 1 fn.

Tienes razón, cambia 1, de todas maneras el 90% de ambas fn es el mismo código, Usar solo 1 fn.
jorgep requested changes 2024-11-14 11:20:30 +00:00
Dismissed
jorgep left a comment
Member
Copy Link

.

.
jsegarra added 1 commit 2024-11-14 11:48:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
291e97e540 feat: #6943 use openURL quasar
jsegarra requested review from jorgep 2024-11-14 11:48:46 +00:00
jorgep reviewed 2024-11-14 11:51:32 +00:00
src/composables/useOpenURL.js
@ -0,0 +1,8 @@
import { openURL } from 'quasar';
jorgep commented 2024-11-14 11:51:32 +00:00
Member
Copy Link

💯

💯
jorgep approved these changes 2024-11-14 11:52:09 +00:00
jsegarra added 1 commit 2024-11-14 12:22:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
61cd8c49c6 Merge branch 'dev' into warmFix_customerDescriptorActions
jsegarra merged commit 68994db6ff into dev 2024-11-14 12:23:33 +00:00
jsegarra deleted branch warmFix_customerDescriptorActions 2024-11-14 12:23:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jorgep
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#931
No description provided.
Delete Branch "warmFix_customerDescriptorActions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?