verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

Change layout CustomerDescriptor Actions #931

Merged
jsegarra merged 3 commits from warmFix_customerDescriptorActions into dev 2024-11-14 12:23:33 +00:00
Conversation 0 Commits 3 Files Changed 4 +22 -26
2 changed files with 22 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 291e97e540 - Show all commits

8
src/composables/useOpenURL.js Normal file
View File

@ -0,0 +1,8 @@
import { openURL } from 'quasar';
jorgep commented 2024-11-14 11:51:32 +00:00
Review
Copy Link

💯

💯
const defaultWindowFeatures = {
noopener: true,
noreferrer: true,
};
export default function (url, windowFeatures = defaultWindowFeatures, fn = undefined) {
openURL(url, fn, windowFeatures);
}

40
src/pages/Customer/Card/CustomerDescriptorMenu.vue
View File

@ -6,8 +6,8 @@ import axios from 'axios';
import { useQuasar } from 'quasar';
import useNotify from 'src/composables/useNotify';
import VnSmsDialog from 'src/components/common/VnSmsDialog.vue';
import useOpenURL from 'src/composables/useOpenURL';
const $props = defineProps({
customer: {
@ -15,7 +15,6 @@ const $props = defineProps({
required: true,
},
});
const { notify } = useNotify();
const { t } = useI18n();
const quasar = useQuasar();
@ -41,48 +40,37 @@ const sendSms = async (payload) => {
}
};
const openTicketCreateForm = () => {
const openCreateForm = (type) => {
const query = {
jorgep commented 2024-11-14 11:12:22 +00:00
Review
Copy Link

Solo cambia el parámetro que pasas a openWindow, porque no llamas directamente a openWindow con el parámetro (order || ticket) y que este cree la query?
De paso, si lo ves útil, mira a ver si puedes usar esto: https://quasar.dev/quasar-utils/other-utils#openurl para no usar window.open

Solo cambia el parámetro que pasas a openWindow, porque no llamas directamente a openWindow con el parámetro (order || ticket) y que este cree la query? De paso, si lo ves útil, mira a ver si puedes usar esto: https://quasar.dev/quasar-utils/other-utils#openurl para no usar window.open
jsegarra commented 2024-11-14 11:23:00 +00:00
Review
Copy Link

Me gusta lo de quasar, creo nadie lo usa, creo composable!
Por otra parte, fijate que las claves de query.createForm no coinciden para los 2 modelos

Me gusta lo de quasar, creo nadie lo usa, creo composable! Por otra parte, fijate que las claves de query.createForm no coinciden para los 2 modelos
jorgep commented 2024-11-14 11:25:44 +00:00
Review
Copy Link

Tienes razón, cambia 1, de todas maneras el 90% de ambas fn es el mismo código, Usar solo 1 fn.

Tienes razón, cambia 1, de todas maneras el 90% de ambas fn es el mismo código, Usar solo 1 fn.
table: {
clientFk: $props.customer.id,
},
createForm: {
clientId: $props.customer.id,
addressId: $props.customer.defaultAddressFk,
},
};
openWindow('ticket', query);
};
const openOrderCreateForm = () => {
const query = {
table: {
clientFk: $props.customer.id,
},
createForm: {
clientFk: $props.customer.id,
addressId: $props.customer.defaultAddressFk,
},
const clientFk = {
ticket: 'clientId',
order: 'clientFk',
};
openWindow('order', query);
};
const key = clientFk[type];
if (!key) return;
query.createForm[key] = $props.customer.id;
const openWindow = (type, { createForm, table }) => {
window.open(
`/#/${type}/list?createForm=${JSON.stringify(createForm)}&table=${JSON.stringify(
table
)}`,
'_blank'
);
const params = Object.entries(query)
.map(([key, value]) => `${key}=${JSON.stringify(value)}`)
.join('&');
useOpenURL(`/#/${type}/list?${params}`);
};
</script>
<template>
<QItem v-ripple clickable @click="openTicketCreateForm()">
<QItem v-ripple clickable @click="openCreateForm('ticket')">
<QItemSection>
{{ t('globals.pageTitles.createTicket') }}
</QItemSection>
</QItem>
<QItem v-ripple clickable @click="openOrderCreateForm()">
<QItem v-ripple clickable @click="openCreateForm('order')">
<QItemSection>
{{ t('globals.pageTitles.createOrder') }}
</QItemSection>