verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

#8162 - E2E Tickets #951

Merged
jsegarra merged 7 commits from wbuezas/salix-front-mindshore-fork2:8162-E2ETickets into dev 2024-11-21 09:19:55 +00:00
Conversation 0 Commits 7 Files Changed 19 +301 -10
wbuezas commented 2024-11-17 18:34:46 +00:00
Contributor
Copy Link
No description provided.
wbuezas added 2 commits 2024-11-17 18:34:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d8c1bd5b16 test: refs #8162 more tests
wbuezas requested review from jsegarra 2024-11-18 11:45:37 +00:00
jsegarra added 1 commit 2024-11-18 12:03:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2f06eea8ea Merge branch 'dev' into 8162-E2ETickets
jsegarra changed title from 8162-E2ETickets to 8162 - E2E Tickets 2024-11-18 12:13:52 +00:00
jsegarra requested changes 2024-11-18 13:41:19 +00:00
Dismissed
src/pages/Ticket/Card/TicketSale.vue Outdated
@ -834,3 +837,3 @@
{{ toPercentage(row.discount / 100) }}
</QBtn>
<TicketEditManaProxy
<!-- <TicketEditManaProxy
jsegarra commented 2024-11-18 13:40:44 +00:00
Member
Copy Link

Si es comentario, quitar.
Hay algun motivo por el que mantenerlo?

Si es comentario, quitar. Hay algun motivo por el que mantenerlo?
wbuezas commented 2024-11-18 13:49:01 +00:00
Author
Contributor
Copy Link

Removí el comentario, se me olvidó de quitar.

Commit: 28bfda869a

Removí el comentario, se me olvidó de quitar. Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/28bfda869a23f315c9a7d0c52ba717fe3397b781
jsegarra added 1 commit 2024-11-18 13:41:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
73072794ee test: refs #8162 #8162 fix TicketList spec
jsegarra changed title from 8162 - E2E Tickets to #8162 - E2E Tickets 2024-11-18 13:44:35 +00:00
wbuezas added 1 commit 2024-11-18 13:48:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
28bfda869a refactor: refs #8162 remove comment
jsegarra approved these changes 2024-11-18 21:37:36 +00:00
Dismissed
alexm requested changes 2024-11-19 06:43:26 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Dijimos "data-cy" para usarlo en los e2e

Dijimos "data-cy" para usarlo en los e2e
👍 1
jsegarra requested changes 2024-11-19 09:01:50 +00:00
Dismissed
test/cypress/support/commands.js Outdated
@ -312,2 +312,4 @@
cy.get(`[label="${label}"] > .q-field > .q-field__inner`).type(`${value}{enter}`);
});
Cypress.Commands.add('dataCy', (dataTestId, attr = 'data-testid') => {
jsegarra commented 2024-11-19 09:01:47 +00:00
Member
Copy Link

El comando es dataCy pero la prop es data-testid, mejor lo dejamos como dataCy

El comando es dataCy pero la prop es data-testid, mejor lo dejamos como dataCy
wbuezas commented 2024-11-20 22:00:04 +00:00
Author
Contributor
Copy Link

Aplicado.

Aplicado.
wbuezas added 1 commit 2024-11-20 21:58:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8e411125bf test: refs #8162 more tests and change data-testid for data-cy
wbuezas dismissed jsegarra’s review 2024-11-20 21:58:22 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

wbuezas requested review from alexm 2024-11-20 21:59:41 +00:00
wbuezas requested review from jsegarra 2024-11-20 21:59:49 +00:00
jsegarra approved these changes 2024-11-20 22:08:21 +00:00
Dismissed
alexm refused to review 2024-11-21 06:57:17 +00:00
alexm approved these changes 2024-11-21 06:57:23 +00:00
Dismissed
jsegarra added 1 commit 2024-11-21 08:20:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
81d7b9f04f Merge branch 'dev' into 8162-E2ETickets
jsegarra dismissed jsegarra’s review 2024-11-21 08:20:31 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra dismissed alexm’s review 2024-11-21 08:20:31 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra scheduled this pull request to auto merge when all checks succeed 2024-11-21 08:20:39 +00:00
jsegarra requested review from jsegarra 2024-11-21 09:19:45 +00:00
jsegarra approved these changes 2024-11-21 09:19:48 +00:00
jsegarra merged commit 3bc5c9bd6a into dev 2024-11-21 09:19:55 +00:00
jsegarra deleted branch 8162-E2ETickets 2024-11-21 09:19:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#951
No description provided.
Delete Branch "wbuezas/salix-front-mindshore-fork2:8162-E2ETickets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?