verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

hotFix(TicketBasicData): getShipped, getLanded & bad try catch #953

Merged
alexm merged 3 commits from hotFix_ticketBasicData_getLanded_getShipped into master 2024-11-18 09:13:15 +00:00
Conversation 0 Commits 3 Files Changed 2 +88 -136
alexm commented 2024-11-18 08:18:40 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-11-18 08:18:41 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
e230cc61a0 fix(TicketBasicData): getShipped, getLanded & bad try catch
alexm requested review from jsegarra 2024-11-18 08:27:00 +00:00
alexm changed title from fix(TicketBasicData): getShipped, getLanded & bad try catch to hotFix(TicketBasicData): getShipped, getLanded & bad try catch 2024-11-18 08:27:07 +00:00
jsegarra approved these changes 2024-11-18 09:07:32 +00:00
alexm added 1 commit 2024-11-18 09:08:31 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
a50b22bb2a Merge branch 'master' into hotFix_ticketBasicData_getLanded_getShipped
alexm added 1 commit 2024-11-18 09:12:29 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
b74c1d1823 Merge branch 'master' into hotFix_ticketBasicData_getLanded_getShipped
alexm merged commit 03490b7f3a into master 2024-11-18 09:13:15 +00:00
alexm deleted branch hotFix_ticketBasicData_getLanded_getShipped 2024-11-18 09:13:15 +00:00
jsegarra reviewed 2024-11-18 09:56:40 +00:00
src/pages/Ticket/Card/BasicData/TicketBasicDataForm.vue
@ -198,0 +157,4 @@
function addDateParams(obj) {
return {
...obj,
...{
jsegarra commented 2024-11-18 09:56:40 +00:00
Member
Copy Link

No lo habia visto, porque hay otros casos que cambia Fk por Id
Entonces, que te parece esta idea para que la legilibidad y escalabilidad sea mejor? O al menos a mi me lo parece

const { addressFk, agencyModeFk, warehouseFk } = formData.value || {}; const payload = { addressFk, agencyModeFk, warehouseFk };
Y esto a su vez es mejorable
const payload = (({ addressFk, agencyModeFk, warehouseFk }) => ({ addressFk, agencyModeFk, warehouseFk }))(formData.value || {});

No lo habia visto, porque hay otros casos que cambia Fk por Id Entonces, que te parece esta idea para que la legilibidad y escalabilidad sea mejor? O al menos a mi me lo parece `const { addressFk, agencyModeFk, warehouseFk } = formData.value || {}; const payload = { addressFk, agencyModeFk, warehouseFk }; ` Y esto a su vez es mejorable `const payload = (({ addressFk, agencyModeFk, warehouseFk }) => ({ addressFk, agencyModeFk, warehouseFk }))(formData.value || {});`
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#953
No description provided.
Delete Branch "hotFix_ticketBasicData_getLanded_getShipped"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?