verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

#8138 add-component-ticketProblems #962

Merged
pablone merged 7 commits from 8138-add-component-ticketProblems into dev 2024-11-20 05:02:51 +00:00
Conversation 1 Commits 7 Files Changed 4 +61 -135
pablone commented 2024-11-19 07:02:22 +00:00
Member
Copy Link
No description provided.
pablone added 2 commits 2024-11-19 07:02:23 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
f999760205 fix: refs #8138 sme minor issues
pablone requested review from jsegarra 2024-11-19 07:02:30 +00:00
pablone added 1 commit 2024-11-19 07:02:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6ab31fa2d2 Merge branch 'dev' into 8138-add-component-ticketProblems
jsegarra reviewed 2024-11-19 07:56:25 +00:00
src/components/ui/TicketProblems.vue Outdated
@ -0,0 +1,40 @@
<script setup>
defineProps({ row: { type: Object, required: true } });
jsegarra commented 2024-11-19 07:56:25 +00:00
Member
Copy Link

Duda: defineModel serviría también, no?

Duda: defineModel serviría también, no?
pablone marked this conversation as resolved
jsegarra requested changes 2024-11-19 07:58:56 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

La ubicación del componente está casi perfecta.
Entiendo que se usa en 2 modilos diferentes, pero no es un componente visual, por tanto, habria que subirlo un nivel, de igual manera que está CreateThermographForm

La ubicación del componente está **casi** perfecta. Entiendo que se usa en 2 modilos diferentes, pero no es un componente visual, por tanto, habria que subirlo un nivel, de igual manera que está CreateThermographForm
jsegarra changed title from 8138-add-component-ticketProblems to #8138 add-component-ticketProblems 2024-11-19 08:00:57 +00:00
pablone added 2 commits 2024-11-19 12:51:27 +00:00
pablone added 1 commit 2024-11-19 12:54:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fb5e38dc0b Merge branch 'dev' into 8138-add-component-ticketProblems
pablone scheduled this pull request to auto merge when all checks succeed 2024-11-19 12:54:57 +00:00
pablone requested review from jsegarra 2024-11-19 12:54:58 +00:00
pablone scheduled this pull request to auto merge when all checks succeed 2024-11-19 12:55:08 +00:00
jsegarra approved these changes 2024-11-19 13:26:51 +00:00
jsegarra commented 2024-11-19 13:27:42 +00:00
Member
Copy Link

2 cosas

  1. Me gusta el efecto 3D que tiene la tabla cuando haces scroll horizontal
  2. los iconos de la columna acciones debería estar en naranja, y el tooltip del botón no está bien
2 cosas 1. Me gusta el efecto 3D que tiene la tabla cuando haces scroll horizontal 2. los iconos de la columna acciones debería estar en naranja, y el tooltip del botón no está bien
pablone added 1 commit 2024-11-20 05:02:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8b5a2cd159 Merge branch 'dev' into 8138-add-component-ticketProblems
pablone merged commit cbdce8f474 into dev 2024-11-20 05:02:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#962
No description provided.
Delete Branch "8138-add-component-ticketProblems"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?