verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 62 Releases Wiki Activity

ref #5417 fix filters and view #97

Merged
jorgep merged 12 commits from 5417-fixCustomerPayments into dev 2023-10-18 07:25:29 +00:00
Conversation 0 Commits 12 Files Changed 5 +165 -25
jorgep commented 2023-09-27 11:48:21 +00:00
Member
Copy Link

Se podría también mirar de pasarle un parámetro a useArrayDataStore, tipo showAll: false.

Se podría también mirar de pasarle un parámetro a useArrayDataStore, tipo showAll: false.
jorgep added 1 commit 2023-09-27 11:48:22 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
7ae098d779 ref #5417 fix filters and view
jorgep requested review from alexm 2023-09-27 11:50:32 +00:00
jorgep requested review from jgallego 2023-09-27 11:51:05 +00:00
jgallego approved these changes 2023-09-27 14:06:12 +00:00
Dismissed
jorgep added 1 commit 2023-09-29 06:32:23 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d1fe9bbe25 Merge branch 'dev' into 5417-fixCustomerPayments
jgallego changed title from WIP ref #5417 fix filters and view to ref #5417 fix filters and view 2023-09-29 07:15:41 +00:00
alexm approved these changes 2023-09-29 10:13:00 +00:00
Dismissed
jorgep changed title from ref #5417 fix filters and view to WIP ref #5417 fix filters and view 2023-09-29 10:29:07 +00:00
jorgep added 3 commits 2023-09-29 11:59:58 +00:00
jorgep dismissed jgallego’s review 2023-09-29 11:59:58 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep dismissed alexm’s review 2023-09-29 11:59:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep changed title from WIP ref #5417 fix filters and view to ref #5417 fix filters and view 2023-09-29 12:00:46 +00:00
jgallego requested changes 2023-10-02 05:36:05 +00:00
src/composables/useArrayData.js Outdated
@ -138,2 +138,2 @@
async function refresh() {
await fetch({ append: false });
async function refresh(showAll = true) {
if (showAll || (!showAll && Object.values(store.userParams).length))
jgallego commented 2023-10-02 05:33:33 +00:00
Owner
Copy Link

!showAll sobraria no?

!showAll sobraria no?
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-10-02 07:03:17 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
2b10278901 ref #5417 fix refresh method
jorgep added 1 commit 2023-10-02 08:11:05 +00:00
gitea/salix-front/pipeline/head There was a failure building this commit Details
8d28a5f82c ref #5417 locales
jorgep added 1 commit 2023-10-11 08:41:23 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
0aefe13935 ref #5417 fix autoload and filters
jorgep requested review from jgallego 2023-10-11 08:41:41 +00:00
jorgep added 1 commit 2023-10-11 08:47:44 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d9b4ee006d ref #5417 refresh fixed
jorgep added 1 commit 2023-10-11 08:55:23 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
6d116b9798 ref #5417 search and refresh fixed
jorgep reviewed 2023-10-11 08:57:59 +00:00
src/components/ui/VnFilterPanel.vue
@ -48,3 +52,3 @@
isLoading.value = true;
await arrayData.addFilter({ params });
if (!props.showAll && !Object.values(store.userParams).length) store.data = [];
jorgep commented 2023-10-11 08:57:59 +00:00
Author
Member
Copy Link

Por algún motivo, no se eliminan params.from ni params.to. Solo se elimina su valor, aunque se haga el delete, en la store.userParams si que se eliminan. @alexm

Por algún motivo, no se eliminan params.from ni params.to. Solo se elimina su valor, aunque se haga el delete, en la store.userParams si que se eliminan. @alexm
jorgep marked this conversation as resolved
jorgep added the
CR / Tests passed
 label 2023-10-11 08:58:24 +00:00
jgallego approved these changes 2023-10-11 09:03:47 +00:00
Dismissed
alexm approved these changes 2023-10-11 09:42:10 +00:00
Dismissed
jorgep added 1 commit 2023-10-11 10:33:45 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
e5ffd2faad ref #5417 params fixed
jorgep dismissed jgallego’s review 2023-10-11 10:33:46 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep dismissed alexm’s review 2023-10-11 10:33:46 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2023-10-11 10:36:03 +00:00
src/components/ui/VnFilterPanel.vue
@ -53,3 +57,4 @@
async function reload() {
isLoading.value = true;
const params = Object.values(userParams.value).filter((param) => param);
jorgep commented 2023-10-11 10:36:03 +00:00
Author
Member
Copy Link

He probado a copiar el objeto con JSON.parse pero no funciona en este caso. @alexm

He probado a copiar el objeto con JSON.parse pero no funciona en este caso. @alexm
jorgep added 1 commit 2023-10-13 10:32:45 +00:00
jgallego approved these changes 2023-10-13 10:53:35 +00:00
alexm approved these changes 2023-10-18 07:21:02 +00:00
jorgep merged commit 59b5daed51 into dev 2023-10-18 07:25:29 +00:00
jorgep deleted branch 5417-fixCustomerPayments 2023-10-18 07:25:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#97
No description provided.
Delete Branch "5417-fixCustomerPayments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?