verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

WARMFIX: e2e jsegarra #973

Merged
jsegarra merged 12 commits from fix_js_e2e into test 2024-11-21 08:20:22 +00:00
Conversation 3 Commits 12 Files Changed 3 +27 -45
jsegarra commented 2024-11-19 14:58:07 +00:00
Member
Copy Link
No description provided.
jsegarra added 4 commits 2024-11-19 14:58:07 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
b4ee19bcde test: #8162 fix clientList spec
jsegarra added 3 commits 2024-11-20 08:26:45 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
e10ee5e6c7 test: #8162 fix vnLocation spec
jsegarra commented 2024-11-20 08:27:32 +00:00
Author
Member
Copy Link

image

![image](/attachments/06f408ff-edc8-45df-8555-8186addda038)
image.png
15 KiB
jsegarra commented 2024-11-20 08:37:36 +00:00
Author
Member
Copy Link

image

![image](/attachments/fb6f4735-5579-4811-8a1e-37fdb7f5169c)
image.png
37 KiB
jsegarra added 1 commit 2024-11-20 08:37:53 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
226f604f9d test: #8162 fix vnLocation spec
jsegarra commented 2024-11-20 08:38:30 +00:00
Author
Member
Copy Link

image

![image](/attachments/2726703f-e5ee-4c49-9788-7d50c914b7e6)
image.png
17 KiB
jsegarra requested review from alexm 2024-11-20 08:38:37 +00:00
jsegarra changed title from WIP: WARMFIX: e2e jsegarra to WARMFIX: e2e jsegarra 2024-11-20 08:38:39 +00:00
alexm requested changes 2024-11-20 08:47:32 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Una cosa que yo suelo hacer, es revisar mi propia pr antes de pedir revision, por si me he dejado algun console.log o código comentado 😊

Una cosa que yo suelo hacer, es revisar mi propia pr antes de pedir revision, por si me he dejado algun console.log o código comentado 😊
test/cypress/integration/client/clientList.spec.js Outdated
@ -53,1 +57,3 @@
cy.checkValueForm(1, search);
cy.checkValueSelectForm(1, search);
cy.checkValueSelectForm(2, search);
// cy.get('@Open').should('have.been.calledOnceWithExactly', [
alexm commented 2024-11-20 08:45:58 +00:00
Member
Copy Link

?

?
jsegarra marked this conversation as resolved
test/cypress/integration/client/clientList.spec.js Outdated
@ -60,2 +70,4 @@
cy.waitForElement('.q-form');
cy.checkValueForm(1, search);
cy.checkValueForm(2, search);
// cy.get('@Open').should(
alexm commented 2024-11-20 08:46:05 +00:00
Member
Copy Link

?

?
test/cypress/support/commands.js Outdated
@ -295,3 +295,3 @@
});
});
// :nth-child(2) > .q-field > .q-field__inner > .q-field__control > .q-field__control-container
alexm commented 2024-11-20 08:46:47 +00:00
Member
Copy Link

?

?
jsegarra marked this conversation as resolved
jsegarra added 2 commits 2024-11-20 09:05:15 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
deb6467af8 feat: remove comments
jsegarra added 1 commit 2024-11-20 09:07:08 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
d6aedad38e perf: use const in VnLocation
jsegarra requested review from alexm 2024-11-20 22:05:20 +00:00
alexm approved these changes 2024-11-21 06:56:41 +00:00
jsegarra added 1 commit 2024-11-21 08:19:22 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
5a90434425 Merge branch 'test' into fix_js_e2e
jsegarra merged commit 6f324b44b8 into test 2024-11-21 08:20:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#973
No description provided.
Delete Branch "fix_js_e2e"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?