#8113 create arrayDataStore map #979

Open
jorgep wants to merge 16 commits from 8113-preventDuplicateRecords into dev
Member
No description provided.
jorgep added 1 commit 2024-11-20 16:28:18 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
99600f995d
fix: refs #8113 create arrayData store map wip
jorgep added 1 commit 2024-11-22 09:11:20 +00:00
jorgep added 1 commit 2024-11-22 09:13:55 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
683940cc24
fix: refs #8113 improve logic wip
jorgep added 1 commit 2024-11-22 15:00:09 +00:00
jorgep added 1 commit 2024-11-22 17:16:17 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ed8c124bc7
fix: refs #8113 load map logic
jorgep added 1 commit 2024-11-25 10:27:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
a9cc6952d0
refactor: refs #8113 use a fn
jorgep added 1 commit 2024-11-25 10:31:04 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
948a43a325
fix: refs #8113 unit test wip
jorgep added 1 commit 2024-11-25 13:36:26 +00:00
jorgep added 1 commit 2024-11-25 13:39:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
dd6604feff
fix: refs #8113 use id as key
jorgep reviewed 2024-11-25 13:41:15 +00:00
@ -62,3 +54,4 @@
expect(vm.store.skip).toEqual(3);
expect(vm.store.data.length).toEqual(6);
vi.spyOn(axios, 'get').mockResolvedValue({
Author
Member

Si son los mismos registros ahora no los va a volver a añadir.

Si son los mismos registros ahora no los va a volver a añadir.
jorgep added 1 commit 2024-11-25 15:01:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d1684b4ae6
feat: refs #8113 add map-key
jorgep added 1 commit 2024-11-25 15:48:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e4bac3edab
refactor: refs #8113 fine tunning processData
jorgep changed title from WIP: fix: refs #8113 create arrayData store map wip to #8113 create arrayData store map wip 2024-11-25 15:49:03 +00:00
jorgep changed title from #8113 create arrayData store map wip to #8113 create arrayDataStore map 2024-11-25 15:49:24 +00:00
jorgep reviewed 2024-11-25 15:50:44 +00:00
@ -441,6 +441,7 @@ watch(
<QPage class="column items-center q-pa-md">
<VnTable
data-key="advanceTickets"
:map-key="false"
Author
Member

Aquí se quiere tener duplicados.

Aquí se quiere tener duplicados.
jorgep reviewed 2024-11-25 15:51:50 +00:00
@ -288,6 +283,31 @@ export function useArrayData(key = useRoute().meta.moduleName, userOptions) {
router.replace(newUrl);
}
function processData(data, { map = true, append = true }) {
Author
Member

Se puede meter directamente el snippet en la fn fetch, pero , por legibilidad creo que es mejor dejarlo en esta fn.

Se puede meter directamente el snippet en la fn fetch, pero , por **legibilidad** creo que es mejor dejarlo en esta fn.
jorgep added 1 commit 2024-11-25 15:53:17 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7fdcb1eace
chore: refs #8113 drop console log
jorgep added 1 commit 2024-11-25 15:57:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f32c08bd1d
refactor: refs #8113 fine tunning processData
jorgep reviewed 2024-11-25 16:29:17 +00:00
@ -291,0 +290,4 @@
}
if (!map && !append) store.data = data;
else if (!map && append) for (const row of data) store.data.push(row);
Author
Member

Se podría usar ... pero he leído que en términos de rendimiento a la hora de manejar arrays muy grande es más rápido un for.

Se podría usar **...** pero he leído que en términos de rendimiento a la hora de manejar arrays muy grande es más rápido un for.
jorgep added 1 commit 2024-11-26 08:46:47 +00:00
jorgep added 1 commit 2024-11-26 09:05:22 +00:00
jorgep added 1 commit 2024-11-26 11:04:17 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4c2a576915
fix: refs #8113 test e2e & refactor
jorgep requested review from juan 2024-11-26 11:11:11 +00:00
jorgep added the
CR / Tests passed
label 2024-11-26 11:11:18 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#979
No description provided.